[GitHub] [commons-lang] garydgregory commented on pull request #1021: Created a new function for the StringUtils class.
garydgregory commented on PR #1021: URL: https://github.com/apache/commons-lang/pull/1021#issuecomment-1396339399 -1 does not belong in this component IMO and you can't convert a sentence into a palindrome anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] emeraldswag312 opened a new pull request, #1021: Created a new function for the StringUtils class.
emeraldswag312 opened a new pull request, #1021: URL: https://github.com/apache/commons-lang/pull/1021 Created a new function called palindrome to create a palindrome from an input string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
sebbASF commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1080653735
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -375,7 +375,7 @@ public int execADAT(final byte[] data) throws IOException {
/**
* AUTH command.
*
- * @throws SSLException If it server reply code not equal "234" and "334".
+ * @throws SSLException If the server reply code ss equal to neither "234"
nor "334".
Review Comment:
Does not read well; and what is 'ss' ?
Might be better to put:
If the server reply code equals neither "234" nor "334".
##
src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java:
##
@@ -57,7 +57,7 @@ public class VMSFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* Constructor for a VMSFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
This should agree with the wording above
##
src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java:
##
@@ -68,7 +68,7 @@ public VMSFTPEntryParser() {
* This constructor allows the creation of a VMSFTPEntryParser object with
something other than the default configuration.
*
* @param config The {@link FTPClientConfig configuration} object used to
configure this parser.
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Ditto
##
src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java:
##
@@ -437,8 +437,8 @@ private FTPFile parseMemberList(final String entry) {
}
/**
- * preParse is called as part of the interface. Per definition is is
called before the parsing takes place. Three kind of lists is recognize:
z/OS-MVS File
- * lists z/OS-MVS Member lists unix file lists
+ * preParse is called as part of the interface. Per definition, it is
called before the parsing takes place. Three kinds of lists are recognized:
+ * z/OS-MVS File lists z/OS-MVS Member lists unix file lists
Review Comment:
Need some delimiters - e.g. commas - to show the lists clearly.
Better would be to use a list.
##
src/main/java/org/apache/commons/net/imap/IMAPReply.java:
##
@@ -74,7 +74,7 @@ public final class IMAPReply {
private static final Pattern LITERAL_PATTERN =
Pattern.compile("\\{(\\d+)\\}$"); // {dd}
/**
- * Intepret the String reply code - OK, NO, BAD - in a tagged response as
a integer.
+ * Intepret the String reply code - OK, NO, BAD - in a tagged response as
an integer.
Review Comment:
interpret
##
src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java:
##
@@ -61,7 +61,7 @@ public VMSVersioningFTPEntryParser() {
* This constructor allows the creation of a VMSVersioningFTPEntryParser
object with something other than the default configuration.
*
* @param config The {@link FTPClientConfig configuration} object used to
configure this parser.
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Ditto
##
src/main/java/org/apache/commons/net/telnet/Telnet.java:
##
@@ -980,7 +980,7 @@ boolean stateIsDo(final int option) {
/**
* Looks for the state of the option.
*
- * @return returns true if a dont has been acknowledged
+ * @return returns true if a {@code dont} has been acknowledged
Review Comment:
DONT
##
src/main/java/org/apache/commons/net/telnet/Telnet.java:
##
@@ -633,7 +633,7 @@ final synchronized void requestDont(final int option)
throws IOException {
/**
* Looks for the state of the option.
*
- * @return returns true if a do has been reuqested
+ * @return returns true if a {@code do} has been requested.
Review Comment:
do => DO
##
src/main/java/org/apache/commons/net/telnet/Telnet.java:
##
@@ -969,7 +969,7 @@ void spyWrite(final int ch) {
/**
* Looks for the state of the option.
*
- * @return returns true if a do has been acknowledged
+ * @return returns true if a {@co
[jira] [Resolved] (IO-784) Add support for Appendable to HexDump util
[ https://issues.apache.org/jira/browse/IO-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-784. Fix Version/s: 2.12.0 Resolution: Fixed > Add support for Appendable to HexDump util > -- > > Key: IO-784 > URL: https://issues.apache.org/jira/browse/IO-784 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Affects Versions: 2.11.0 >Reporter: Fredrik Kjellberg >Priority: Major > Fix For: 2.12.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The HexDump utility currently only supports to send the output of the hex > dump to an OutputStream. This makes it cumbersome if you want to e.g. output > the dump to System.out. > The HexDump utility should support to send the output to an `Appendable` > making it possible to use e.g. `System.out` or `StringBuilder` as output > targets. > Created PR with a proposed fix: > [https://github.com/apache/commons-io/pull/418] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (IO-784) Add support for Appendable to HexDump util
[ https://issues.apache.org/jira/browse/IO-784?focusedWorklogId=840071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840071 ] ASF GitHub Bot logged work on IO-784: - Author: ASF GitHub Bot Created on: 18/Jan/23 19:58 Start Date: 18/Jan/23 19:58 Worklog Time Spent: 10m Work Description: garydgregory merged PR #418: URL: https://github.com/apache/commons-io/pull/418 Issue Time Tracking --- Worklog Id: (was: 840071) Time Spent: 1h 50m (was: 1h 40m) > Add support for Appendable to HexDump util > -- > > Key: IO-784 > URL: https://issues.apache.org/jira/browse/IO-784 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Affects Versions: 2.11.0 >Reporter: Fredrik Kjellberg >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > The HexDump utility currently only supports to send the output of the hex > dump to an OutputStream. This makes it cumbersome if you want to e.g. output > the dump to System.out. > The HexDump utility should support to send the output to an `Appendable` > making it possible to use e.g. `System.out` or `StringBuilder` as output > targets. > Created PR with a proposed fix: > [https://github.com/apache/commons-io/pull/418] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-io] garydgregory merged pull request #418: [IO-784] Add support for Appendable to HexDump util
garydgregory merged PR #418: URL: https://github.com/apache/commons-io/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CRYPTO-162) openSslCipher support engine
[
https://issues.apache.org/jira/browse/CRYPTO-162?focusedWorklogId=840064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840064
]
ASF GitHub Bot logged work on CRYPTO-162:
-
Author: ASF GitHub Bot
Created on: 18/Jan/23 19:46
Start Date: 18/Jan/23 19:46
Worklog Time Spent: 10m
Work Description: markwkern commented on PR #165:
URL: https://github.com/apache/commons-crypto/pull/165#issuecomment-1387678224
You could use the Intel rdrand engine in the unit test. It's always
available in OpenSSL for machines of the Ivy Bridge or later generation.
% openssl engine -v
(rdrand) Intel RDRAND engine
Issue Time Tracking
---
Worklog Id: (was: 840064)
Time Spent: 1h 50m (was: 1h 40m)
> openSslCipher support engine
>
>
> Key: CRYPTO-162
> URL: https://issues.apache.org/jira/browse/CRYPTO-162
> Project: Commons Crypto
> Issue Type: New Feature
> Components: Cipher
>Reporter: wenweijian
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The engine is the hardware or software implementation used for performing
> cryptographic operations.
>
> Assume we have a hardware device with a super fast implementation of AES. Now
> when we use AES encryption we can set the engine to that hardware device
> (instead of {{{}NULL{}}}), which means that the operations are now computed
> by the hardware device instead of the default OpenSSL software layer.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-crypto] markwkern commented on pull request #165: CRYPTO-162 openSslCipher support engine.
markwkern commented on PR #165: URL: https://github.com/apache/commons-crypto/pull/165#issuecomment-1387678224 You could use the Intel rdrand engine in the unit test. It's always available in OpenSSL for machines of the Ivy Bridge or later generation. % openssl engine -v (rdrand) Intel RDRAND engine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-785) FileUtils.deleteDirectory fails to delete directory on Azure AKS
[
https://issues.apache.org/jira/browse/IO-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678361#comment-17678361
]
Gary D. Gregory commented on IO-785:
Hello [~iloncar]
Please update to 2.11.0.
> FileUtils.deleteDirectory fails to delete directory on Azure AKS
> -
>
> Key: IO-785
> URL: https://issues.apache.org/jira/browse/IO-785
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.9.0
> Environment: Azure Files Container Storage Interface (CSI) driver in
> Azure Kubernetes Service (AKS)
> apiVersion: storage.k8s.io/v1
> kind: StorageClass
> metadata:
> annotations:
> kubectl.kubernetes.io/last-applied-configuration: |
>
> \{"apiVersion":"storage.k8s.io/v1","kind":"StorageClass","metadata":{"annotations":{},"name":"azure-aks-test-cluster-file-storage-class"},"mountOptions":["dir_mode=0777","file_mode=0777","uid=0","gid=0","mfsymlinks","cache=strict","actimeo=30"],"provisioner":"kubernetes.io/azure-file"}
> storageclass.kubernetes.io/is-default-class: "false"
> creationTimestamp: "2022-01-01T0-00:00:00Z"
> name: azure-aks-test-cluster-file-storage-class
> resourceVersion: "12768518"
> uid: bc6-invalid-8c
> mountOptions:
> - dir_mode=0777
> - file_mode=0777
> - uid=0
> - gid=0
> - mfsymlinks
> - cache=strict
> - actimeo=30
> provisioner: kubernetes.io/azure-file
> reclaimPolicy: Delete
> volumeBindingMode: Immediate
>Reporter: Ivica Loncar
>Priority: Major
>
> On Azure AKS file persistent volume
> (https://learn.microsoft.com/en-us/azure/aks/azure-files-csi) we've got
> following exception:
>
> org.apache.commons.io.IOExceptionList:
> work/bef4a1a575c54ac099816b6babf4bde9/job-3418
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:330)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1191)
> at
> com.xebialabs.xlrelease.remote.executor.k8s.KubeService.cleanWorkDir(KubeService.scala:107)
> at
> com.xebialabs.xlrelease.remote.executor.k8s.KubeJobExecutorService.cleanup(KubeJobExecutorService.scala:27)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor.$anonfun$handleEvent$4(JobRunnerActor.scala:219)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor.$anonfun$handleEvent$4$adapted(JobRunnerActor.scala:218)
> at scala.Option.foreach(Option.scala:437)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor.com$xebialabs$xlrelease$remote$runner$JobRunnerActor$$handleEvent(JobRunnerActor.scala:218)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor$$anonfun$receiveRecover$1.$anonfun$applyOrElse$2(JobRunnerActor.scala:45)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor$$anonfun$receiveRecover$1.$anonfun$applyOrElse$2$adapted(JobRunnerActor.scala:45)
> at scala.Option.foreach(Option.scala:437)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor$$anonfun$receiveRecover$1.applyOrElse(JobRunnerActor.scala:45)
> at
> scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:35)
> at akka.event.LoggingReceive.apply(LoggingReceive.scala:96)
> at akka.event.LoggingReceive.apply(LoggingReceive.scala:70)
> at
> akka.persistence.Eventsourced$$anon$2$$anonfun$1.applyOrElse(Eventsourced.scala:643)
> at akka.actor.Actor.aroundReceive(Actor.scala:537)
> at akka.actor.Actor.aroundReceive$(Actor.scala:535)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor.akka$persistence$Eventsourced$$super$aroundReceive(JobRunnerActor.scala:22)
> at
> akka.persistence.Eventsourced$$anon$3.stateReceive(Eventsourced.scala:771)
> at akka.persistence.Eventsourced.aroundReceive(Eventsourced.scala:245)
> at akka.persistence.Eventsourced.aroundReceive$(Eventsourced.scala:244)
> at
> com.xebialabs.xlrelease.remote.runner.JobRunnerActor.aroundReceive(JobRunnerActor.scala:22)
> at akka.actor.ActorCell.receiveMessage(ActorCell.scala:579)
> at akka.actor.ActorCell.invoke(ActorCell.scala:547)
> at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:270)
> at akka.dispatch.Mailbox.run(Mailbox.scala:231)
> at akka.dispatch.Mailbox.exec(Mailbox.scala:243)
> at java.base/java.util.concurrent.ForkJoinTask.doExec(Unknown Source)
> at
> java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown
> Source)
> at java.base/java.util.concurrent.ForkJoinPool.scan(Unknown Source)
> at java.base/java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
> at java.base/java.util.concurrent.ForkJoinWorkerThread.run(Unknown
> Source)
> Caused by: java.io.IOException: Cannot delete file:
> work/bef4a1a575c54ac099816b6babf4bd
[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1387593903 @sebbASF Have all your concerns been addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (VFS-683) Thread safety issue in VFSClassLoader - NullPointerException thrown
[
https://issues.apache.org/jira/browse/VFS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-683.
-
Fix Version/s: 2.10.0
Resolution: Fixed
> Thread safety issue in VFSClassLoader - NullPointerException thrown
> ---
>
> Key: VFS-683
> URL: https://issues.apache.org/jira/browse/VFS-683
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Daryl Odnert
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 2.10.0
>
> Attachments: Main.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In my application, I have two instances of the {{VFSClassLoader}}, each of
> which is being used in a distinct thread. Both {{VFSClassLoader}} instances
> refer to the same compressed file resource described by a {{FileObject}} that
> is passed to the class loader's constructor. Intermittently, the application
> throws an exception with the stack trace shown below. So, there seems to be
> either a race condition in the code or an undocumented assumption here. If it
> is unsupported for two {{VFSClassLoader}} instances to refer to the same
> resource (file), then that assumption should be documented. But if that is
> not the case, then there is a race condition bug in the implementation.
> {noformat}
> 43789 WARN {} c.a.e.u.PreferredPathClassLoader - While loading class
> org.apache.hive.jdbc.HiveDatabaseMetaData, rethrowing unexpected
> java.lang.NullPointerException: Inflater has been closed
> java.lang.NullPointerException: Inflater has been closed
> at java.util.zip.Inflater.ensureOpen(Inflater.java:389)
> at java.util.zip.Inflater.inflate(Inflater.java:257)
> at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> at
> org.apache.commons.vfs2.util.MonitorInputStream.read(MonitorInputStream.java:91)
> at org.apache.commons.vfs2.FileUtil.getContent(FileUtil.java:47)
> at org.apache.commons.vfs2.impl.Resource.getBytes(Resource.java:102)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSClassLoader.java:179)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:150)
> at
> com.atscale.engine.utils.PreferredPathClassLoader.findClass(PreferredPathClassLoader.scala:54)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-vfs] garydgregory merged pull request #367: [VFS-683] Class loader thread safety
garydgregory merged PR #367: URL: https://github.com/apache/commons-vfs/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] ivakegg commented on pull request #367: fixes #VFS-683: class loader thread safety
ivakegg commented on PR #367: URL: https://github.com/apache/commons-vfs/pull/367#issuecomment-1387115776 This is ready for a final review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-192) Add subtract method to Sum
[
https://issues.apache.org/jira/browse/NUMBERS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678192#comment-17678192
]
Gilles Sadowski commented on NUMBERS-192:
-
+1
> Add subtract method to Sum
> --
>
> Key: NUMBERS-192
> URL: https://issues.apache.org/jira/browse/NUMBERS-192
> Project: Commons Numbers
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.1
>Reporter: Alex Herbert
>Priority: Trivial
>
> The Sum class can be used to add and subtract many terms. Subtraction of
> individual terms is performed by negating the argument and using the {{add}}
> method:
> {code:java}
> Sum.of(1, -2, 3, -4, 5).add(-6).add(7)
> {code}
> However there is no subtract method for subtraction of another sum to
> complement the {{add(Sum)}} method. This prevents using the extended
> precision part of the Sum in subtraction.
> I suggest adding:
> {code:java}
> public Sum subtract(Sum other){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
