[jira] [Comment Edited] (MATH-1228) First Moment is not public
[
https://issues.apache.org/jira/browse/MATH-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275313#comment-15275313
]
Gilles Sadowski edited comment on MATH-1228 at 6/4/23 11:40 PM:
I've started a case against the whole {{(First|Second|Third|Fourth)Moment}}
hierarchy on the ["dev" ML|https://markmail.org/message/jc75ynqhen3q4rnp].
was (Author: erans):
I've started a case against the whole {{(First|Second|Third|Fourth)Moment}}
hierarchy on the "dev" ML.
> First Moment is not public
> --
>
> Key: MATH-1228
> URL: https://issues.apache.org/jira/browse/MATH-1228
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.5
>Reporter: Fabian Lange
>Priority: Major
> Fix For: 4.X
>
>
> Hi there,
> is there a specific reason FirstMoment is not public?
> I want to calculate a mean over a List, for that I want to loop over
> that list and invoke Mean.increment(listValue), however this is slower than
> it could be. Every increment call makes a check to incMoment.
> I could avoid that if I use a FirstMoment directly, but I cannot create an
> instance, because it is protected.
> Also this effectively means that the public constructor Mean(FirstMoment) is
> not usable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IO-438) IOUtils.closeQuietly Javadoc needs fixing
[ https://issues.apache.org/jira/browse/IO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729119#comment-17729119 ] Sebb commented on IO-438: - The Javadoc needs to be more specific as to when it is appropriate to use the method. The most important message is at https://github.com/apache/commons-io/blob/5e3a4f1c172479633cb681f36c857473dda14dd5/src/main/java/org/apache/commons/io/IOUtils.java#L527 This applies to all the closeQuietly descriptions. Maybe we could provide a full discussion in the first method, and reference that from subsequent methods. Also the examples (Closing all streams) at: https://github.com/apache/commons-io/blob/5e3a4f1c172479633cb681f36c857473dda14dd5/src/main/java/org/apache/commons/io/IOUtils.java#L493 and https://github.com/apache/commons-io/blob/5e3a4f1c172479633cb681f36c857473dda14dd5/src/main/java/org/apache/commons/io/IOUtils.java#L545 do not reflect best practice. These examples should follow the preceding code sample which closes the stream and handles errors. Or just delete them, as they don't add anything useful once corrected. > IOUtils.closeQuietly Javadoc needs fixing > - > > Key: IO-438 > URL: https://issues.apache.org/jira/browse/IO-438 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Priority: Major > > As mentioned in a comment on IO-388, there is a danger that closeQuietly is > used inappropriately. > Indeed the "Closing all streams:" examples in the Javadoc for various > closeQuietly methods are wrong. > The IOUtils.copy() methods don't close their input and output parameters. > It is arguably OK to ignore exceptions when closing the input, but it is a > bad idea to ignore exceptions when closing the output, as that could mean > that the output has not been fully written. > The Javadoc for these examples could be dropped, but I think it would be > better to fix it to show how it should be done properly. > There are a lot of copies of the bad example; I suggest we agree on a sample > replacement before updating them all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (LANG-1677) It should be possible to exclude fields in ReflectionDiffBuilder
[ https://issues.apache.org/jira/browse/LANG-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1677. --- Fix Version/s: 3.13.0 Resolution: Fixed PR merged to git master > It should be possible to exclude fields in ReflectionDiffBuilder > > > Key: LANG-1677 > URL: https://issues.apache.org/jira/browse/LANG-1677 > Project: Commons Lang > Issue Type: Wish > Components: lang.builder.* >Affects Versions: 3.12.0 >Reporter: Dennis Baerten >Priority: Major > Fix For: 3.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > When using ReflectionDiffBuilder to make a diff between two object it will be > default include all fields. As stated in the documentation static and > transient fields are excluded. > Using the transient modifier in combination with other frameworks ( such as > Hibernate ) also has a side affect that those fields are not persisted. > The use case I'm trying to solve it making a diff of an object that get's > updated and has a LastModificationDate and LastModificationUser and thus will > always be a field in the diff. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-lang] garydgregory commented on pull request #838: [LANG-1677] Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1575668547 https://issues.apache.org/jira/browse/LANG-1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory merged PR #838: URL: https://github.com/apache/commons-lang/pull/838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] aherbert merged pull request #44: Updated pom.xml
aherbert merged PR #44: URL: https://github.com/apache/commons-statistics/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
