[GitHub] [commons-net] haegar9766 commented on pull request #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets
haegar9766 commented on PR #182: URL: https://github.com/apache/commons-net/pull/182#issuecomment-1716977082 @garydgregory After fixing code style errors "mvn" could now build my branch without any errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] gbidsilva commented on pull request #347: [CSV-147] Error message optimization during faulty CSV record read
gbidsilva commented on PR #347: URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1716887748 > @gbidsilva Thank you for your updates. Please see my comments. Completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (BEANUTILS-563) Building from source release fails with a Maven error
Craig McClanahan created BEANUTILS-563: -- Summary: Building from source release fails with a Maven error Key: BEANUTILS-563 URL: https://issues.apache.org/jira/browse/BEANUTILS-563 Project: Commons BeanUtils Issue Type: Bug Components: Bean / Property Utils Affects Versions: 1.9.4 Reporter: Craig McClanahan I downloaded the Commons Beanutils 1.9.4 release from [https://dlcdn.apache.org//commons/beanutils/source/commons-beanutils-1.9.4-src.tar.gz] And attempted to build it following the instructions at [https://commons.apache.org/proper/commons-beanutils/building.html] But encountered the following errors from Maven: [*ERROR*] COMPILATION ERROR : [*INFO*] - [*ERROR*] Source option 6 is no longer supported. Use 7 or later. [*ERROR*] Target option 6 is no longer supported. Use 7 or later. [*INFO*] 2 errors [*INFO*] - My Environment: * Computer: MacBook Pro * OS: Ventura 13.5.2 * Java: 14.0.1 * Maven: 3.6.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323811667 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: @elharo I like that approach. Shouldn't be too big of a change either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
garydgregory commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323804505 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: > That's the String class method. Ah, yes of course. Thank you for pointing that out :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
garydgregory commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323804505 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: > That's the String class method. The Character class methods don't accept a locale. Looking at the source I don't think they delegate to String anywhere. The docs advise using String specifically to support Locale. But if we decided not to support Locale the the Character methods might work? Ah, yes of course. Thank you for pointing that out :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] elharo commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
elharo commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323778849 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: This is tricky. It's been a while since I needed this but I seem to recall that there is a canonical Unicode case mapping in Unicode Data somewhere that would fit here. I wouldn't use a Locale for this, implicitly or explicitly. I think what we need is whether the character has the Lu property, the Lc property, or neither. See https://en.wikipedia.org/wiki/Unicode_character_property Character.isUpperCase and Character.isLowerCase should be essentially this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IMAGING-316) Support the BigTIFF file format
[ https://issues.apache.org/jira/browse/IMAGING-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764433#comment-17764433 ] Gary Lucas commented on IMAGING-316: Submitted Pull Request 318 to the Commons Imaging project on github. This enhancement will allow the Imaging library to read BigTIFF format files. The ability to write BigTIFF files will be subject of a future Jira issue. > Support the BigTIFF file format > --- > > Key: IMAGING-316 > URL: https://issues.apache.org/jira/browse/IMAGING-316 > Project: Commons Imaging > Issue Type: New Feature >Affects Versions: 1.x >Reporter: Gary Lucas >Priority: Major > > Traditional TIFF files address file position in bytes using 32-bit integers. > This approach automatically limits the maximum size of a TIFF file to 4 GB. > The BigTIFF specification (formalized in 2011) uses 64-bit integers to > address file positions, and thus supports much larger files. I propose that > a future release of Commons Imaging would benefit from supporting BigTIFF. > The level of effort for this implementation may be large. > In terms of creating JUnit tests to support this effort, note that just > because a file uses the BigTIFF specification doesn't mean that the file has > to be super large. It should be possible to create BigTIFF test files that > are only a few kilobytes. Thus supporting BigTIFF does not necessarily mean > that massive files will need to be included in the Commons Imaging > distribution. > Finally, it is reasonable to ask if anyone would actually need images that > were so large that they couldn't fit within 4 GB. The short answer is that > some folks in the Geographic Information Systems (GIS) community do work with > images (or data sets) that large and, also, that some systems produce images > in BigTIFF format even when ordinary TIFF would suffice. > > P.S. It might be work investigating whether the existing Imaging library > actually supports the full 32-bit address space of a conventional TIFF. > Regrettably, Java doesn't support unsigned integer types. And it is > possible that a file address with the high bit set might be incorrectly > interpreted as a negative number. So I will be taking a look at the code to > make sure all file addresses are properly masked when they are handed over to > Java. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-imaging] gwlucastrig opened a new pull request, #318: Imaging-316: Add support for BigTIFF format
gwlucastrig opened a new pull request, #318: URL: https://github.com/apache/commons-imaging/pull/318 These changes add support for the BigTIFF format. They enable the Commons Imaging library to read TIFF files of size larger than supported by a 32-bit address space. A dedicated test case and a set of BigTIFF sample files are included. Please see the Commons Imaging JIRA tracker issue 316 at [https://issues.apache.org/jira/browse/IMAGING-316](https://issues.apache.org/jira/browse/IMAGING-316) for more detail. The ability to write BigTIFF files will be reserved for a future pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323743923 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: That's the String class method. The Character class methods don't accept a locale. Looking at the source I don't think they delegate to String anywhere. The docs advise using String specifically to support Locale. But if we decided not to support Locale the the Character methods might work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323743923 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: That's the String class method. The Character class methods don't accept a locale. Looking at the source I don't think they delegate to String anywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
garydgregory commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323697637 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: Yes they do. You pass the target locale to the [one arg method](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#toUpperCase-java.util.Locale-) otherwise the default locale is used when you call the no arg method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323663796 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: Per the docs, I believe the Character.toXXXCase methods don't use locale. So the question then is do we want to try and support Locale by using the String class methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323663796 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: Per the docs, I believe the Character.toXXXCase methods don't use locale. So the question then is do we want to try and support Locale? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
garydgregory commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323473428 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: Regarding handling conversion with the Turkish locales: https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/ ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: Regarding handling conversion with the Turkish locale: https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323351259 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: That's good to know. Im definitely not a unicode expert, so I'll defer to you on all of those points. Seems like using the JDK methods: `Character.isCase` and` Character.toCase` would work? Docs say they can handle unicode cases. I believe that will work and I can't think of any disadvantages or ill effects it would have on the ascii use case. Although I can manually come up with test cases, It would be nice if there were some real world code that used non-ascii identifiers, but can't seem to find any (other than examples of how one _might_ use them). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323351259 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: That's good to know. Im definitely not a unicode expert, so I'll defer to you on all of those points. Seems like using the SDK methods: `Character.isCase` and` Character.toCase` would work? Docs say they can handle unicode cases. I believe that will work and I can't think of any disadvantages or ill effects it would have on the ascii use case. Although I can manually come up with test cases, It would be nice if there were some real world code that used non-ascii identifiers, but can't seem to find any (other than examples of how one _might_ use them). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-809) MessageDigestCalculatingInputStream Builder Not Working
[ https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764302#comment-17764302 ] Gary D. Gregory commented on IO-809: Ah, well, that's painful. We can't change the method signature until the next major version. > MessageDigestCalculatingInputStream Builder Not Working > --- > > Key: IO-809 > URL: https://issues.apache.org/jira/browse/IO-809 > Project: Commons IO > Issue Type: Bug >Reporter: Jeremias Eppler >Priority: Major > Attachments: commons-io-issue.png > > > I am currently trying to use the MessageDigestCalculatingInputStream Builder. > However, the setters of the builder do not return the builder. > Meaning, this code does not work: > > ~~~java > MessageDigestCalculatingInputStream messageDigestInputStream = > MessageDigestCalculatingInputStream.builder() > .setInputStream(fileInputstream) > .setMessageDigest(digest) > .get(); > ~~~ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-text] elharo commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)
elharo commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323303834 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: ASCII != Latin. There are many upper case letters in French, Icelandic Turkish, etc. not handled by ASCII. I think the Unicod spec normally identifies each character as upper case, lower case, and something else for non-cased characters. Definitely Greek and I think Cyrillic also have case. I'm sure there are others. Also, ranges might not do what you expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-809) MessageDigestCalculatingInputStream Builder Not Working
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764287#comment-17764287
]
Jeremias Eppler commented on IO-809:
I would love to, but the problem is it does not compile (see screenshot in
Eclipse IDE) and code snippet:
!commons-io-issue.png!
Code:
~~~java
MessageDigestCalculatingInputStream messageDigestInputStream =
MessageDigestCalculatingInputStream
.builder()
.setInputStream(fileInputstream)
.setMessageDigest("SHA-512")
.get();
~~~
The issue is, the `MessageDigestCalculatingInputStream.setMessageDigest()`
methods (both accepting a String or a MessageDigest) return void rather than
the builder:
https://github.com/apache/commons-io/blob/631233639ac429e9cfe9d12e3470c84913f6c45b/src/main/java/org/apache/commons/io/input/MessageDigestCalculatingInputStream.java#L110
~~~java
public void setMessageDigest(final String algorithm) throws
NoSuchAlgorithmException {
this.messageDigest = MessageDigest.getInstance(algorithm);
}
~~~
I am happy to provide a pull-request for this issue. Just point me to the
contributor guide.
> MessageDigestCalculatingInputStream Builder Not Working
> ---
>
> Key: IO-809
> URL: https://issues.apache.org/jira/browse/IO-809
> Project: Commons IO
> Issue Type: Bug
>Reporter: Jeremias Eppler
>Priority: Major
> Attachments: commons-io-issue.png
>
>
> I am currently trying to use the MessageDigestCalculatingInputStream Builder.
> However, the setters of the builder do not return the builder.
> Meaning, this code does not work:
>
> ~~~java
> MessageDigestCalculatingInputStream messageDigestInputStream =
> MessageDigestCalculatingInputStream.builder()
> .setInputStream(fileInputstream)
> .setMessageDigest(digest)
> .get();
> ~~~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (IO-809) MessageDigestCalculatingInputStream Builder Not Working
[ https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremias Eppler updated IO-809: --- Attachment: commons-io-issue.png > MessageDigestCalculatingInputStream Builder Not Working > --- > > Key: IO-809 > URL: https://issues.apache.org/jira/browse/IO-809 > Project: Commons IO > Issue Type: Bug >Reporter: Jeremias Eppler >Priority: Major > Attachments: commons-io-issue.png > > > I am currently trying to use the MessageDigestCalculatingInputStream Builder. > However, the setters of the builder do not return the builder. > Meaning, this code does not work: > > ~~~java > MessageDigestCalculatingInputStream messageDigestInputStream = > MessageDigestCalculatingInputStream.builder() > .setInputStream(fileInputstream) > .setMessageDigest(digest) > .get(); > ~~~ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CSV-270) Different Expeciton type on malformed csv files
[
https://issues.apache.org/jira/browse/CSV-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764230#comment-17764230
]
Elliotte Rusty Harold commented on CSV-270:
---
I do think this is a good idea. I just think it's also one that needs a new
major version.
> Different Expeciton type on malformed csv files
> ---
>
> Key: CSV-270
> URL: https://issues.apache.org/jira/browse/CSV-270
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
>Affects Versions: 1.8
>Reporter: Thomas Kamps
>Priority: Minor
> Attachments: malformed_format.csv
>
>
> In our application we support to read CSV files with a custom definable
> format. The problem is now, that a suer could give a CSV file, which doies
> not match the defined pattern, the CSVParser throws an IOException. This
> exception type could also be throws, if the reading of the itself fails.
> Wed like to have a simple distiction beween IO errors and file content errors.
> We could parse the IOException's message, but those messages could change and
> we have to know about all kinds of content errors in advance.
>
> So my suggestion is to throw a specialied exception, when malformed content
> is detected during parsing. So we could distinguish between thsoe two kind of
> errors very easily:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader(soneFile, encoding),
> csvFormat
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> //File cannot be read for some reason
> }
> catch (MalformedCSVException e) {
> //CSV content is malformed compared to given CSVFormat
> }
> {code}
> Currently we wold have to get the message from the IOExcpetion and check its
> pattern to get the problem.
>
> Here is a simple example how to get an IOException that occurs, when the
> files content does not match the given CSVFormat:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader("path/to/malformed_format.csv",
> StandardCharsets.UTF_8),
> CSVFormat.DEFAULT
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> e.printStackTrace();
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CSV-270) Different Expeciton type on malformed csv files
[
https://issues.apache.org/jira/browse/CSV-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764188#comment-17764188
]
Buddhi De Silva commented on CSV-270:
-
[~elharo] : Should we park it in that case ?
> Different Expeciton type on malformed csv files
> ---
>
> Key: CSV-270
> URL: https://issues.apache.org/jira/browse/CSV-270
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
>Affects Versions: 1.8
>Reporter: Thomas Kamps
>Priority: Minor
> Attachments: malformed_format.csv
>
>
> In our application we support to read CSV files with a custom definable
> format. The problem is now, that a suer could give a CSV file, which doies
> not match the defined pattern, the CSVParser throws an IOException. This
> exception type could also be throws, if the reading of the itself fails.
> Wed like to have a simple distiction beween IO errors and file content errors.
> We could parse the IOException's message, but those messages could change and
> we have to know about all kinds of content errors in advance.
>
> So my suggestion is to throw a specialied exception, when malformed content
> is detected during parsing. So we could distinguish between thsoe two kind of
> errors very easily:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader(soneFile, encoding),
> csvFormat
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> //File cannot be read for some reason
> }
> catch (MalformedCSVException e) {
> //CSV content is malformed compared to given CSVFormat
> }
> {code}
> Currently we wold have to get the message from the IOExcpetion and check its
> pattern to get the problem.
>
> Here is a simple example how to get an IOException that occurs, when the
> files content does not match the given CSVFormat:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader("path/to/malformed_format.csv",
> StandardCharsets.UTF_8),
> CSVFormat.DEFAULT
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> e.printStackTrace();
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CSV-270) Different Expeciton type on malformed csv files
[
https://issues.apache.org/jira/browse/CSV-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764186#comment-17764186
]
Elliotte Rusty Harold commented on CSV-270:
---
MalformedCSVException should, semantically, be its own class, not a subclass of
IOException. However, this is an API and behavior breaking change that would
require a new major version.
> Different Expeciton type on malformed csv files
> ---
>
> Key: CSV-270
> URL: https://issues.apache.org/jira/browse/CSV-270
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
>Affects Versions: 1.8
>Reporter: Thomas Kamps
>Priority: Minor
> Attachments: malformed_format.csv
>
>
> In our application we support to read CSV files with a custom definable
> format. The problem is now, that a suer could give a CSV file, which doies
> not match the defined pattern, the CSVParser throws an IOException. This
> exception type could also be throws, if the reading of the itself fails.
> Wed like to have a simple distiction beween IO errors and file content errors.
> We could parse the IOException's message, but those messages could change and
> we have to know about all kinds of content errors in advance.
>
> So my suggestion is to throw a specialied exception, when malformed content
> is detected during parsing. So we could distinguish between thsoe two kind of
> errors very easily:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader(soneFile, encoding),
> csvFormat
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> //File cannot be read for some reason
> }
> catch (MalformedCSVException e) {
> //CSV content is malformed compared to given CSVFormat
> }
> {code}
> Currently we wold have to get the message from the IOExcpetion and check its
> pattern to get the problem.
>
> Here is a simple example how to get an IOException that occurs, when the
> files content does not match the given CSVFormat:
> {code:java}
> try (
> final CSVParser csvParser = new CSVParser(
> new FileReader("path/to/malformed_format.csv",
> StandardCharsets.UTF_8),
> CSVFormat.DEFAULT
> )
> ) {
> csvParser.getRecords();
> }
> catch (IOException e) {
> e.printStackTrace();
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-net] garydgregory commented on pull request #168: Add MockTcpServer, DaytimeTCPClient integration tests
garydgregory commented on PR #168: URL: https://github.com/apache/commons-net/pull/168#issuecomment-1715660795 -1 as the PR stands today: The PR does not test anything new that isn't already tested. Before and after this PR, the code coverage is the same at: 40% instructions / 31% branches. Run `mvn clean site -Pjacoco` then open `target/site/jacoco/index.html` Or am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] gbidsilva commented on pull request #347: [CSV-147] Error message optimization during faulty CSV record read
gbidsilva commented on PR #347: URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1715623466 @garydgregory : Anything pending from development side for this to be merged ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets
garydgregory commented on PR #182: URL: https://github.com/apache/commons-net/pull/182#issuecomment-1715566445 @haegar9766 Thank you for your update. Run `mvn` locally before your push to catch these build failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] haegar9766 commented on pull request #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets
haegar9766 commented on PR #182: URL: https://github.com/apache/commons-net/pull/182#issuecomment-1715162176 @garydgregory Sorry for the misunderstanding. I now also updated the existing test class "MVSFTPEntryParserTest". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
