[PR] Refactor code smells [commons-collections]
Keval-Gandevia opened a new pull request, #471: URL: https://github.com/apache/commons-collections/pull/471 **Implementation smell resolved.** | Implementation smell | Class name | Method name | | --- | --- | --- | |Extract method | CollectionUtils | get | | Decompose conditional | ListUtils | isEqualList | | Rename method / variable | SetUniqueList | set | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Test cases for iterators package, map package, and collection4 package [commons-collections]
Keval-Gandevia closed pull request #460: Test cases for iterators package, map package, and collection4 package URL: https://github.com/apache/commons-collections/pull/460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] refactor: required as per Assignment 2 - Task 2 - Set 1 [commons-jxpath]
garydgregory commented on PR #131: URL: https://github.com/apache/commons-jxpath/pull/131#issuecomment-2027898550 -1 I don't plan on reviewing school assignments. If you are looking to help this project you can look at the bug tracker here: https://issues.apache.org/jira/projects/JXPATH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] refactor: required as per Assignment 2 - Task 2 - Set 1 [commons-jxpath]
JinxLordMAW opened a new pull request, #131: URL: https://github.com/apache/commons-jxpath/pull/131 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] refactor: code smell assignment 2 - Part 2A [commons-jxpath]
JinxLordMAW closed pull request #130: refactor: code smell assignment 2 - Part 2A URL: https://github.com/apache/commons-jxpath/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-beanutils]
garydgregory merged PR #228: URL: https://github.com/apache/commons-beanutils/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-validator]
garydgregory merged PR #200: URL: https://github.com/apache/commons-validator/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-email]
garydgregory merged PR #232: URL: https://github.com/apache/commons-email/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-text]
garydgregory merged PR #522: URL: https://github.com/apache/commons-text/pull/522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons.bytebuddy.version from 1.14.12 to 1.14.13 [commons-text]
garydgregory merged PR #521: URL: https://github.com/apache/commons-text/pull/521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-text]
garydgregory merged PR #520: URL: https://github.com/apache/commons-text/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-text]
garydgregory commented on PR #520: URL: https://github.com/apache/commons-text/pull/520#issuecomment-2027748857 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons.bytebuddy.version from 1.14.12 to 1.14.13 [commons-text]
garydgregory commented on PR #521: URL: https://github.com/apache/commons-text/pull/521#issuecomment-2027748701 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-text]
garydgregory commented on PR #522: URL: https://github.com/apache/commons-text/pull/522#issuecomment-2027748156 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-bcel]
garydgregory merged PR #296: URL: https://github.com/apache/commons-bcel/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-rdf]
garydgregory merged PR #211: URL: https://github.com/apache/commons-rdf/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-fileupload]
garydgregory merged PR #293: URL: https://github.com/apache/commons-fileupload/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [commons-jxpath]
garydgregory merged PR #129: URL: https://github.com/apache/commons-jxpath/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-jxpath]
garydgregory merged PR #127: URL: https://github.com/apache/commons-jxpath/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for Java 16 Record feature [commons-bcel]
paulk-asert commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1544870277
##
src/test/java/org/apache/bcel/classfile/RecordTestCase.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.classfile;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.bcel.AbstractTestCase;
+import org.apache.bcel.util.SyntheticRepository;
+import org.apache.bcel.visitors.CountingVisitor;
+import org.junit.jupiter.api.Test;
+
+public class RecordTestCase extends AbstractTestCase {
+
+/**
+ * A record type, once compiled, should result in a class file that is
+ * marked such that we can determine from the access flags
+ * (through BCEL) that it is in fact a record.
+ *
+ * @throws IOException
+ * @throws ClassFormatException
+ */
+@Test
+public void testRecordClassSaysItIs() throws ClassNotFoundException,
ClassFormatException, IOException {
+final JavaClass clazz = new
ClassParser("src/test/resources/record/SimpleRecord.class").parse();
+assertTrue(clazz.isRecord(), "Expected SimpleEnum class to say it was
a record - but it didn't !");
Review Comment:
SimpleEnum -> SimpleRecord in test failure message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [IMAGING-319] Fix for lost first character on String [commons-imaging]
kinow commented on PR #359: URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2027695615 > @kinow Great news, thanks! > > Maybe we can use the image attached to https://issues.apache.org/jira/browse/IMAGING-319. I just asked the reporter. Excellent idea! That'd save us a lot of time, thanks for the initiative, @StefanOltmann :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IMAGING-319) updateExifMetadataLossless lost the first character of a String
[
https://issues.apache.org/jira/browse/IMAGING-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832282#comment-17832282
]
Stefan Oltmann commented on IMAGING-319:
Hi [~yangsicheng],
we have a fix for the problem, but we haven't it commited to the sources as we
lack a test image for the unit tests.
Is the image you attached to this ticket yours? Do you own the rights to it? If
so, would you allow us to add it to the projects sources (for unit tests) under
Apache 2 license?
@[~kinow] FYI
> updateExifMetadataLossless lost the first character of a String
> ---
>
> Key: IMAGING-319
> URL: https://issues.apache.org/jira/browse/IMAGING-319
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
>Affects Versions: 1.0-alpha2
>Reporter: Sicheng Yang
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Attachments: Screen Shot 2021-11-26 at 4.01.06 PM-1.png, Screen Shot
> 2021-11-26 at 4.01.21 PM-1.png, iPhone12-geotag.JPG
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I try to use TiffOutputSet to generate a new image. However, if a tag that
> contains String, the program may miss the first character of the String.
>
> import java.io.*;
> import org.apache.commons.imaging.ImageReadException;
> import org.apache.commons.imaging.ImageWriteException;
> import org.apache.commons.imaging.Imaging;
> import org.apache.commons.imaging.common.ImageMetadata;
> import org.apache.commons.imaging.formats.jpeg.JpegImageMetadata;
> import org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter;
> import org.apache.commons.imaging.formats.tiff.TiffImageMetadata;
> import org.apache.commons.imaging.formats.tiff.write.TiffOutputSet;
> public class LibraryTest {
> public static void main(String[] args) throws ImageReadException,
> IOException, ImageWriteException {
> File source = new File("./assets/iPhone12-geotag.JPG");
> File result = new
> File("./assets/results/editted-iPhone12-geotag.JPG");
> final ImageMetadata metadata = Imaging.getMetadata(source);
> final JpegImageMetadata jpegMetadata = (JpegImageMetadata) metadata;
> final TiffImageMetadata exif = jpegMetadata.getExif();
> TiffOutputSet outputSet = exif.getOutputSet();
> BufferedOutputStream bufferedOutputStream = new
> BufferedOutputStream(new FileOutputStream(result));
> new ExifRewriter().updateExifMetadataLossless(source,
> bufferedOutputStream, outputSet);
> }
> }
>
> This is the sample code.
> Tag value in original image
> !image-2021-11-26-16-01-58-645.png!
> Tag value in output image
> !image-2021-11-26-16-04-12-185.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [IMAGING-319] Fix for lost first character on String [commons-imaging]
StefanOltmann commented on PR #359: URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2027568778 @kinow Great news, thanks! The reporter of https://issues.apache.org/jira/browse/IMAGING-319 also attached a file to his ticket. It looks like a private iPhone image to me. We could ask him if he might contribute it to the project under Apache 2 license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-daemon]
garydgregory merged PR #154: URL: https://github.com/apache/commons-daemon/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-configuration]
garydgregory merged PR #395: URL: https://github.com/apache/commons-configuration/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-exec]
garydgregory merged PR #173: URL: https://github.com/apache/commons-exec/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-imaging]
garydgregory merged PR #381: URL: https://github.com/apache/commons-imaging/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-codec]
garydgregory merged PR #260: URL: https://github.com/apache/commons-codec/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-lang]
garydgregory merged PR #1192: URL: https://github.com/apache/commons-lang/pull/1192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CLI-329] Support "Deprecated" CLI Options [commons-cli]
garydgregory merged PR #252: URL: https://github.com/apache/commons-cli/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CLI-329] Support "Deprecated" CLI Options [commons-cli]
garydgregory commented on PR #252: URL: https://github.com/apache/commons-cli/pull/252#issuecomment-2027439274 @epugh We're all set then, merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-319] Fix for lost first character on String [commons-imaging]
kinow commented on PR #359: URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2027422945 Reviewed #366, I think that one can be merged. That pull request fixes a `@Disabled` test that does the roud-trip test for EXIF data. Once that's merged, and the test is re-enabled, there is a test image in #366 that should fail. I think here we have to: 1. Wait for #366 to be merged 2. Use the test image to confirm the test fails for that image 3. Check out this branch, re-run the test with the new image 4. Review the license for that image, and if we really cannot use it, then decide what to do (I would spend some time checking if a similar image can be crafted or found somewhere else) 5. Once the image is added, confirm the code here is being covered by the test+new image, and approve and merge! :rocket: Cheers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BCEL-372: Optimized code AttributeHTML [commons-bcel]
TYzzt closed pull request #294: BCEL-372: Optimized code AttributeHTML URL: https://github.com/apache/commons-bcel/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027412302 And tests passed after re-running the failed jobs on GitHub Actions :man_shrugging: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CLI-329: introduce to Options the tracking of deprecated short and long opts [commons-cli]
epugh commented on PR #251: URL: https://github.com/apache/commons-cli/pull/251#issuecomment-2027377978 Closing in favour of #252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CLI-329: introduce to Options the tracking of deprecated short and long opts [commons-cli]
epugh closed pull request #251: CLI-329: introduce to Options the tracking of deprecated short and long opts URL: https://github.com/apache/commons-cli/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CLI-329] Support "Deprecated" CLI Options [commons-cli]
epugh commented on PR #252: URL: https://github.com/apache/commons-cli/pull/252#issuecomment-2027377406 @garydgregory I am going to close my PR in favour of this one... What can I do to help move this along? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-851) FileSystemUtils no longer throws IllegalStateException
[ https://issues.apache.org/jira/browse/IO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832224#comment-17832224 ] Sebb commented on IO-851: - That's IllegalArgumentException, not IllegalStateException. I just did a search for IllegalStateException and it only appears in Javadoc. > FileSystemUtils no longer throws IllegalStateException > -- > > Key: IO-851 > URL: https://issues.apache.org/jira/browse/IO-851 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Priority: Minor > > The recent change to use NIO means that the code no longer throws > IllegalStateException, contrary to the Javadoc: > https://github.com/apache/commons-io/commit/59129bcf283ffa5a46d0872e173a4e037575c581 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027349014 Build errors are on macos (works on macos + java 8, fails for java 11). >Error: Java heap space I will spend some minutes checking if there's any Maven setting that we can use to fix the build, but I think that shouldn't be a blocker. I still want to test this part from @StefanOltmann 's comment before merging >Drop this [testfile.jpg](https://github.com/apache/commons-imaging/assets/9299303/2826b4ee-473a-45fb-b9fc-2168b9ae3fca) into src/test/resources/data/images/jpg to make the test fail. Then I believe a good course of action here would be to merge this to get the test passing (thanks Stefan!), and continue working on #359. If I recall correctly we may not be able to include the test file, so I will check whether I can find another one, find another way to test that, or check with legal/others other options (no need to worry about this for now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BCEL-372: Optimized code AttributeHTML [commons-bcel]
garydgregory commented on PR #294: URL: https://github.com/apache/commons-bcel/pull/294#issuecomment-2027314695 This is the lowest priority for me ATM since it is not a bug fix, it's just moving stuff around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BCEL-372: Optimized code AttributeHTML [commons-bcel]
TYzzt commented on PR #294: URL: https://github.com/apache/commons-bcel/pull/294#issuecomment-2027257996 Hi @garydgregory ,Can you review the code for me, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons.bytebuddy.version from 1.14.12 to 1.14.13 [commons-io]
garydgregory merged PR #605: URL: https://github.com/apache/commons-io/pull/605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-scxml]
garydgregory merged PR #210: URL: https://github.com/apache/commons-scxml/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-net]
garydgregory merged PR #236: URL: https://github.com/apache/commons-net/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.logging.log4j:log4j-core from 2.23.0 to 2.23.1 [commons-jcs]
garydgregory merged PR #229: URL: https://github.com/apache/commons-jcs/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-release-plugin]
garydgregory merged PR #253: URL: https://github.com/apache/commons-release-plugin/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.ow2.asm:asm-util from 9.6 to 9.7 [commons-pool]
garydgregory merged PR #294: URL: https://github.com/apache/commons-pool/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-csv]
garydgregory merged PR #409: URL: https://github.com/apache/commons-csv/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-collections]
garydgregory merged PR #470: URL: https://github.com/apache/commons-collections/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace
[
https://issues.apache.org/jira/browse/TEXT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved TEXT-175.
--
Fix Version/s: 1.11.1
Resolution: Fixed
> WordUtils.capitalizeFully(String) only splits by spaces, instead of any
> whitespace
> --
>
> Key: TEXT-175
> URL: https://issues.apache.org/jira/browse/TEXT-175
> Project: Commons Text
> Issue Type: Bug
>Affects Versions: 1.2, 1.8
>Reporter: David Lavati
>Priority: Minor
> Fix For: 1.11.1
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}Due to the performance improvements in TEXT-98, this no longer
> works as originally designed:{color}
> *
> {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a\tb\nc")}}{color}
> ** should return "A\t\B\nC", but returns "A\t\b\nc" instead
> * {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a b
> c")}}{color}
> ** still works as "A B C"
>
> A possible option while keeping the improvements would be to create a static
> collection of whitespace codepoints and
> * either include that into the set, instead of just the single whitespace,
> as done at
> [https://github.com/apache/commons-text/commit/fb6d5935451397c561bd52cf1d483975f83b2c7b#diff-9222b0893e00b43fd6519d95e395f9b3R892]
> * or if that touches too many things, call {{capitalize(String,char[])}}
> inside capitalizeFully with these chars as delimiters by default.
>
> Tested in 1.8
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [TEXT-175] Fix regression for determining whitespace in WordUtils [commons-text]
garydgregory merged PR #519: URL: https://github.com/apache/commons-text/pull/519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TEXT-175] Fix regression for determining whitespace in WordUtils [commons-text]
garydgregory commented on PR #519: URL: https://github.com/apache/commons-text/pull/519#issuecomment-2027175627 k, then this looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-crypto]
garydgregory merged PR #322: URL: https://github.com/apache/commons-crypto/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.moditect:moditect-maven-plugin from 1.2.0.Final to 1.2.1.Final [commons-parent]
garydgregory merged PR #390: URL: https://github.com/apache/commons-parent/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.11 to 2.8.0 [commons-parent]
garydgregory merged PR #389: URL: https://github.com/apache/commons-parent/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-pool]
garydgregory merged PR #293: URL: https://github.com/apache/commons-pool/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-851) FileSystemUtils no longer throws IllegalStateException
[ https://issues.apache.org/jira/browse/IO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832183#comment-17832183 ] Gary D. Gregory commented on IO-851: But it does: [https://github.com/apache/commons-io/commit/59129bcf283ffa5a46d0872e173a4e037575c581#diff-db759730c0e3c4c6cf1c3489f71f8ba5f68cd035a1164590e576c1632e3cfb11R175] > FileSystemUtils no longer throws IllegalStateException > -- > > Key: IO-851 > URL: https://issues.apache.org/jira/browse/IO-851 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Priority: Minor > > The recent change to use NIO means that the code no longer throws > IllegalStateException, contrary to the Javadoc: > https://github.com/apache/commons-io/commit/59129bcf283ffa5a46d0872e173a4e037575c581 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CONFIGURATION-843) Methods should not be empty
[ https://issues.apache.org/jira/browse/CONFIGURATION-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CONFIGURATION-843. --- Fix Version/s: 2.10.2 Resolution: Fixed > Methods should not be empty > --- > > Key: CONFIGURATION-843 > URL: https://issues.apache.org/jira/browse/CONFIGURATION-843 > Project: Commons Configuration > Issue Type: Task >Reporter: zhao tao >Priority: Minor > Fix For: 2.10.2 > > > An empty method is generally considered bad practice and can lead to > confusion, readability, and maintenance issues. Empty methods bring no > functionality and are misleading to others as they might think the method > implementation fulfills a specific and identified requirement. > There are several reasons for a method not to have a body: -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] CONFIGURATION-843: Methods should not be empty [commons-configuration]
garydgregory merged PR #393: URL: https://github.com/apache/commons-configuration/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-vfs]
garydgregory merged PR #510: URL: https://github.com/apache/commons-vfs/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027097242 - Replaced test code from `TiffOutputField` by a public getter/setter for the bytes data (the getter is a copy, like in other formats) - Updated tests to use `assertArrayEquals` from JUnit instead of custom test code - Updated a few lines to match the formatting of other classes - Added link to the issue/PR where the test was added (for traceability) - Added Javadocs to public methods changed I added a second commit so we can still revert/remove things if needed, but if there are no objections I think this should be ready to be merged as soon as CI is happy (will take a look later, gotta go :wave: :runner: ) p.s. will hold merging this until the current ongoing release is out, I think, to avoid causing any issues with the release progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-vfs]
garydgregory merged PR #509: URL: https://github.com/apache/commons-vfs/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-logging]
garydgregory merged PR #238: URL: https://github.com/apache/commons-logging/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-logging]
garydgregory merged PR #237: URL: https://github.com/apache/commons-logging/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-dbutils]
garydgregory merged PR #254: URL: https://github.com/apache/commons-dbutils/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-release-plugin]
garydgregory merged PR #255: URL: https://github.com/apache/commons-release-plugin/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-dbutils]
garydgregory merged PR #255: URL: https://github.com/apache/commons-dbutils/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-release-plugin]
garydgregory merged PR #256: URL: https://github.com/apache/commons-release-plugin/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-jcs]
garydgregory merged PR #231: URL: https://github.com/apache/commons-jcs/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-cli]
garydgregory merged PR #254: URL: https://github.com/apache/commons-cli/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-jcs]
garydgregory merged PR #230: URL: https://github.com/apache/commons-jcs/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-cli]
garydgregory merged PR #253: URL: https://github.com/apache/commons-cli/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-build-plugin]
garydgregory merged PR #238: URL: https://github.com/apache/commons-build-plugin/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-build-plugin]
garydgregory merged PR #239: URL: https://github.com/apache/commons-build-plugin/pull/239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-compress]
garydgregory merged PR #506: URL: https://github.com/apache/commons-compress/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-compress]
garydgregory merged PR #507: URL: https://github.com/apache/commons-compress/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-digester]
garydgregory merged PR #145: URL: https://github.com/apache/commons-digester/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-digester]
garydgregory merged PR #144: URL: https://github.com/apache/commons-digester/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-dbcp]
garydgregory merged PR #370: URL: https://github.com/apache/commons-dbcp/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-dbcp]
garydgregory merged PR #369: URL: https://github.com/apache/commons-dbcp/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-net]
garydgregory merged PR #234: URL: https://github.com/apache/commons-net/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-net]
garydgregory merged PR #235: URL: https://github.com/apache/commons-net/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TEXT-175] Fix regression for determining whitespace in WordUtils [commons-text]
kinow commented on PR #519: URL: https://github.com/apache/commons-text/pull/519#issuecomment-2027018030 > Do you have any thoughts on this method treating whitespace a certain way vs. what the rest of the class does, for example, abbreviate()? IOW, is it OK for this PR to only change this method in this manner? From what you described (haven't checked out the code) I'd agree it'd be best to keep things homogeneous. However, if it is a regression in a recent release, and users from previous releases want to have the old behavior, I think it'd be fair to either fix the regression, or fix the regression & offer another method with same/different behavior. Again, haven't checked out the code (old & new), so saying this based on the comment from JIRA: >Due to the performance improvements in [TEXT-98](https://issues.apache.org/jira/browse/TEXT-98), this no longer works as originally designed: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IO-851) FileSystemUtils no longer throws IllegalStateException
Sebb created IO-851: --- Summary: FileSystemUtils no longer throws IllegalStateException Key: IO-851 URL: https://issues.apache.org/jira/browse/IO-851 Project: Commons IO Issue Type: Bug Reporter: Sebb The recent change to use NIO means that the code no longer throws IllegalStateException, contrary to the Javadoc: https://github.com/apache/commons-io/commit/59129bcf283ffa5a46d0872e173a4e037575c581 -- This message was sent by Atlassian Jira (v8.20.10#820010)
