Re: [PR] Bump org.apache.commons:commons-parent from 69 to 70 [commons-net]
garydgregory commented on PR #252: URL: https://github.com/apache/commons-net/pull/252#issuecomment-2130707200 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-jexl]
garydgregory merged PR #259: URL: https://github.com/apache/commons-jexl/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (TEXT-234) Improve StrBuilder documentation for new line text
[
https://issues.apache.org/jira/browse/TEXT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849418#comment-17849418
]
Gary D. Gregory edited comment on TEXT-234 at 5/25/24 2:13 AM:
---
Hello [~tobiaskiecker]
All set?
was (Author: garydgregory):
Helo [~tobiaskiecker]
All set?
> Improve StrBuilder documentation for new line text
> --
>
> Key: TEXT-234
> URL: https://issues.apache.org/jira/browse/TEXT-234
> Project: Commons Text
> Issue Type: Improvement
>Affects Versions: 1.12.0
>Reporter: TobiasKiecker
>Priority: Minor
> Labels: documentation
>
> The method _setNewLineText_ in both _StrBuilder_ and _TextStringBuilder_ have
> ambiguous documentation. If someone were to extend the class and override
> _appendNewLine_ null would not be handled anymore.
> The docstring of s{_}etNewlineText{_} implies that THIS function does the
> handling, while in truth it is done in _appendNewLine._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [COLLECTIONS-854] renaming bloomfilter components and methods as per ticket [commons-collections]
garydgregory commented on PR #492: URL: https://github.com/apache/commons-collections/pull/492#issuecomment-2130666940 @Claudenw ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (TEXT-234) Improve StrBuilder documentation for new line text
[
https://issues.apache.org/jira/browse/TEXT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849418#comment-17849418
]
Gary D. Gregory commented on TEXT-234:
--
Helo [~tobiaskiecker]
All set?
> Improve StrBuilder documentation for new line text
> --
>
> Key: TEXT-234
> URL: https://issues.apache.org/jira/browse/TEXT-234
> Project: Commons Text
> Issue Type: Improvement
>Affects Versions: 1.12.0
>Reporter: TobiasKiecker
>Priority: Minor
> Labels: documentation
>
> The method _setNewLineText_ in both _StrBuilder_ and _TextStringBuilder_ have
> ambiguous documentation. If someone were to extend the class and override
> _appendNewLine_ null would not be handled anymore.
> The docstring of s{_}etNewlineText{_} implies that THIS function does the
> handling, while in truth it is done in _appendNewLine._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [TEXT-234] Improve TextStringBuilder documentation for new line text [commons-text]
garydgregory merged PR #547: URL: https://github.com/apache/commons-text/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-validator]
garydgregory merged PR #227: URL: https://github.com/apache/commons-validator/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-validator]
garydgregory merged PR #226: URL: https://github.com/apache/commons-validator/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-beanutils]
garydgregory merged PR #251: URL: https://github.com/apache/commons-beanutils/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-beanutils]
garydgregory merged PR #250: URL: https://github.com/apache/commons-beanutils/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-text]
garydgregory merged PR #551: URL: https://github.com/apache/commons-text/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-text]
garydgregory merged PR #550: URL: https://github.com/apache/commons-text/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-email]
garydgregory merged PR #257: URL: https://github.com/apache/commons-email/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-email]
garydgregory merged PR #258: URL: https://github.com/apache/commons-email/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [commons-email]
garydgregory merged PR #256: URL: https://github.com/apache/commons-email/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-rdf]
garydgregory merged PR #230: URL: https://github.com/apache/commons-rdf/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-rdf]
garydgregory merged PR #231: URL: https://github.com/apache/commons-rdf/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-bcel]
garydgregory merged PR #320: URL: https://github.com/apache/commons-bcel/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-bcel]
garydgregory merged PR #319: URL: https://github.com/apache/commons-bcel/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-jxpath]
garydgregory merged PR #152: URL: https://github.com/apache/commons-jxpath/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-jxpath]
garydgregory merged PR #151: URL: https://github.com/apache/commons-jxpath/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-fileupload]
garydgregory merged PR #316: URL: https://github.com/apache/commons-fileupload/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-fileupload]
garydgregory merged PR #317: URL: https://github.com/apache/commons-fileupload/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-imaging]
garydgregory merged PR #402: URL: https://github.com/apache/commons-imaging/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-imaging]
garydgregory merged PR #403: URL: https://github.com/apache/commons-imaging/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-exec]
garydgregory merged PR #193: URL: https://github.com/apache/commons-exec/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-exec]
garydgregory merged PR #192: URL: https://github.com/apache/commons-exec/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-configuration]
garydgregory merged PR #428: URL: https://github.com/apache/commons-configuration/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-configuration]
garydgregory merged PR #427: URL: https://github.com/apache/commons-configuration/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-daemon]
garydgregory merged PR #175: URL: https://github.com/apache/commons-daemon/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-daemon]
garydgregory merged PR #174: URL: https://github.com/apache/commons-daemon/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-codec]
garydgregory merged PR #282: URL: https://github.com/apache/commons-codec/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-lang]
garydgregory merged PR #1226: URL: https://github.com/apache/commons-lang/pull/1226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-lang]
garydgregory merged PR #1225: URL: https://github.com/apache/commons-lang/pull/1225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-codec]
garydgregory merged PR #283: URL: https://github.com/apache/commons-codec/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-collections]
garydgregory merged PR #496: URL: https://github.com/apache/commons-collections/pull/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-csv]
garydgregory merged PR #432: URL: https://github.com/apache/commons-csv/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-csv]
garydgregory merged PR #431: URL: https://github.com/apache/commons-csv/pull/431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-pool]
garydgregory merged PR #315: URL: https://github.com/apache/commons-pool/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-pool]
garydgregory merged PR #316: URL: https://github.com/apache/commons-pool/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (JEXL-422) Add strict equality (===) and inequality (!==) operators
[ https://issues.apache.org/jira/browse/JEXL-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-422. Resolution: Fixed [Commited|https://github.com/apache/commons-jexl/commit/b640ba6820eb07ffc23043f118a3497f64339df5] > Add strict equality (===) and inequality (!==) operators > > > Key: JEXL-422 > URL: https://issues.apache.org/jira/browse/JEXL-422 > Project: Commons JEXL > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Henri Biestro >Assignee: Henri Biestro >Priority: Minor > Fix For: 3.4 > > > As in Javascript, === is a comparison operator that checks the equality of > two values without performing any type conversion. This means that if the > values being compared have different data types, === will return false. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JEXL-423) Add support for instanceof / !instanceof
[
https://issues.apache.org/jira/browse/JEXL-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro resolved JEXL-423.
Resolution: Fixed
[Commited|https://github.com/apache/commons-jexl/commit/b640ba6820eb07ffc23043f118a3497f64339df5]
> Add support for instanceof / !instanceof
>
>
> Key: JEXL-423
> URL: https://issues.apache.org/jira/browse/JEXL-423
> Project: Commons JEXL
> Issue Type: New Feature
>Affects Versions: 3.3
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.4
>
>
> The *instanceof* operator allows to check whether an object belongs to a
> certain class.
> It is using Class.isInstance to perform the check. As a convenience, {{
> !instanceof }} is supported as well avoiding parenthesis as in:
> {code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
> y){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (JEXL-396) Add explicit Java module descriptor
[ https://issues.apache.org/jira/browse/JEXL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-396. Resolution: Fixed > Add explicit Java module descriptor > --- > > Key: JEXL-396 > URL: https://issues.apache.org/jira/browse/JEXL-396 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.3 >Reporter: Andres Almiray >Assignee: Henri Biestro >Priority: Major > Fix For: 3.3.1 > > > Follow up from a > [topic|https://lists.apache.org/thread/kxcwqyx026rhhx4v8q8bkbljj7lw8c32] > started at the mailing list. > Henri suggested using the ModiTect plugin guarded by a profile with JDK > activation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JEXL-235) Verify JexlScriptEngineFactory.{getLanguageVersion,getEngineVersion} before release
[
https://issues.apache.org/jira/browse/JEXL-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849306#comment-17849306
]
Henri Biestro commented on JEXL-235:
Checked [3.4|
https://github.com/apache/commons-jexl/commit/b640ba6820eb07ffc23043f118a3497f64339df5].
> Verify JexlScriptEngineFactory.{getLanguageVersion,getEngineVersion} before
> release
> ---
>
> Key: JEXL-235
> URL: https://issues.apache.org/jira/browse/JEXL-235
> Project: Commons JEXL
> Issue Type: Task
>Affects Versions: 3.2
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Major
> Fix For: Later
>
>
> JexlScriptEngineFactory.getLanguageVersion and
> JexlScriptEngineFactory.getEngine version should reflect the syntax version
> and the engine version respectively.
> As a rule, any new operator or syntax should bump the language version, any
> release should update the engine version that should match the jar version.
> (see JEXL-227 for discussion on the issue).
> This task must be checked for each version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JEXL-397) Dynamic proxy should not require specific permission
[
https://issues.apache.org/jira/browse/JEXL-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated JEXL-397:
---
Fix Version/s: 3.3.1
(was: 3.4)
> Dynamic proxy should not require specific permission
>
>
> Key: JEXL-397
> URL: https://issues.apache.org/jira/browse/JEXL-397
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.3
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.3.1
>
>
> With the default restricted permissions, dynamic proxies can not be
> introspected since they extend java.lang.reflect.Proxy whose package is
> denied.
> A workaround is to explicitly allow them as in:
> {code:java}
> JexlPermissions p = new JexlPermissions.Delegate(JexlPermissions.RESTRICTED) {
> @Override public boolean allow(Class clazz) {
> return Proxy.isProxyClass(clazz) || super.allow(clazz);
> }
> };
> {code}
> This workaround should not be necessary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JEXL-396) Add explicit Java module descriptor
[ https://issues.apache.org/jira/browse/JEXL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-396: --- Fix Version/s: 3.3.1 (was: 3.4) > Add explicit Java module descriptor > --- > > Key: JEXL-396 > URL: https://issues.apache.org/jira/browse/JEXL-396 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.3 >Reporter: Andres Almiray >Assignee: Henri Biestro >Priority: Major > Fix For: 3.3.1 > > > Follow up from a > [topic|https://lists.apache.org/thread/kxcwqyx026rhhx4v8q8bkbljj7lw8c32] > started at the mailing list. > Henri suggested using the ModiTect plugin guarded by a profile with JDK > activation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-396) Add explicit Java module descriptor
[ https://issues.apache.org/jira/browse/JEXL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-396: --- Fix Version/s: 3.4 > Add explicit Java module descriptor > --- > > Key: JEXL-396 > URL: https://issues.apache.org/jira/browse/JEXL-396 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.3 >Reporter: Andres Almiray >Assignee: Henri Biestro >Priority: Major > Fix For: 3.4 > > > Follow up from a > [topic|https://lists.apache.org/thread/kxcwqyx026rhhx4v8q8bkbljj7lw8c32] > started at the mailing list. > Henri suggested using the ModiTect plugin guarded by a profile with JDK > activation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-423) Add support for instanceof / !instanceof
[
https://issues.apache.org/jira/browse/JEXL-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated JEXL-423:
---
Description:
The *instanceof* operator allows to check whether an object belongs to a
certain class.
It is using Class.isInstance to perform the check. As a convenience, {{
!instanceof }} is supported as well avoiding parenthesis as in:
{code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
y){code}
was:
The {code:java} instanceof {code}
operator allows to check whether an object belongs to a certain class.
It is using Class.isInstance to perform the check. As a convenience, {{
!instanceof }} is supported as well avoiding parenthesis as in:
{code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
y){code}
> Add support for instanceof / !instanceof
>
>
> Key: JEXL-423
> URL: https://issues.apache.org/jira/browse/JEXL-423
> Project: Commons JEXL
> Issue Type: New Feature
>Affects Versions: 3.3
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.3.1
>
>
> The *instanceof* operator allows to check whether an object belongs to a
> certain class.
> It is using Class.isInstance to perform the check. As a convenience, {{
> !instanceof }} is supported as well avoiding parenthesis as in:
> {code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
> y){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JEXL-423) Add support for instanceof / !instanceof
[
https://issues.apache.org/jira/browse/JEXL-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated JEXL-423:
---
Description:
The {code:java} instanceof {code}
operator allows to check whether an object belongs to a certain class.
It is using Class.isInstance to perform the check. As a convenience, {{
!instanceof }} is supported as well avoiding parenthesis as in:
{code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
y){code}
was:
The {{instanceof}} operator allows to check whether an object belongs to a
certain class.
It is using Class.isInstance to perform the check. As a convenience,
{{!instanceof}} is supported as well avoiding parenthesis as in:
{{x !instanceof y}} is equivalent to {{!(x instanceof y)}}
> Add support for instanceof / !instanceof
>
>
> Key: JEXL-423
> URL: https://issues.apache.org/jira/browse/JEXL-423
> Project: Commons JEXL
> Issue Type: New Feature
>Affects Versions: 3.3
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.3.1
>
>
> The {code:java} instanceof {code}
> operator allows to check whether an object belongs to a certain class.
> It is using Class.isInstance to perform the check. As a convenience, {{
> !instanceof }} is supported as well avoiding parenthesis as in:
> {code:java}x !instanceof y{code} is equivalent to {code:java} !(x instanceof
> y){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JEXL-423) Add support for instanceof / !instanceof
Henri Biestro created JEXL-423:
--
Summary: Add support for instanceof / !instanceof
Key: JEXL-423
URL: https://issues.apache.org/jira/browse/JEXL-423
Project: Commons JEXL
Issue Type: New Feature
Affects Versions: 3.3
Reporter: Henri Biestro
Assignee: Henri Biestro
Fix For: 3.3.1
The {{instanceof}} operator allows to check whether an object belongs to a
certain class.
It is using Class.isInstance to perform the check. As a convenience,
{{!instanceof}} is supported as well avoiding parenthesis as in:
{{x !instanceof y}} is equivalent to {{!(x instanceof y)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JEXL-422) Add strict equality (===) and inequality (!==) operators
Henri Biestro created JEXL-422: -- Summary: Add strict equality (===) and inequality (!==) operators Key: JEXL-422 URL: https://issues.apache.org/jira/browse/JEXL-422 Project: Commons JEXL Issue Type: New Feature Affects Versions: 3.3 Reporter: Henri Biestro Assignee: Henri Biestro Fix For: 3.3.1 As in Javascript, === is a comparison operator that checks the equality of two values without performing any type conversion. This means that if the values being compared have different data types, === will return false. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]
garydgregory commented on PR #232: URL: https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129429158 @doublep Do you want to update the Javadoc as part of this PR or a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-parent]
garydgregory merged PR #420: URL: https://github.com/apache/commons-parent/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-bsf]
garydgregory merged PR #148: URL: https://github.com/apache/commons-bsf/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-skin]
garydgregory merged PR #135: URL: https://github.com/apache/commons-skin/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/checkout from 4.1.5 to 4.1.6 [commons-crypto]
garydgregory merged PR #340: URL: https://github.com/apache/commons-crypto/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.3.1 to 4.4.1 [commons-crypto]
garydgregory merged PR #342: URL: https://github.com/apache/commons-crypto/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.4 to 3.25.6 [commons-crypto]
garydgregory merged PR #343: URL: https://github.com/apache/commons-crypto/pull/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Code Base Improvement [commons-vfs]
JohnKimaiyo closed pull request #539: Code Base Improvement URL: https://github.com/apache/commons-vfs/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Code Base Improvement [commons-vfs]
JohnKimaiyo commented on PR #539: URL: https://github.com/apache/commons-vfs/pull/539#issuecomment-2129286790 To improve the given code, I will focus on enhancing readability, ensuring better consistency, and making use of modern Java features where applicable. Here are the changes made: Consistent and clean formatting: Ensuring the code is neatly formatted and consistently indented. Enhanced readability: Adding appropriate JavaDoc comments where necessary and improving the clarity of existing comments. Utilize modern Java features: Using List.of for creating an immutable list of capabilities, which is more concise and modern than using Arrays.asList and Collections.unmodifiableCollection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Code Base Improvement [commons-vfs]
JohnKimaiyo opened a new pull request, #539: URL: https://github.com/apache/commons-vfs/pull/539 To improve the given code, I will focus on enhancing readability, ensuring better consistency, and making use of modern Java features where applicable. Here are the changes made: Consistent and clean formatting: Ensuring the code is neatly formatted and consistently indented. Enhanced readability: Adding appropriate JavaDoc comments where necessary and improving the clarity of existing comments. Utilize modern Java features: Using List.of for creating an immutable list of capabilities, which is more concise and modern than using Arrays.asList and Collections.unmodifiableCollection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-vfs]
garydgregory merged PR #537: URL: https://github.com/apache/commons-vfs/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-vfs]
garydgregory merged PR #538: URL: https://github.com/apache/commons-vfs/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-logging]
garydgregory merged PR #261: URL: https://github.com/apache/commons-logging/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-logging]
garydgregory merged PR #260: URL: https://github.com/apache/commons-logging/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-dbutils]
garydgregory merged PR #274: URL: https://github.com/apache/commons-dbutils/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-dbutils]
garydgregory merged PR #273: URL: https://github.com/apache/commons-dbutils/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-release-plugin]
garydgregory merged PR #280: URL: https://github.com/apache/commons-release-plugin/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-release-plugin]
garydgregory merged PR #279: URL: https://github.com/apache/commons-release-plugin/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-cli]
garydgregory merged PR #279: URL: https://github.com/apache/commons-cli/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-cli]
garydgregory merged PR #278: URL: https://github.com/apache/commons-cli/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-jcs]
garydgregory merged PR #251: URL: https://github.com/apache/commons-jcs/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.3.1 to 4.4.1 [commons-jcs]
garydgregory merged PR #250: URL: https://github.com/apache/commons-jcs/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-build-plugin]
garydgregory merged PR #265: URL: https://github.com/apache/commons-build-plugin/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-build-plugin]
garydgregory merged PR #266: URL: https://github.com/apache/commons-build-plugin/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-digester]
garydgregory merged PR #167: URL: https://github.com/apache/commons-digester/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-digester]
garydgregory merged PR #166: URL: https://github.com/apache/commons-digester/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-compress]
garydgregory merged PR #534: URL: https://github.com/apache/commons-compress/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-compress]
garydgregory merged PR #535: URL: https://github.com/apache/commons-compress/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-dbcp]
garydgregory merged PR #393: URL: https://github.com/apache/commons-dbcp/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-dbcp]
garydgregory merged PR #392: URL: https://github.com/apache/commons-dbcp/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.5 to 3.25.6 [commons-net]
garydgregory merged PR #257: URL: https://github.com/apache/commons-net/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 4.4.0 to 4.4.1 [commons-net]
garydgregory merged PR #256: URL: https://github.com/apache/commons-net/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-808) FileUtils.moveFile, copyFile and others can throw undocumened IllegalArgumentException
[
https://issues.apache.org/jira/browse/IO-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849258#comment-17849258
]
Elliotte Rusty Harold commented on IO-808:
--
A commons library is not the place to litigate language design questions. Nor
is it a Kotlin library, It's a Java one, so I don't really see what the point
of the stack overflow thread is.
For good developer experience, it's essential that libraries follow the design,
idioms, and patterns of the language they're written for, in this case Java.
Breaking with established and deliberate Java practice on anything — not just
exceptions, but object construction, multithreading, access protection, package
naming, and a hundred other things — is a fatal and all too common flaw among
library maintainers who think they know better than the developers who designed
the language. Maybe they do, but it doesn't matter. Moving away from what
developers have learned to expect in a language leads directly to bugs and
developer pain.
Java libraries either use the Java language and its standard libraries,
including IOException and IllegalArgumentException, the way they were designed
to be used, or the library becomes hard to use and bug prone.
On exceptions in particular, see Section 10 of Effective Java, 3rd edition,
particularly Item 72: Favor the use of standard exceptions.
> FileUtils.moveFile, copyFile and others can throw undocumened
> IllegalArgumentException
> --
>
> Key: IO-808
> URL: https://issues.apache.org/jira/browse/IO-808
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.12.0
> Environment: Windows 10
>Reporter: Phil D
>Priority: Major
> Attachments: MakyAckyBreaky.java, TestMoveFileIAE.java
>
>
> Several of the functions in FileUtils are throwing undocumented
> IllegalArgumentException such as moveFile, copyFile and other locations.
> If the desire is to maintain backwards compatibility with the 1.4 branch for
> these functions, then the 2.12 (and 2.13) versions are throwing
> IllegalArgumentException in cases where 1.4 is not. In fact, it seems like
> 1.4 was coded to specifically avoid IllegalArgumentException and throws
> IOExceptions instead.
> There are several different cases where this is possible. In the most basic,
> I've attached TestMoveFileIAE, where this can be reproduced by simple running:
> {code:bash}
> mkdir one
> java -cp TestMoveFileIAE one two
> Exception in thread "main" java.lang.IllegalArgumentException: Parameter
> 'srcFile' is not a file: one
> at org.apache.commons.io.FileUtils.requireFile(FileUtils.java:2824)
> at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:2395)
> at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:2374)
> at TestMoveFileIAE.main(TestMoveFileIAE.java:13)
> {code}
> In a less likely scenario (which is how I found this issue because this
> happened on a production system); If the srcFile is removed at a certain
> point during moveFile() execution then IllegalArgumentException is throws:
> https://github.com/apache/commons-io/blob/master/src/main/java/org/apache/commons/io/FileUtils.java#L2392
> {code:java}
> 2392public static void moveFile(final File srcFile, final File destFile,
> final CopyOption... copyOptions) throws IOException {
> 2393validateMoveParameters(srcFile, destFile); // checks srcFile.exists()
> /// srcFile deleted here!!!
> 2394requireFile(srcFile, "srcFile"); // checks srcFile.isFile()
> and throws IAE
> 2395requireAbsent(destFile, "destFile");
> /// srcFile could also be deleted here
> 2396... // renameTo or copyFile() which also calls requireCopyFile() and
> requireFile()
> {code}
> This pattern of calling validateMoveParameters() and requireFile() will throw
> IllegalArgumentException every when the srcFile is removed between between
> validateMoveParameters() and requireFile() or requireFileCopy() and
> requireFile()
> Preferably, it would be best if the 2.x versions of FileUtils were backwards
> compatible with 1.x and IllegalArgumentException would not be thrown, but
> IOException (or one of its derivatives) would be. IAE is an unchecked
> exception and can cause unexpected issues.
> I would also suggest that unit tests be created to ensure that these
> functions behave as expected in error conditions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]
doublep commented on PR #232: URL: https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129000279 I'd say keep all four `getReadMethod()` and `getWriteMethod()` overloads public. As these method names are very common, searching in publicly available code doesn't yield useful results (too many unrelated hits), but suppose someone somewhere has a valid usecase to access one of these methods. (I can't think of one myself, but I don't rule out the possibility that there might be.) If you now lower the visibility, you will break someone's code for no particularly good reason, forcing them to look for workarounds. E.g. subclassing, making the methods public and then explicitly downcasting to the created class when using from "outside". Basically, a lot of hassle for virtually nothing. It's not like `PropertyUtilsBean` is a high-level class where having a nice compact interface is a lot of value. So, I'd leave them all `public`, but add a "disclaimer" in the documentation that these methods are lower-level than the rest (e.g. `get*Property()`) and should generally not be needed outside of some special usecases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (CLI-321) Add and use a Converter interface and implementations without using BeanUtils
[ https://issues.apache.org/jira/browse/CLI-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-321: -- Description: The current TypeHandler implementation notes indicate that the BeanUtils.Converters should be used to create instances of the various types. This issue is to complete the implementation of TypeHandler so that it does NOT use the BeanUtils.Converters. (was: The current TypeHandler implementation notes indicate that the BeanUtils.Converters should be used to create instances of the various types. This issue is to complete the implementation of TypeHandler so that it uses the BeanUtils.Converters.) > Add and use a Converter interface and implementations without using BeanUtils > -- > > Key: CLI-321 > URL: https://issues.apache.org/jira/browse/CLI-321 > Project: Commons CLI > Issue Type: Improvement > Components: Parser >Affects Versions: 1.6.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 1.7.0 > > > The current TypeHandler implementation notes indicate that the > BeanUtils.Converters should be used to create instances of the various types. > This issue is to complete the implementation of TypeHandler so that it does > NOT use the BeanUtils.Converters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CLI-321) Add and use a Converter interface and implementations without using BeanUtils
[ https://issues.apache.org/jira/browse/CLI-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved CLI-321. --- Fix Version/s: 1.7.0 (was: 1.8.1) Resolution: Fixed Fixed with pull request #216 > Add and use a Converter interface and implementations without using BeanUtils > -- > > Key: CLI-321 > URL: https://issues.apache.org/jira/browse/CLI-321 > Project: Commons CLI > Issue Type: Improvement > Components: Parser >Affects Versions: 1.6.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 1.7.0 > > > The current TypeHandler implementation notes indicate that the > BeanUtils.Converters should be used to create instances of the various types. > This issue is to complete the implementation of TypeHandler so that it uses > the BeanUtils.Converters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CLI-321) Add and use a Converter interface and implementations without using BeanUtils
[ https://issues.apache.org/jira/browse/CLI-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849190#comment-17849190 ] Claude Warren commented on CLI-321: --- This should have been closed in 1.7 > Add and use a Converter interface and implementations without using BeanUtils > -- > > Key: CLI-321 > URL: https://issues.apache.org/jira/browse/CLI-321 > Project: Commons CLI > Issue Type: Improvement > Components: Parser >Affects Versions: 1.6.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 1.8.1 > > > The current TypeHandler implementation notes indicate that the > BeanUtils.Converters should be used to create instances of the various types. > This issue is to complete the implementation of TypeHandler so that it uses > the BeanUtils.Converters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CLI-322) Allow minus for kebab-case options
[
https://issues.apache.org/jira/browse/CLI-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren resolved CLI-322.
---
Fix Version/s: 1.8.0
(was: 1.8.1)
Resolution: Fixed
Resolved by pull request #217
> Allow minus for kebab-case options
> --
>
> Key: CLI-322
> URL: https://issues.apache.org/jira/browse/CLI-322
> Project: Commons CLI
> Issue Type: New Feature
> Components: Parser
>Affects Versions: 1.6.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
> Fix For: 1.8.0
>
>
> Currently minus (“-“) is not allowed in option names,
> which makes common long options in kebab-case
> (like {{--is-not-allowed}}) impossible.
> This change is to allow it inside an option name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CLI-322) Allow minus for kebab-case options
[
https://issues.apache.org/jira/browse/CLI-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849187#comment-17849187
]
Claude Warren commented on CLI-322:
---
I think this should have been closed in 1.7.0 pull #217 resolved the issue.
> Allow minus for kebab-case options
> --
>
> Key: CLI-322
> URL: https://issues.apache.org/jira/browse/CLI-322
> Project: Commons CLI
> Issue Type: New Feature
> Components: Parser
>Affects Versions: 1.6.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
> Fix For: 1.8.1
>
>
> Currently minus (“-“) is not allowed in option names,
> which makes common long options in kebab-case
> (like {{--is-not-allowed}}) impossible.
> This change is to allow it inside an option name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
