[jira] [Commented] (NET-731) FTPSClient no longer supports fileTransferMode (eg DEFLATE)
[
https://issues.apache.org/jira/browse/NET-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865717#comment-17865717
]
Gary D. Gregory commented on NET-731:
-
Hello [~fanningpj]
Thank you for your update.
Do you have a reproducible test case?
The best path would be a failing unit test as a PR on GitHub.
> FTPSClient no longer supports fileTransferMode (eg DEFLATE)
> ---
>
> Key: NET-731
> URL: https://issues.apache.org/jira/browse/NET-731
> Project: Commons Net
> Issue Type: Task
> Components: FTP
>Reporter: PJ Fanning
>Priority: Major
>
> The new openDataSecureConnection method in FTPSClient does not support
> fileTransferMode (eg DEFLATE).
> [https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9[]
>
> |https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9]
>
> The FTPSClient code used to delegate to FTPClient
> {noformat}
> _openDataConnection_
> {noformat}
> method.
> [https://github.com/apache/commons-net/blob/b5038eff135dff54e2ee2d09b94ec7d8937cb09b/src/main/java/org/apache/commons/net/ftp/FTPClient.java#L696]
> This method supports `wrapOnDeflate` while openDataSecureConnection does not.
> I'm not sure if FTPS supports DEFLATE transfer mode but while implementing an
> Apache Pekko workaround for the NET-718, I spotted the diff.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (COLLECTIONS-856) Document the interaction between PeekingIterator and FilteredIterator
[ https://issues.apache.org/jira/browse/COLLECTIONS-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865716#comment-17865716 ] Gary D. Gregory commented on COLLECTIONS-856: - [~benjaminconfino] Thank you for your report 😀 Would you like to create a PR on GitHub to update the documentation? > Document the interaction between PeekingIterator and FilteredIterator > - > > Key: COLLECTIONS-856 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-856 > Project: Commons Collections > Issue Type: Improvement > Components: Iterator >Affects Versions: 4.5.0-M1 >Reporter: Benjamin Confino >Priority: Minor > > If you have a FilteredIterator, call peek and get an element x. Then > something modifies the state of that x. Then you call peek again > FilteredIterator will return x even if x no longer passes the predicate. > I think this behaviour is correct. I would not expect the the state of an > iterator to change unless I called a method like next(), and I would not > expect an exception like ConcurrentModificationException when the collection > has not changed. > However its an obscure edge case so it might be worth documenting it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DAEMON-460) High CPU usage in prunsrv.exe since Daemon 1.3.3
[ https://issues.apache.org/jira/browse/DAEMON-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865715#comment-17865715 ] Gary D. Gregory commented on DAEMON-460: Hi [~markt] Did you get a chance for another look? > High CPU usage in prunsrv.exe since Daemon 1.3.3 > > > Key: DAEMON-460 > URL: https://issues.apache.org/jira/browse/DAEMON-460 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.3.3 >Reporter: Japie vd Linde >Priority: Major > Attachments: EspRun-Service-Log.2023-06-05.log, > image-2023-05-31-09-31-21-485.png, image-2023-06-05-13-38-38-435.png, > image-2024-05-29-15-56-35-585.png, image-2024-05-29-15-57-37-665.png, > image-2024-05-31-10-00-10-916.png, test-windows-service.zip > > > When using the --StopTimeout=30 parameter on service using prunsrv the CPU > usage is reported as very high on Windows. Rolling back to older prunsrv > seems to resolve the problem. > !image-2023-05-31-09-31-21-485.png! > What could be the possible causes for this problem? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] LANG-1641: GmtTimeZone now implements #equals(Object) using it's time… [commons-lang]
garydgregory commented on PR #703: URL: https://github.com/apache/commons-lang/pull/703#issuecomment-2226918908 Closing: If this class is rewritten or replaced, it should likely be done with Java 8's `java.time` package, see `ZoneId` and friends. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LANG-1641: GmtTimeZone now implements #equals(Object) using it's time… [commons-lang]
garydgregory closed pull request #703: LANG-1641: GmtTimeZone now implements #equals(Object) using it's time… URL: https://github.com/apache/commons-lang/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Annotated Fraction.java [commons-lang]
garydgregory commented on PR #497: URL: https://github.com/apache/commons-lang/pull/497#issuecomment-2226911863 Closing: Old, won't do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Annotated Fraction.java [commons-lang]
garydgregory closed pull request #497: Annotated Fraction.java URL: https://github.com/apache/commons-lang/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream` [commons-lang]
garydgregory closed pull request #400: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream` URL: https://github.com/apache/commons-lang/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream` [commons-lang]
garydgregory commented on PR #400: URL: https://github.com/apache/commons-lang/pull/400#issuecomment-2226911176 Closing: No longer applies as tests are different now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LANG-1410: eliminate one unnecessary local int variable and add more tests [commons-lang]
garydgregory commented on PR #392: URL: https://github.com/apache/commons-lang/pull/392#issuecomment-2226903310 Closing: Out of date with current tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LANG-1410: eliminate one unnecessary local int variable and add more tests [commons-lang]
garydgregory closed pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add module-info for Java 9 [commons-lang]
garydgregory commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-2226896527 Closing: This is currently done through the moditect Maven plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add module-info for Java 9 [commons-lang]
garydgregory closed pull request #299: Add module-info for Java 9 URL: https://github.com/apache/commons-lang/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LANG-1326 - Fixed isAllEmpty and isAllBlank [commons-lang]
garydgregory commented on PR #267: URL: https://github.com/apache/commons-lang/pull/267#issuecomment-2226895923 Closing: Old PR with dubious (IMO) behavior break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LANG-1326 - Fixed isAllEmpty and isAllBlank [commons-lang]
garydgregory closed pull request #267: LANG-1326 - Fixed isAllEmpty and isAllBlank URL: https://github.com/apache/commons-lang/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1270) Add StringUtils#isAnyNotEmpty and #isAnyNotBlank
[ https://issues.apache.org/jira/browse/LANG-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1270. --- Resolution: Won't Do I do not think we should go in this direction, or we'll end up with "Not" versions of all boolean methods. > Add StringUtils#isAnyNotEmpty and #isAnyNotBlank > > > Key: LANG-1270 > URL: https://issues.apache.org/jira/browse/LANG-1270 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Pascal Schumacher >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [LANG-1655] Add API canonicalCompositionAfterStripAccents (an issue where characters were separated in the NFD…) [commons-lang]
garydgregory commented on PR #741: URL: https://github.com/apache/commons-lang/pull/741#issuecomment-2226893337 -1: Too niche IMO, more of a Commons Text method regardless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1657) DiffBuilder: Type constraint for method append(..., DiffResult) too strict
[
https://issues.apache.org/jira/browse/LANG-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-1657.
---
Fix Version/s: 3.15.0
Resolution: Fixed
> DiffBuilder: Type constraint for method append(..., DiffResult) too strict
> --
>
> Key: LANG-1657
> URL: https://issues.apache.org/jira/browse/LANG-1657
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.builder.*
>Affects Versions: 3.12.0
>Reporter: Matthias Welz
>Priority: Major
> Fix For: 3.15.0
>
>
> The DiffBuilder has a method append which allows to append an existing
> DiffResult for a property. The example illustrates this the following way:
>
> {code:java}
> public class Person implements Diffable {
>String name;
>Address address; // implements Diffable
>...
>public DiffResult diff(Person obj) {
> return new DiffBuilder(this, obj, ToStringStyle.SHORT_PREFIX_STYLE)
>.append("name", this.name, obj.name)
>.append("address", this.address.diff(obj.address))
>.build();
>}
> }
> {code}
>
> However, the signature of the method was recently changed to:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> As a consequence, the example code won't compile anymore when using generics
> because the a _DiffBuilder_ will only accept _DiffResult_ but
> not _DiffResult_ for its append method.
> The signature should be:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> or:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> instead.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [LANG-1657] DiffBuilder: Type constraint for method append(..., DiffResult) too strict [commons-lang]
garydgregory commented on PR #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-2226892119 @greatmastermario Thank you for your PR. The solution in git master now includes your main change but with more tests. You are credited in `changes.xml`. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [LANG-1657] DiffBuilder: Type constraint for method append(..., DiffResult) too strict [commons-lang]
garydgregory closed pull request #786: [LANG-1657] DiffBuilder: Type constraint for method append(..., DiffResult) too strict URL: https://github.com/apache/commons-lang/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace() [commons-lang]
garydgregory commented on PR #1110: URL: https://github.com/apache/commons-lang/pull/1110#issuecomment-2226883974 Closing: No reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace() [commons-lang]
garydgregory closed pull request #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace() URL: https://github.com/apache/commons-lang/pull/1110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade commons-io from 2.15.1 to 2.16.1 [commons-compress]
garydgregory commented on PR #513: URL: https://github.com/apache/commons-compress/pull/513#issuecomment-2226880798 @madrob ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
