[jira] [Closed] (LANG-1652) Check whether the given class has a public constructor
[ https://issues.apache.org/jira/browse/LANG-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LANG-1652. --- Resolution: Won't Fix > Check whether the given class has a public constructor > -- > > Key: LANG-1652 > URL: https://issues.apache.org/jira/browse/LANG-1652 > Project: Commons Lang > Issue Type: Improvement > Components: lang.reflect.* >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > Determine whether the given class has a public constructor with the given > signature, checking accessibility. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (LANG-1649) Check if method is Overridable
[ https://issues.apache.org/jira/browse/LANG-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LANG-1649. --- Resolution: Won't Fix > Check if method is Overridable > -- > > Key: LANG-1649 > URL: https://issues.apache.org/jira/browse/LANG-1649 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.12.0 >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 5h 10m > Remaining Estimate: 0h > > Create a method that Check if the given Method is overridable in the given a > Class > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (LANG-1649) Check if method is Overridable
[ https://issues.apache.org/jira/browse/LANG-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543640#comment-17543640 ] Arturo Bernal commented on LANG-1649: - Hi [~aherbert] I'm just close the PR. i'm really sorry for waste your time reviewing it. > Check if method is Overridable > -- > > Key: LANG-1649 > URL: https://issues.apache.org/jira/browse/LANG-1649 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.12.0 >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 5h 10m > Remaining Estimate: 0h > > Create a method that Check if the given Method is overridable in the given a > Class > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (VFS-799) Minor improvements
[ https://issues.apache.org/jira/browse/VFS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved VFS-799. --- Resolution: Fixed In Master. > Minor improvements > -- > > Key: VFS-799 > URL: https://issues.apache.org/jira/browse/VFS-799 > Project: Commons VFS > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (STATISTICS-44) MavenScmCli issues
Arturo Bernal created STATISTICS-44:
---
Summary: MavenScmCli issues
Key: STATISTICS-44
URL: https://issues.apache.org/jira/browse/STATISTICS-44
Project: Apache Commons Statistics
Issue Type: Bug
Reporter: Arturo Bernal
In the main method there is a check that always that is never fulfilled
{code:java}
if ( args.length > 3 )
{code}
I need to first analyze to see the best solutions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-344) Check final variable checkstyle
Arturo Bernal created FILEUPLOAD-344: Summary: Check final variable checkstyle Key: FILEUPLOAD-344 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-344 Project: Commons FileUpload Issue Type: Improvement Reporter: Arturo Bernal * Checks that local variables are declared final. Add ¨FinalLocalVariable¨parameter to force all variable to be final, ¨for¨ loop ass well * Add checkstyle in run task. Add check style configuration in build task in order to be executed every time it's run. * solve checkstyle errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (LANG-1660) Gets a hex String form of an object's identity hash code
[ https://issues.apache.org/jira/browse/LANG-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LANG-1660. --- Resolution: Fixed Already implemented > Gets a hex String form of an object's identity hash code > > > Key: LANG-1660 > URL: https://issues.apache.org/jira/browse/LANG-1660 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Gets a hex String form of an object's identity hash code and reuse un Commons > Lang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-338) FileItem.write crash on Windows Tomcat
[ https://issues.apache.org/jira/browse/FILEUPLOAD-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369847#comment-17369847 ] Arturo Bernal commented on FILEUPLOAD-338: -- Hi [~yang2021] If I correct understand the problem it's in de commons IO protect and not in FileUpload. As far i understand you have an issue while the file it's moving, and thats operations are handling by commons IO protect. Probably you should check with them. Arturo TY > FileItem.write crash on Windows Tomcat > -- > > Key: FILEUPLOAD-338 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-338 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.4 >Reporter: yangshulin >Priority: Critical > > When I use FileItem.write on FileUpload 1.4, it will crash on Windows Tomcat, > linux server has not been tested. I find it is crashed by FileUtils.moveFile, > which reports IO Exception. FileUpload 1.3 works well, because it use file > streams copying. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-338) FileItem.write crash on Windows Tomcat
[ https://issues.apache.org/jira/browse/FILEUPLOAD-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368617#comment-17368617 ] Arturo Bernal commented on FILEUPLOAD-338: -- HI [~yang2021] Would you be able to provide a unit test? It would be much easy looking into with a test case and the files that cause the issue. Thank you, Arturo > FileItem.write crash on Windows Tomcat > -- > > Key: FILEUPLOAD-338 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-338 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.4 >Reporter: yangshulin >Priority: Critical > > When I use FileItem.write on FileUpload 1.4, it will crash on Windows Tomcat, > linux server has not been tested. I find it is crashed by FileUtils.moveFile, > which reports IO Exception. FileUpload 1.3 works well, because it use file > streams copying. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-268) fileItem.write(File file) Throws generic Exception
[ https://issues.apache.org/jira/browse/FILEUPLOAD-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360158#comment-17360158 ] Arturo Bernal commented on FILEUPLOAD-268: -- Hi [~joc...@apache.org] I think we can close this Jira. TY > fileItem.write(File file) Throws generic Exception > -- > > Key: FILEUPLOAD-268 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-268 > Project: Commons FileUpload > Issue Type: Improvement >Reporter: Usman Mutawakil >Priority: Minor > > It might be helpful if the call to fileItem.write() threw a more > appropriately named exception. I've never had this exception actually get > thrown so I have no idea whether or not the exception message is detailed so > I wrap it in my own FileItemException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-269) CommonsFileUploadSupport ignores fileSizeMax
[ https://issues.apache.org/jira/browse/FILEUPLOAD-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357752#comment-17357752 ] Arturo Bernal commented on FILEUPLOAD-269: -- Hi [~sergiuo] Don't understand the exactly problem here. AFAIK Those class that you comment are from Spring. On the other hand, the maximum size is used in FileItemIterator, FileItemStreamImpl, among others . Pls cl TY > CommonsFileUploadSupport ignores fileSizeMax > - > > Key: FILEUPLOAD-269 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-269 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.3.1 >Reporter: Sergiu Ojog >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > Code: > long fileSizeMax = 1024*1024; > CommonsMultipartResolver commonsMultipartResolver = new > CommonsMultipartResolver(servletContext); > commonsMultipartResolver.getFileUpload().setFileSizeMax(fileSizeMax); > commonsMultipartResolver.resolveMultipart(request); > Observed: > The fileSizeMax is not used, > CommonsFileUploadSupport.prepareFileUpload creates a new FileUpload and does > not propagate the existing fileSizeMax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-307) Request InputStream created in FileItemIteratorImpl can be left open
[
https://issues.apache.org/jira/browse/FILEUPLOAD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355859#comment-17355859
]
Arturo Bernal commented on FILEUPLOAD-307:
--
HI [~matafagafo]
Thank you for your report.
Could you please provide a unit test where is reproduced in order to to
analyze it? would be very helpful.
TY
Arturo
> Request InputStream created in FileItemIteratorImpl can be left open
>
>
> Key: FILEUPLOAD-307
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-307
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.4
>Reporter: Fernando Hartmann
>Priority: Major
>
> Some exceptions in FileUploadBase.parseRequest you can leave Request
> InputStream open, leading to a memory leak, because FileItemIteratorImpl
> InputStream is not closed.
> In my case the following Exception generates the problem.
>
> {code:java}
> Caused by: java.io.EOFException: Unexpected EOF read on the socket
> at
> org.apache.coyote.http11.InternalNioInputBuffer.fill(InternalNioInputBuffer.java:152)
> ~[tomcat-coyote.jar:8.0.27]
> at
> org.apache.coyote.http11.InternalNioInputBuffer$SocketInputBuffer.doRead(InternalNioInputBuffer.java:177)
> ~[tomcat-coyote.jar:8.0.27]
> at
> org.apache.coyote.http11.filters.IdentityInputFilter.doRead(IdentityInputFilter.java:110)
> ~[tomcat-coyote.jar:8.0.27]
> at
> org.apache.coyote.http11.AbstractInputBuffer.doRead(AbstractInputBuffer.java:416)
> ~[tomcat-coyote.jar:8.0.27]
> at org.apache.coyote.Request.doRead(Request.java:469)
> ~[tomcat-coyote.jar:8.0.27]
> at
> org.apache.catalina.connector.InputBuffer.realReadBytes(InputBuffer.java:342)
> ~[catalina.jar:8.0.27]
> at org.apache.tomcat.util.buf.ByteChunk.substract(ByteChunk.java:395)
> ~[tomcat-util.jar:8.0.27]
> at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:367)
> ~[catalina.jar:8.0.27]
> at
> org.apache.catalina.connector.CoyoteInputStream.read(CoyoteInputStream.java:190)
> ~[catalina.jar:8.0.27]
> at java.io.FilterInputStream.read(FilterInputStream.java:133)
> ~[?:1.8.0_211]
> at
> org.apache.commons.fileupload.util.LimitedInputStream.read(LimitedInputStream.java:132)
> ~[commons-fileupload-1.4.jar:1.4]
> at
> org.apache.commons.fileupload.MultipartStream$ItemInputStream.makeAvailable(MultipartStream.java:1027)
> ~[commons-fileupload-1.4.jar:1.4]
> at
> org.apache.commons.fileupload.MultipartStream$ItemInputStream.read(MultipartStream.java:931)
> ~[commons-fileupload-1.4.jar:1.4]
> at java.io.InputStream.read(InputStream.java:101) ~[?:1.8.0_211]
> at org.apache.commons.fileupload.util.Streams.copy(Streams.java:98)
> ~[commons-fileupload-1.4.jar:1.4]
> at org.apache.commons.fileupload.util.Streams.copy(Streams.java:68)
> ~[commons-fileupload-1.4.jar:1.4]
> at
> org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:346)
> ~[commons-fileupload-1.4.jar:1.4]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-331) Solve warnings / error checkstyle
[ https://issues.apache.org/jira/browse/FILEUPLOAD-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved FILEUPLOAD-331. -- Resolution: Fixed in master > Solve warnings / error checkstyle > - > > Key: FILEUPLOAD-331 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-331 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > The idea it's to resolve all the warning and error of the checkstyle > > > * Checkstyle found 40 item(s) in 17 file(s) > * Base64Decoder.java : 1 item(s) > * 'byte' is followed by whitespace. (107:20) [NoWhitespaceAfter] > * DiskFileItem.java : 2 item(s) > * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) > [NewlineAtEndOfFile] > * Avoid inline conditionals. (308:42) [AvoidInlineConditionals] > * FileItemIterator.java : 2 item(s) > * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) > [NewlineAtEndOfFile] > * File contains tab characters (this is the first instance). (30:1) > [FileTabCharacter] > * FileItemIteratorImpl.java : 6 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * File contains tab characters (this is the first instance). (47:1) > [FileTabCharacter] > * Missing a Javadoc comment. (47:9) [JavadocVariable] > * Missing a Javadoc comment. (48:9) [JavadocVariable] > * Missing a Javadoc comment. (49:9) [JavadocVariable] > * Line is longer than 120 characters (found 167). (339:0) [LineLength] > * FileItemStreamImpl.java : 4 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * File contains tab characters (this is the first instance). (38:1) > [FileTabCharacter] > * Missing a Javadoc comment. (38:9) [JavadocVariable] > * Variable 'name' must be private and have accessor methods. (53:18) > [VisibilityModifier] > * FileSizeLimitExceededException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * FileUploadBase.java : 1 item(s) > * Line is longer than 120 characters (found 133). (330:0) [LineLength] > * FileUploadIOException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * IOFileUploadException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * InvalidContentTypeException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * ParameterParser.java : 1 item(s) > * Avoid inline conditionals. (319:80) [AvoidInlineConditionals] > * ParseException.java : 1 item(s) > * Redundant 'public' modifier. (34:5) [RedundantModifier] > * RFC2231Utility.java : 12 item(s) > * Line is longer than 120 characters (found 148). (25:0) [LineLength] > * Utility classes should not have a public or default constructor. (32:1) > [HideUtilityClassConstructor] > * Missing a Javadoc comment. (34:5) [JavadocVariable] > * Missing a Javadoc comment. (36:5) [JavadocVariable] > * '0x80' is a magic number. (36:55) [MagicNumber] > * First sentence should end with a period. (46:0) [JavadocStyle] > * First sentence should end with a period. (59:0) [JavadocStyle] > * Line is longer than 120 characters (found 122). (86:0) [LineLength] > * First sentence should end with a period. (106:0) [JavadocStyle] > * '0x7f' is a magic number. (119:63) [MagicNumber] > * '0x7f' is a magic number. (120:63) [MagicNumber] > * '4' is a magic number. (121:34) [MagicNumber] > * SizeException.java : 2 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * Missing package-info.java file. (1:0) [JavadocPackage] > * SizeLimitExceededException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] > * Streams.java : 2 item(s) > * Line is longer than 120 characters (found 124). (65:0) [LineLength] > * File contains tab characters (this is the first instance). (148:5) > [FileTabCharacter] > * UnknownSizeException.java : 1 item(s) > * File does not end with a newline. (1:0) [NewlineAtEndOfFile] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-262) Processing of multipart/form-data request failed. null
[
https://issues.apache.org/jira/browse/FILEUPLOAD-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353820#comment-17353820
]
Arturo Bernal commented on FILEUPLOAD-262:
--
Hi [~krink]
Could you please provide a unit test where is reproduced in order to to
analyze it?, otherwise [~joc...@apache.org] we can close this Ticket
TY
> Processing of multipart/form-data request failed. null
> --
>
> Key: FILEUPLOAD-262
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-262
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.2, 1.3.1
> Environment: Application: Jetty 9.1.4, Debian stable x86_64, Java
> 1.7.0_51
> Public access through reverse proxy (apache 2 2.2.22 + mod_proxy)
>Reporter: Kristian Rink
>Priority: Minor
> Labels: eof, exception, stacktrace
> Attachments: fileupload_error_veera.txt
>
>
> Exposing an upload feature in an existing web application, I frequently see
> stack traces as the one posted below in my server log files. Additional notes:
> - The application runs in an embedded jetty (HTTP) behind an apache2
> mod_proxy reverse proxy (HTTPS).
> - These issues do not generally appear, I tried quite some uploading
> myself today and never managed to reproduce this behaviour even while
> uploading loads of files, large files and both together.
> - It does not seem to be generally tied to a particular browser; the
> users associated with these messages use Firefox, MSIE or Chrome.
> - Looking at network traffic (and the transfer monitor in the app), it
> _seems_ all data to be sent with the request have successfully been
> transmitted yet parsing the request, ultimately, fails.
> - On _some_ clients, in such situations users reported the upload was
> canceled with a "connection reset by peer" error, even though I do not
> see reasons for that in our mod_proxy server log.
> - The application uses the approach outlined in [1] to render a progress bar
> based upon JavaScript and DWR. There is code in that controller trying to
> check how much data has been received by the server so far. I do dump these
> information to the log right now, and it seems all(?) data has been received
> before we run into this error, even though I am not sure about that at all as
> I am unsure how the frameworks handles HTTP traffic internally and how this
> is handled in example with chunked transfer encoding:
> 2014-11-21 18:26:01,846 [qtp1780643722-438] INFO WebUIUploadController -
> uploadStats: 2100399 of 2100399
> Stack trace seen in such situations:
> {code:java}
> org.apache.commons.fileupload.FileUploadBase$IOFileUploadException:
> Processing of multipart/form-data request failed. null
> at
> org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:351)
> ~[commons-fileupload-1.3.1.jar:1.3.1]
> at
> org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:115)
> ~[commons-fileupload-1.3.1.jar:1.3.1]
> at
> de.pc.frontend.WebUIUploadController.submitUpload(WebUIUploadController.java:189)
> ~[webprojekt-1.2-SNAPSHOT.jar:na]
> at sun.reflect.GeneratedMethodAccessor104.invoke(Unknown Source)
> ~[na:na]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.7.0_51]
> at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_51]
> at
> org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:176)
> [spring-web-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:436)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:424)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:790)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:719)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:669)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at
> org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:585)
> [spring-webmvc-3.0.6.RELEASE.jar:3.0.6.RELEASE]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
> at javax.servlet.http.HttpServlet.service(Htt
[jira] [Commented] (FILEUPLOAD-211) [fileupload] fails with transfer-encoding: chunked when multi-part file section includes chunked data
[ https://issues.apache.org/jira/browse/FILEUPLOAD-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351917#comment-17351917 ] Arturo Bernal commented on FILEUPLOAD-211: -- HI [~robsmart] Would you be able to provide a unit test? Thanks, Arturo > [fileupload] fails with transfer-encoding: chunked when multi-part file > section includes chunked data > - > > Key: FILEUPLOAD-211 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-211 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.2.2 > Environment: Tomcat 7, java 1.6, osx >Reporter: Rob Smart >Priority: Minor > > When performing multi-part file upload using chunked data, if a multi-part > section includes separate data chunks it is not correctly parsed and causes > FileUpload to throw "MalformedStreamException: Stream ended unexpectedly" > Having chunked content within a multi-part boundaries is as far as I am aware > valid. > The reason my client has chunked content within file boundaries is that an > audio file is uploaded as it is being recorded. > Example with chunked data within file boundary > POST /UploadServlet HTTP/1.1 > User-Agent: test > Host: 192.168.1.2:9080 > Connection: keep-alive > Transfer-Encoding: chunked > Content-Type:multipart/form-data; > boundary=WebKitFormBoundarykhPSttlPFVKSMhff > 99 > --WebKitFormBoundarykhPSttlPFVKSMhff > Content-Disposition: form-data; name="file"; filename="testfaces.wav" > Content-Type: application/octet-stream > 5 > A > 5 > A > 5 > A > 5 > A > 2a > --WebKitFormBoundarykhPSttlPFVKSMhff-- > 0 > Exception > org.apache.commons.fileupload.MultipartStream$MalformedStreamException: > Stream ended unexpectedly > at > org.apache.commons.fileupload.MultipartStream.readHeaders(MultipartStream.java:538) > at > org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.findNextItem(FileUploadBase.java:999) > at > org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.(FileUploadBase.java:965) > at > org.apache.commons.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:331) > at > org.apache.commons.fileupload.servlet.ServletFileUpload.getItemIterator(ServletFileUpload.java:148) > at > com.ibm.cio.StreamedUploadServlet.doPost(StreamedUploadServlet.java:75) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-241) SocketTimeoutException: Read timed out FileUpload with IE10/11 at 0KB File
[
https://issues.apache.org/jira/browse/FILEUPLOAD-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351881#comment-17351881
]
Arturo Bernal commented on FILEUPLOAD-241:
--
Hi [~joc...@apache.org]
I think you can close this issue as CAT REPRODUE
TY
> SocketTimeoutException: Read timed out FileUpload with IE10/11 at 0KB File
> --
>
> Key: FILEUPLOAD-241
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-241
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.2, 1.3
> Environment: Windows 7, IE10, IE11
>Reporter: Christian Schmidt
>Priority: Major
>
> If you upload a File (Size: 0KB e.g. test.txt) in the Internetexplorer 10 or
> 11 you recieve an SocketTimeoutException: Read timed out on serverside.
> The ServletRequestContext is OK, but the method getItemIterator(ctx) cause
> exception. Firefox and Chrome is OK. There is no exception.
> try
> {
> Map paramMap = srvRequest.getParameterMap();
> ServletRequestContext ctx=new
> ServletRequestContext(srvRequest);
> FileItemIterator iter =
> m_fUpload.getItemIterator(ctx);
> while (iter.hasNext())
> {
> FileItemStream item =iter.next();
> if (!item.isFormField())
> {
>
> processFileUpload(item,paramMap);
> }
> }
> }
> catch (IOException e)
> { ...
> IE
> ContentLength=219, ContentType=multipart/form-data;
> boundary=---7dd17c30210cbe
> === MimeHeaders ===
> x-requested-with = XMLHttpRequest
> accept = */*
> content-type = multipart/form-data;
> boundary=---7dd17c30210cbe
> referer = http://localhost:8080/upload
> accept-language = de-DE
> accept-encoding = gzip, deflate
> user-agent = Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like
> Gecko
> host = localhost:8080
> content-length = 219
> dnt = 1
> connection = Keep-Alive
> cache-control = no-cache
> Chrome
> ContentLength=192, ContentType=multipart/form-data;
> boundary=WebKitFormBoundaryT5ywpwNtenrWvVc6
> === MimeHeaders ===
> host = localhost:8080
> connection = keep-alive
> content-length = 192
> accept = */*
> origin = http://localhost:8080
> x-requested-with = XMLHttpRequest
> user-agent = Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML,
> like Gecko) Chrome/31.0.1650.57 Safari/537.36
> content-type = multipart/form-data;
> boundary=WebKitFormBoundaryT5ywpwNtenrWvVc6
> referer = http://localhost:8080/upload
> accept-encoding = gzip,deflate,sdch
> accept-language = de-DE,de;q=0.8,en-US;q=0.6,en;q=0.4
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.read(SocketInputStream.java:150)
> at java.net.SocketInputStream.read(SocketInputStream.java:121)
> at
> org.apache.coyote.http11.InternalInputBuffer.fill(InternalInputBuffer.java:751)
> at
> org.apache.coyote.http11.InternalInputBuffer$InputStreamInputBuffer.doRead(InternalInputBuffer.java:781)
> at
> org.apache.coyote.http11.filters.IdentityInputFilter.doRead(IdentityInputFilter.java:116)
> at
> org.apache.coyote.http11.InternalInputBuffer.doRead(InternalInputBuffer.java:710)
> at org.apache.coyote.Request.doRead(Request.java:427)
> at
> org.apache.catalina.connector.InputBuffer.realReadBytes(InputBuffer.java:304)
> at org.apache.tomcat.util.buf.ByteChunk.substract(ByteChunk.java:419)
> at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:327)
> at
> org.apache.catalina.connector.CoyoteInputStream.read(CoyoteInputStream.java:193)
> at
> org.apache.commons.fileupload.MultipartStream$ItemInputStream.makeAvailable(MultipartStream.java:997)
> at
> org.apache.commons.fileupload.MultipartStream$ItemInputStream.read(MultipartStream.java:901)
> at java.io.InputStream.read(InputStream.java:101)
> at org.apache.commons.fileupload.util.Streams.copy(Streams.java:101)
> at org.apache.commons.fileupload.util.Streams.copy(Streams.java:70)
> at
> org.apache.commons.fileupload.MultipartStream.readBodyData(MultipartStream.java:589)
> at
> org.apache.commons.fileupload.MultipartStream.discardBodyData(MultipartStream.java:613)
> at
> org.apache.commons.fileupload.MultipartStream.skipPreamble(MultipartStream.java:630)
>
[jira] [Closed] (FILEUPLOAD-310) Minor improvements
[ https://issues.apache.org/jira/browse/FILEUPLOAD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-310. Resolution: Fixed in > Minor improvements > -- > > Key: FILEUPLOAD-310 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-310 > Project: Commons FileUpload > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-327) Solve SpotBug warning/errors
[ https://issues.apache.org/jira/browse/FILEUPLOAD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-327. Resolution: Fixed i > Solve SpotBug warning/errors > > > Key: FILEUPLOAD-327 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-327 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > This Jira it's to solve the following error/warnings: > > * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) > * EI_EXPOSE_REP2 --> EI2: May expose internal representation by > incorporating reference to mutable object (EI_EXPOSE_REP2) > * EI_EXPOSE_REP --> EI: May expose internal representation by returning > reference to mutable object (EI_EXPOSE_REP) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml config file
[ https://issues.apache.org/jira/browse/FILEUPLOAD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-329. Resolution: Fixed in master > Fix multiples errors fileupload_checks.xml config file > -- > > Key: FILEUPLOAD-329 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We need to update / fix some problems/error in the fileupload_checks.xml > files. All of them are because the libs and the config was updated > > > SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as > a child in Checker --> Make SuppressionCommentFilter and > SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur > [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > > cannot initialize module TreeWalker - Property 'cacheFile' does not exist, > please check the documentation --> > [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field > from TreeWalker in Checkstyle 8.0. Author: rnveach > [#2883|https://github.com/checkstyle/checkstyle/issues/2883] > > module TreeWalker - cannot initialize module FileContentsHolder --> > [https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowUndeclaredRTE' --> > [https://github.com/jeremylong/DependencyCheck/issues/2492] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowThrowsTagsForSubclasses' --> > https://github.com/checkstyle/checkstyle/issues/7329 > > TreeWalker is not allowed as a parent of LineLength --> > https://github.com/checkstyle/checkstyle/issues/473 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-337) Reuse the byte array buffer
[ https://issues.apache.org/jira/browse/FILEUPLOAD-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-337. Resolution: Won't Do > Reuse the byte array buffer > > > Key: FILEUPLOAD-337 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-337 > Project: Commons FileUpload > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > An intent of speeds the multipart uploads process -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (COMPRESS-576) Minor improvements :
[ https://issues.apache.org/jira/browse/COMPRESS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed COMPRESS-576. -- Resolution: Fixed In master TY > Minor improvements : > > > Key: COMPRESS-576 > URL: https://issues.apache.org/jira/browse/COMPRESS-576 > Project: Commons Compress > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMPRESS-580) Remove redundant operation
[ https://issues.apache.org/jira/browse/COMPRESS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated COMPRESS-580: --- Summary: Remove redundant operation (was: Remove redundan operation) > Remove redundant operation > -- > > Key: COMPRESS-580 > URL: https://issues.apache.org/jira/browse/COMPRESS-580 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > > * Redundant array creation > * Redundant type arguments > * Redundant type cast > * Redundant String operation > * Unnecessarily escaped character -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-580) Remove redundan operation
Arturo Bernal created COMPRESS-580: -- Summary: Remove redundan operation Key: COMPRESS-580 URL: https://issues.apache.org/jira/browse/COMPRESS-580 Project: Commons Compress Issue Type: Sub-task Reporter: Arturo Bernal * Redundant array creation * Redundant type arguments * Redundant type cast * Redundant String operation * Unnecessarily escaped character -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-579) Remove redundant local variable
Arturo Bernal created COMPRESS-579: -- Summary: Remove redundant local variable Key: COMPRESS-579 URL: https://issues.apache.org/jira/browse/COMPRESS-579 Project: Commons Compress Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMPRESS-578) Java 8 improvements
[ https://issues.apache.org/jira/browse/COMPRESS-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated COMPRESS-578: --- Description: * Use lambda alternative * Use reference * Replace Loop with Collection.removeIf() * Use mapToLong().sum()' was: * Use lambda alternative * Use reference * Replace Loop with Collection.removeIf() > Java 8 improvements > --- > > Key: COMPRESS-578 > URL: https://issues.apache.org/jira/browse/COMPRESS-578 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > * Use lambda alternative > * Use reference > * Replace Loop with Collection.removeIf() > * Use mapToLong().sum()' > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-578) Java 8 improvements
Arturo Bernal created COMPRESS-578: -- Summary: Java 8 improvements Key: COMPRESS-578 URL: https://issues.apache.org/jira/browse/COMPRESS-578 Project: Commons Compress Issue Type: Sub-task Reporter: Arturo Bernal * Use lambda alternative * Use reference * Replace Loop with Collection.removeIf() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-577) Simplify assertion
Arturo Bernal created COMPRESS-577: -- Summary: Simplify assertion Key: COMPRESS-577 URL: https://issues.apache.org/jira/browse/COMPRESS-577 Project: Commons Compress Issue Type: Sub-task Reporter: Arturo Bernal Replace assert calls with simpler but equivalent calls. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-576) Minor improvements :
Arturo Bernal created COMPRESS-576: -- Summary: Minor improvements : Key: COMPRESS-576 URL: https://issues.apache.org/jira/browse/COMPRESS-576 Project: Commons Compress Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-337) Reuse the byte array buffer
Arturo Bernal created FILEUPLOAD-337: Summary: Reuse the byte array buffer Key: FILEUPLOAD-337 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-337 Project: Commons FileUpload Issue Type: Improvement Reporter: Arturo Bernal An intent of speeds the multipart uploads process -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCS-226) Use toArray with zero-length array argument
Arturo Bernal created JCS-226: - Summary: Use toArray with zero-length array argument Key: JCS-226 URL: https://issues.apache.org/jira/browse/JCS-226 Project: Commons JCS Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCS-225) Fix Typo and Javadoc
Arturo Bernal created JCS-225: - Summary: Fix Typo and Javadoc Key: JCS-225 URL: https://issues.apache.org/jira/browse/JCS-225 Project: Commons JCS Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCS-224) Remove commented code
Arturo Bernal created JCS-224: - Summary: Remove commented code Key: JCS-224 URL: https://issues.apache.org/jira/browse/JCS-224 Project: Commons JCS Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (JCS-219) Unnecessary boxing
[ https://issues.apache.org/jira/browse/JCS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed JCS-219. - Resolution: Won't Do > Unnecessary boxing > -- > > Key: JCS-219 > URL: https://issues.apache.org/jira/browse/JCS-219 > Project: Commons JCS > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > > Explicit manual boxing is unnecessary under Java 5 and newer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (JCS-221) Fix typo
[ https://issues.apache.org/jira/browse/JCS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed JCS-221. - Resolution: Fixed merge in master > Fix typo > > > Key: JCS-221 > URL: https://issues.apache.org/jira/browse/JCS-221 > Project: Commons JCS > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > > Fix typo in javadoc and comment -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (JCS-218) Redundant operation
[ https://issues.apache.org/jira/browse/JCS-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed JCS-218. - Resolution: Fixed Merged in master > Redundant operation > --- > > Key: JCS-218 > URL: https://issues.apache.org/jira/browse/JCS-218 > Project: Commons JCS > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > > > * Remove redundant String operation > * Remove redundant type cast > * Redundant type arguments -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1661) Add methods to ClassUtils to get the class type names in a null-safe manner
[ https://issues.apache.org/jira/browse/LANG-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated LANG-1661: Labels: pull-request-available (was: ) > Add methods to ClassUtils to get the class type names in a null-safe manner > --- > > Key: LANG-1661 > URL: https://issues.apache.org/jira/browse/LANG-1661 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Add methods ClassUtils to get the class names type in a null-safe manner: > - getTypeName(Class) > - getTypeName(Object) > - getTypeName(Class, String) > - getTypeName(Object, String) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1661) Add methods to ClassUtils to get the class type names in a null-safe manner
Arturo Bernal created LANG-1661: --- Summary: Add methods to ClassUtils to get the class type names in a null-safe manner Key: LANG-1661 URL: https://issues.apache.org/jira/browse/LANG-1661 Project: Commons Lang Issue Type: Improvement Reporter: Arturo Bernal Add methods ClassUtils to get the class names type in a null-safe manner: - getTypeName(Class) - getTypeName(Object) - getTypeName(Class, String) - getTypeName(Object, String) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-320) Use charset constant int the test V1
[ https://issues.apache.org/jira/browse/FILEUPLOAD-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-320. Resolution: Fixed Merged in master > Use charset constant int the test V1 > > > Key: FILEUPLOAD-320 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-320 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-326) Simplify Assertion
[ https://issues.apache.org/jira/browse/FILEUPLOAD-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-326. Resolution: Fixed Merged in master > Simplify Assertion > -- > > Key: FILEUPLOAD-326 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-326 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-325) Remove Unused Assignment
[ https://issues.apache.org/jira/browse/FILEUPLOAD-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-325. Resolution: Fixed Merged in master > Remove Unused Assignment > > > Key: FILEUPLOAD-325 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-325 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The assigned value is always overwritten by other assignments before the next > read of the variable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-336) WhitespaceAround
[ https://issues.apache.org/jira/browse/FILEUPLOAD-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-336. Resolution: Fixed Merged in master > WhitespaceAround > > > Key: FILEUPLOAD-336 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-336 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > * '+' is not preceded with whitespace. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-335) ConstantName and Operator Order
[ https://issues.apache.org/jira/browse/FILEUPLOAD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-335. Resolution: Fixed Merged in master > ConstantName and Operator Order > > > Key: FILEUPLOAD-335 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-335 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > > > * Name must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. (55:30) > [ConstantName] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-334) LineLength - Line is longer than 120 characters
[ https://issues.apache.org/jira/browse/FILEUPLOAD-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-334. Resolution: Fixed Merged in master > LineLength - Line is longer than 120 characters > --- > > Key: FILEUPLOAD-334 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-334 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-294) Link "Source repository" is broken on project website
[ https://issues.apache.org/jira/browse/FILEUPLOAD-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345692#comment-17345692 ] Arturo Bernal commented on FILEUPLOAD-294: -- Hi [~stephan.markwal...@appway.com] Fixed too. Please check [PR89|https://github.com/apache/commons-fileupload/pull/89] TY > Link "Source repository" is broken on project website > - > > Key: FILEUPLOAD-294 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-294 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Stephan Markwalder >Priority: Minor > > The link behind "Source repository" is broken: > [https://commons.apache.org/proper/commons-fileupload/source-repository.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1659) Method to check if an object it's an array
[
https://issues.apache.org/jira/browse/LANG-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345625#comment-17345625
]
Arturo Bernal commented on LANG-1659:
-
Hi
The idea behind this it's centralize the commons functionality. There a lot of
examples in commons-ang.
And using getClass().isArray() does not prevent NPE
TY
> Method to check if an object it's an array
> --
>
> Key: LANG-1659
> URL: https://issues.apache.org/jira/browse/LANG-1659
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Major
> Labels: pull-requests-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The idea it's have a method that determine whether the given object is an
> array. Change all the reference of .getClass().isArray() in favor of
> {code:java}
> ObjectUtils.isArray(value)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (LANG-1660) Gets a hex String form of an object's identity hash code
Arturo Bernal created LANG-1660: --- Summary: Gets a hex String form of an object's identity hash code Key: LANG-1660 URL: https://issues.apache.org/jira/browse/LANG-1660 Project: Commons Lang Issue Type: Improvement Reporter: Arturo Bernal Gets a hex String form of an object's identity hash code and reuse un Commons Lang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1659) Method to check if an object it's an array
[
https://issues.apache.org/jira/browse/LANG-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated LANG-1659:
Labels: pull-requests-available (was: )
> Method to check if an object it's an array
> --
>
> Key: LANG-1659
> URL: https://issues.apache.org/jira/browse/LANG-1659
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Major
> Labels: pull-requests-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The idea it's have a method that determine whether the given object is an
> array. Change all the reference of .getClass().isArray() in favor of
> {code:java}
> ObjectUtils.isArray(value)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (LANG-1659) Method to check if an object it's an array
[
https://issues.apache.org/jira/browse/LANG-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated LANG-1659:
Description:
The idea it's have a method that determine whether the given object is an
array. Change all the reference of .getClass().isArray() in favor of
{code:java}
ObjectUtils.isArray(value)
{code}
was:The idea it's have a method that determine whether the given object is an
array
> Method to check if an object it's an array
> --
>
> Key: LANG-1659
> URL: https://issues.apache.org/jira/browse/LANG-1659
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Major
>
> The idea it's have a method that determine whether the given object is an
> array. Change all the reference of .getClass().isArray() in favor of
> {code:java}
> ObjectUtils.isArray(value)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (LANG-1659) Method to check if an object it's an array
Arturo Bernal created LANG-1659: --- Summary: Method to check if an object it's an array Key: LANG-1659 URL: https://issues.apache.org/jira/browse/LANG-1659 Project: Commons Lang Issue Type: Improvement Reporter: Arturo Bernal The idea it's have a method that determine whether the given object is an array -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IMAGING-305) Replace Collections.sort with list.sort.
Arturo Bernal created IMAGING-305: - Summary: Replace Collections.sort with list.sort. Key: IMAGING-305 URL: https://issues.apache.org/jira/browse/IMAGING-305 Project: Commons Imaging Issue Type: Sub-task Reporter: Arturo Bernal Replace Collections.sort(list, comparator) with list.sort(comparator). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IMAGING-304) Use Comparator combinator
Arturo Bernal created IMAGING-304: - Summary: Use Comparator combinator Key: IMAGING-304 URL: https://issues.apache.org/jira/browse/IMAGING-304 Project: Commons Imaging Issue Type: Sub-task Reporter: Arturo Bernal Comparators defined as lambda expressions which could be expressed using methods like Comparator.comparing() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IMAGING-303) Simplify If-else conditions
Arturo Bernal created IMAGING-303: - Summary: Simplify If-else conditions Key: IMAGING-303 URL: https://issues.apache.org/jira/browse/IMAGING-303 Project: Commons Imaging Issue Type: Sub-task Reporter: Arturo Bernal if statements which can be simplified to a single assignment -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-275) when FileSizeLimitExceededException occur,the original InputStream is closed!
[ https://issues.apache.org/jira/browse/FILEUPLOAD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343416#comment-17343416 ] Arturo Bernal commented on FILEUPLOAD-275: -- Hi [~JoshuaXu] I'm trying to understand this issue in order to reproduce but but I thing we need a little more information in order to help you. Could you provide a test where the problem can be reproduced? TY Arturo > when FileSizeLimitExceededException occur,the original InputStream is closed! > - > > Key: FILEUPLOAD-275 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-275 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.3.1, 1.3.2 >Reporter: JoshuaXu >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > integrate Common-fileupload with spring boot ,when > FileSizeLimitExceededException accurs, the original InputStream is closed > which make the browser lost the response,and the browser then get a > "Connection Reset"error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-254) Improve MultipartStream public API
[ https://issues.apache.org/jira/browse/FILEUPLOAD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343000#comment-17343000 ] Arturo Bernal commented on FILEUPLOAD-254: -- Hi [~sv3k] [~dma_k] , Correct me if i'm wrong but i think the method [newInputStream|https://github.com/apache/commons-fileupload/blob/master/src/main/java/org/apache/commons/fileupload2/MultipartStream.java#L629] it's already public. Maybe i'm wrong and you are talking about another part of the code TY Arturo > Improve MultipartStream public API > -- > > Key: FILEUPLOAD-254 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-254 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 1.3.1 >Reporter: Anton Gorbunov >Assignee: Jochen Wiedmann >Priority: Major > > In many cases user may need to get part content as an InputStream. > MultipartStream class already has such method - newInputStream(), but for > some reason it made package-private. > I suggest to make it public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-294) Link "Source repository" is broken on project website
[ https://issues.apache.org/jira/browse/FILEUPLOAD-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342287#comment-17342287 ] Arturo Bernal commented on FILEUPLOAD-294: -- HI [~stephan.markwal...@appway.com] The Broken link Source repository was updated. Please check [https://commons.apache.org/proper/commons-fileupload/scm.html] > Link "Source repository" is broken on project website > - > > Key: FILEUPLOAD-294 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-294 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Stephan Markwalder >Priority: Minor > > The link behind "Source repository" is broken: > [https://commons.apache.org/proper/commons-fileupload/source-repository.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-268) fileItem.write(File file) Throws generic Exception
[ https://issues.apache.org/jira/browse/FILEUPLOAD-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342074#comment-17342074 ] Arturo Bernal commented on FILEUPLOAD-268: -- Hi [~umutawakil] As Bruno comment the implementation of FileItem --> DiskFileItem throws a FileUploadException and IOException Please check [https://github.com/apache/commons-fileupload/blob/master/src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java#L383] Ty Arturo > fileItem.write(File file) Throws generic Exception > -- > > Key: FILEUPLOAD-268 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-268 > Project: Commons FileUpload > Issue Type: Improvement >Reporter: Usman Mutawakil >Priority: Minor > > It might be helpful if the call to fileItem.write() threw a more > appropriately named exception. I've never had this exception actually get > thrown so I have no idea whether or not the exception message is detailed so > I wrap it in my own FileItemException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-336) WhitespaceAround
Arturo Bernal created FILEUPLOAD-336: Summary: WhitespaceAround Key: FILEUPLOAD-336 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-336 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal * '+' is not preceded with whitespace. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-335) ConstantName and Operator Order
[ https://issues.apache.org/jira/browse/FILEUPLOAD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-335: - Parent: FILEUPLOAD-331 Issue Type: Sub-task (was: Bug) > ConstantName and Operator Order > > > Key: FILEUPLOAD-335 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-335 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > > > * Name must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. (55:30) > [ConstantName] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-335) ConstantName and Operator Oder
[ https://issues.apache.org/jira/browse/FILEUPLOAD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-335: - Summary: ConstantName and Operator Oder (was: ConstantName ) > ConstantName and Operator Oder > --- > > Key: FILEUPLOAD-335 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-335 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > > > * Name must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. (55:30) > [ConstantName] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-335) ConstantName and Operator Order
[ https://issues.apache.org/jira/browse/FILEUPLOAD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-335: - Summary: ConstantName and Operator Order (was: ConstantName and Operator Oder) > ConstantName and Operator Order > > > Key: FILEUPLOAD-335 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-335 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > > > * Name must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. (55:30) > [ConstantName] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-335) ConstantName
Arturo Bernal created FILEUPLOAD-335: Summary: ConstantName Key: FILEUPLOAD-335 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-335 Project: Commons FileUpload Issue Type: Bug Reporter: Arturo Bernal * Name must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. (55:30) [ConstantName] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-334) LineLength - Line is longer than 120 characters
Arturo Bernal created FILEUPLOAD-334: Summary: LineLength - Line is longer than 120 characters Key: FILEUPLOAD-334 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-334 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-332) Replace File Tab. Character with spaces
[ https://issues.apache.org/jira/browse/FILEUPLOAD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-332. Resolution: Fixed in master > Replace File Tab. Character with spaces > --- > > Key: FILEUPLOAD-332 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-332 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > * File contains tab characters (this is the first instance). > [FileTabCharacter] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-333) Add Newline At End Of File
[ https://issues.apache.org/jira/browse/FILEUPLOAD-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed FILEUPLOAD-333. Resolution: Fixed in > Add Newline At End Of File > -- > > Key: FILEUPLOAD-333 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-333 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > * File does not end with a newline.[NewlineAtEndOfFile] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-333) Add Newline At End Of File
Arturo Bernal created FILEUPLOAD-333: Summary: Add Newline At End Of File Key: FILEUPLOAD-333 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-333 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal * File does not end with a newline.[NewlineAtEndOfFile] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-330) Add taglist-maven-plugin
[
https://issues.apache.org/jira/browse/FILEUPLOAD-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal closed FILEUPLOAD-330.
Resolution: Fixed
In master
> Add taglist-maven-plugin
> -
>
> Key: FILEUPLOAD-330
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-330
> Project: Commons FileUpload
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Major
>
> The Taglist Maven Plugin generates a report on various tags found in the
> code, like \{{@todo}} or \{{//TODO}} tags.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-332) Replace File Tab. Character with spaces
[ https://issues.apache.org/jira/browse/FILEUPLOAD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-332: - Summary: Replace File Tab. Character with spaces (was: File Tab. Character) > Replace File Tab. Character with spaces > --- > > Key: FILEUPLOAD-332 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-332 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > > * File contains tab characters (this is the first instance). > [FileTabCharacter] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-332) File Tab. Character
Arturo Bernal created FILEUPLOAD-332: Summary: File Tab. Character Key: FILEUPLOAD-332 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-332 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal * File contains tab characters (this is the first instance). [FileTabCharacter] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-331) Solve warnings / error checkstyle
Arturo Bernal created FILEUPLOAD-331: Summary: Solve warnings / error checkstyle Key: FILEUPLOAD-331 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-331 Project: Commons FileUpload Issue Type: Bug Reporter: Arturo Bernal The idea it's to resolve all the warning and error of the checkstyle * Checkstyle found 40 item(s) in 17 file(s) * Base64Decoder.java : 1 item(s) * 'byte' is followed by whitespace. (107:20) [NoWhitespaceAfter] * DiskFileItem.java : 2 item(s) * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) [NewlineAtEndOfFile] * Avoid inline conditionals. (308:42) [AvoidInlineConditionals] * FileItemIterator.java : 2 item(s) * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) [NewlineAtEndOfFile] * File contains tab characters (this is the first instance). (30:1) [FileTabCharacter] * FileItemIteratorImpl.java : 6 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * File contains tab characters (this is the first instance). (47:1) [FileTabCharacter] * Missing a Javadoc comment. (47:9) [JavadocVariable] * Missing a Javadoc comment. (48:9) [JavadocVariable] * Missing a Javadoc comment. (49:9) [JavadocVariable] * Line is longer than 120 characters (found 167). (339:0) [LineLength] * FileItemStreamImpl.java : 4 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * File contains tab characters (this is the first instance). (38:1) [FileTabCharacter] * Missing a Javadoc comment. (38:9) [JavadocVariable] * Variable 'name' must be private and have accessor methods. (53:18) [VisibilityModifier] * FileSizeLimitExceededException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * FileUploadBase.java : 1 item(s) * Line is longer than 120 characters (found 133). (330:0) [LineLength] * FileUploadIOException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * IOFileUploadException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * InvalidContentTypeException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * ParameterParser.java : 1 item(s) * Avoid inline conditionals. (319:80) [AvoidInlineConditionals] * ParseException.java : 1 item(s) * Redundant 'public' modifier. (34:5) [RedundantModifier] * RFC2231Utility.java : 12 item(s) * Line is longer than 120 characters (found 148). (25:0) [LineLength] * Utility classes should not have a public or default constructor. (32:1) [HideUtilityClassConstructor] * Missing a Javadoc comment. (34:5) [JavadocVariable] * Missing a Javadoc comment. (36:5) [JavadocVariable] * '0x80' is a magic number. (36:55) [MagicNumber] * First sentence should end with a period. (46:0) [JavadocStyle] * First sentence should end with a period. (59:0) [JavadocStyle] * Line is longer than 120 characters (found 122). (86:0) [LineLength] * First sentence should end with a period. (106:0) [JavadocStyle] * '0x7f' is a magic number. (119:63) [MagicNumber] * '0x7f' is a magic number. (120:63) [MagicNumber] * '4' is a magic number. (121:34) [MagicNumber] * SizeException.java : 2 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * Missing package-info.java file. (1:0) [JavadocPackage] * SizeLimitExceededException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] * Streams.java : 2 item(s) * Line is longer than 120 characters (found 124). (65:0) [LineLength] * File contains tab characters (this is the first instance). (148:5) [FileTabCharacter] * UnknownSizeException.java : 1 item(s) * File does not end with a newline. (1:0) [NewlineAtEndOfFile] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-330) Add taglist-maven-plugin
Arturo Bernal created FILEUPLOAD-330:
Summary: Add taglist-maven-plugin
Key: FILEUPLOAD-330
URL: https://issues.apache.org/jira/browse/FILEUPLOAD-330
Project: Commons FileUpload
Issue Type: Improvement
Reporter: Arturo Bernal
The Taglist Maven Plugin generates a report on various tags found in the code,
like \{{@todo}} or \{{//TODO}} tags.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-328) Switch from Cobertura code coverage to Jacoco code coverage as all commons projects
[
https://issues.apache.org/jira/browse/FILEUPLOAD-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal resolved FILEUPLOAD-328.
--
Resolution: Fixed
in master
> Switch from Cobertura code coverage to Jacoco code coverage as all commons
> projects
> ---
>
> Key: FILEUPLOAD-328
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-328
> Project: Commons FileUpload
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Major
>
>
> Move the file `src/site/resources/profile.cobertura` to
> `src/site/resources/profile.jacoco` to do this.
>
>
> Errors:
>
> {code:java}
> ParseException in STDINParseException in STDINLast useful checkpoint:
> "org.apache.commons.fileupload2.FileUploadBase.parseParameterMap(RequestContext)"Encountered
> " ">" "> "" at line 389, column 81.Was expecting one of: "assert" ...
> "boolean" ... "byte" ... "char" ... "double" ... "enum" ...
> "false" ... "float" ... "int" ... "long" ... "new" ... "null"
> ... "short" ... "super" ... "this" ... "true" ... "void" ...
> ... ...
> ... ... ... "(" ... "!" ... "~"
> ... "++" ... "--" ... "+" ... "-" ...[WARN] JavaNCSS got an error
> while parsing the java file
> /Users/abernal/IdeaProyect/commons-fileupload/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.javaParseException
> in STDINLast useful checkpoint:
> "org.apache.commons.fileupload2.util.FileItemHeadersImpl.addHeader(String,String)"Encountered
> " ">" "> "" at line 90, column 95.Was expecting one of: "assert" ...
> "boolean" ... "byte" ... "char" ... "double" ... "enum" ...
> "false" ... "float" ... "int" ... "long" ... "new" ... "null"
> ... "short" ... "super" ... "this" ... "true" ... "void" ...
> ... ...
> ... ... ... "(" ... "!" ... "~"
> ... "++" ... "--" ... "+" ... "-" ...[INFO] Data file does not
> contain instrumentation information for the file
> org/apache/commons/fileupload2/FileItem.java. Ensure this class was
> instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/FileItemFactory.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/FileItemHeaders.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/FileItemHeadersSupport.java. Ensure
> this class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/FileItemIterator.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/FileItemStream.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/ProgressListener.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/RequestContext.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/UploadContext.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.[INFO] Data file does not contain instrumentation information for
> the file org/apache/commons/fileupload2/util/Closeable.java. Ensure this
> class was instrumented, and this data file contains the instrumentation
> information.Report time: 360ms
> [ERROR] net.sourceforge.cobertura.javancss.parser.ParseException: Encountered
> " ">" "> "" at line 389, column 81.Was expecting one of: "assert" ...
> "boolean" ... "byte" ... "char" ... "double" ... "enum" ...
> "false" ... "float" ... "int" ... "long" ... "new" ... "null"
> ... "short" ... "super" ... "this" ... "true" ... "void" ...
> ... ...
> ...
[jira] [Updated] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml config file
[ https://issues.apache.org/jira/browse/FILEUPLOAD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-329: - Summary: Fix multiples errors fileupload_checks.xml config file (was: Fix multiples errors fileupload_checks.xml ) > Fix multiples errors fileupload_checks.xml config file > -- > > Key: FILEUPLOAD-329 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > We need to update / fix some problems/error in the fileupload_checks.xml > files. All of them are because the libs and the config was updated > > > SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as > a child in Checker --> Make SuppressionCommentFilter and > SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur > [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > > cannot initialize module TreeWalker - Property 'cacheFile' does not exist, > please check the documentation --> > [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field > from TreeWalker in Checkstyle 8.0. Author: rnveach > [#2883|https://github.com/checkstyle/checkstyle/issues/2883] > > module TreeWalker - cannot initialize module FileContentsHolder --> > [https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowUndeclaredRTE' --> > [https://github.com/jeremylong/DependencyCheck/issues/2492] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowThrowsTagsForSubclasses' --> > https://github.com/checkstyle/checkstyle/issues/7329 > > TreeWalker is not allowed as a parent of LineLength --> > https://github.com/checkstyle/checkstyle/issues/473 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml
[ https://issues.apache.org/jira/browse/FILEUPLOAD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-329: - Description: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as a child in Checker --> Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur [#4714|https://github.com/checkstyle/checkstyle/issues/4714] cannot initialize module TreeWalker - Property 'cacheFile' does not exist, please check the documentation --> [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field from TreeWalker in Checkstyle 8.0. Author: rnveach [#2883|https://github.com/checkstyle/checkstyle/issues/2883] module TreeWalker - cannot initialize module FileContentsHolder --> [https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595] TreeWalker - cannot initialize module JavadocMethod - Property 'allowUndeclaredRTE' --> [https://github.com/jeremylong/DependencyCheck/issues/2492] TreeWalker - cannot initialize module JavadocMethod - Property 'allowThrowsTagsForSubclasses' --> https://github.com/checkstyle/checkstyle/issues/7329 TreeWalker is not allowed as a parent of LineLength --> https://github.com/checkstyle/checkstyle/issues/473 was: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as a child in Checker --> Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur [#4714|https://github.com/checkstyle/checkstyle/issues/4714] cannot initialize module TreeWalker - Property 'cacheFile' does not exist, please check the documentation --> [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field from TreeWalker in Checkstyle 8.0. Author: rnveach [#2883|https://github.com/checkstyle/checkstyle/issues/2883] module TreeWalker - cannot initialize module FileContentsHolder --> https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595 TreeWalker - cannot initialize module JavadocMethod - Property 'allowUndeclaredRTE' --> https://github.com/jeremylong/DependencyCheck/issues/2492 > Fix multiples errors fileupload_checks.xml > --- > > Key: FILEUPLOAD-329 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > We need to update / fix some problems/error in the fileupload_checks.xml > files. All of them are because the libs and the config was updated > > > SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as > a child in Checker --> Make SuppressionCommentFilter and > SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur > [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > > cannot initialize module TreeWalker - Property 'cacheFile' does not exist, > please check the documentation --> > [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field > from TreeWalker in Checkstyle 8.0. Author: rnveach > [#2883|https://github.com/checkstyle/checkstyle/issues/2883] > > module TreeWalker - cannot initialize module FileContentsHolder --> > [https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowUndeclaredRTE' --> > [https://github.com/jeremylong/DependencyCheck/issues/2492] > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowThrowsTagsForSubclasses' --> > https://github.com/checkstyle/checkstyle/issues/7329 > > TreeWalker is not allowed as a parent of LineLength --> > https://github.com/checkstyle/checkstyle/issues/473 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml
[ https://issues.apache.org/jira/browse/FILEUPLOAD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-329: - Description: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as a child in Checker --> Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur [#4714|https://github.com/checkstyle/checkstyle/issues/4714] cannot initialize module TreeWalker - Property 'cacheFile' does not exist, please check the documentation --> [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field from TreeWalker in Checkstyle 8.0. Author: rnveach [#2883|https://github.com/checkstyle/checkstyle/issues/2883] module TreeWalker - cannot initialize module FileContentsHolder --> https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595 TreeWalker - cannot initialize module JavadocMethod - Property 'allowUndeclaredRTE' --> https://github.com/jeremylong/DependencyCheck/issues/2492 was: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as a child in Checker --> Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > Fix multiples errors fileupload_checks.xml > --- > > Key: FILEUPLOAD-329 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > We need to update / fix some problems/error in the fileupload_checks.xml > files. All of them are because the libs and the config was updated > > > SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as > a child in Checker --> Make SuppressionCommentFilter and > SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur > [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > > cannot initialize module TreeWalker - Property 'cacheFile' does not exist, > please check the documentation --> > [https://checkstyle.org/releasenotes.html#Release_8.19] Remove `cache` field > from TreeWalker in Checkstyle 8.0. Author: rnveach > [#2883|https://github.com/checkstyle/checkstyle/issues/2883] > > module TreeWalker - cannot initialize module FileContentsHolder --> > https://github.com/checkstyle/checkstyle/issues/3573#issue-191385595 > > TreeWalker - cannot initialize module JavadocMethod - Property > 'allowUndeclaredRTE' --> > https://github.com/jeremylong/DependencyCheck/issues/2492 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml
[ https://issues.apache.org/jira/browse/FILEUPLOAD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-329: - Description: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as a child in Checker --> Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur [#4714|https://github.com/checkstyle/checkstyle/issues/4714] was: We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated > Fix multiples errors fileupload_checks.xml > --- > > Key: FILEUPLOAD-329 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > > We need to update / fix some problems/error in the fileupload_checks.xml > files. All of them are because the libs and the config was updated > > > SuppressWithNearbyCommentFilter / SuppressionCommentFilter is not allowed as > a child in Checker --> Make SuppressionCommentFilter and > SuppressWithNearbyCommentFilter children of TreeWalker. Author: Timur > [#4714|https://github.com/checkstyle/checkstyle/issues/4714] > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-329) Fix multiples errors fileupload_checks.xml
Arturo Bernal created FILEUPLOAD-329: Summary: Fix multiples errors fileupload_checks.xml Key: FILEUPLOAD-329 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-329 Project: Commons FileUpload Issue Type: Bug Reporter: Arturo Bernal We need to update / fix some problems/error in the fileupload_checks.xml files. All of them are because the libs and the config was updated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-328) Switch from Cobertura code coverage to Jacoco code coverage as all commons projects
Arturo Bernal created FILEUPLOAD-328:
Summary: Switch from Cobertura code coverage to Jacoco code
coverage as all commons projects
Key: FILEUPLOAD-328
URL: https://issues.apache.org/jira/browse/FILEUPLOAD-328
Project: Commons FileUpload
Issue Type: Improvement
Reporter: Arturo Bernal
Move the file `src/site/resources/profile.cobertura` to
`src/site/resources/profile.jacoco` to do this.
Errors:
{code:java}
ParseException in STDINParseException in STDINLast useful checkpoint:
"org.apache.commons.fileupload2.FileUploadBase.parseParameterMap(RequestContext)"Encountered
" ">" "> "" at line 389, column 81.Was expecting one of: "assert" ...
"boolean" ... "byte" ... "char" ... "double" ... "enum" ...
"false" ... "float" ... "int" ... "long" ... "new" ... "null"
... "short" ... "super" ... "this" ... "true" ... "void" ...
... ...
... ... ... "(" ... "!" ... "~"
... "++" ... "--" ... "+" ... "-" ...[WARN] JavaNCSS got an error
while parsing the java file
/Users/abernal/IdeaProyect/commons-fileupload/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.javaParseException
in STDINLast useful checkpoint:
"org.apache.commons.fileupload2.util.FileItemHeadersImpl.addHeader(String,String)"Encountered
" ">" "> "" at line 90, column 95.Was expecting one of: "assert" ...
"boolean" ... "byte" ... "char" ... "double" ... "enum" ...
"false" ... "float" ... "int" ... "long" ... "new" ... "null"
... "short" ... "super" ... "this" ... "true" ... "void" ...
... ...
... ... ... "(" ... "!" ... "~"
... "++" ... "--" ... "+" ... "-" ...[INFO] Data file does not
contain instrumentation information for the file
org/apache/commons/fileupload2/FileItem.java. Ensure this class was
instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/FileItemFactory.java. Ensure this
class was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/FileItemHeaders.java. Ensure this
class was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/FileItemHeadersSupport.java. Ensure
this class was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/FileItemIterator.java. Ensure this
class was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/FileItemStream.java. Ensure this class
was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/ProgressListener.java. Ensure this
class was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/RequestContext.java. Ensure this class
was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/UploadContext.java. Ensure this class
was instrumented, and this data file contains the instrumentation
information.[INFO] Data file does not contain instrumentation information for
the file org/apache/commons/fileupload2/util/Closeable.java. Ensure this class
was instrumented, and this data file contains the instrumentation
information.Report time: 360ms
[ERROR] net.sourceforge.cobertura.javancss.parser.ParseException: Encountered "
">" "> "" at line 389, column 81.Was expecting one of: "assert" ...
"boolean" ... "byte" ... "char" ... "double" ... "enum" ...
"false" ... "float" ... "int" ... "long" ... "new" ... "null"
... "short" ... "super" ... "this" ... "true" ... "void" ...
... ...
... ... ... "(" ... "!" ... "~"
... "++" ... "--" ... "+" ... "-" ...
at
net.sourceforge.cobertura.javancss.parser.JavaParser.generateParseException(JavaParser.java:10490)
at
net.sourceforge.cobertura.javancss.parser.JavaParser.jj_consume_token(JavaParser.java:10366)
at
net.sourceforge.cobertura.javancss.parser.JavaParser.UnaryExpression(JavaParser.java:3175)
at
[jira] [Closed] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
[
https://issues.apache.org/jira/browse/FILEUPLOAD-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal closed FILEUPLOAD-324.
Resolution: Won't Fix
won't do
> Use java9 profile on JDK 9 and later
>
>
> Key: FILEUPLOAD-324
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The idea its use java9 profile on JDK 9 and later
> basicity adding
> {code:java}
> java9+
>
>[9,) --> First change here
>
> {code}
> I am going to take advantage of the same tour to add profiles to support java
> 13 and 15
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-327) Solve SpotBug warning/errors
[ https://issues.apache.org/jira/browse/FILEUPLOAD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-327: - Description: This Jira it's to solve the following error/warnings: * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) * EI_EXPOSE_REP2 --> EI2: May expose internal representation by incorporating reference to mutable object (EI_EXPOSE_REP2) * EI_EXPOSE_REP --> EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP) was: This Jira it's to solve the following error/warnings: * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) * EI_EXPOSE_REP2 --> h3. EI2: May expose internal representation by incorporating reference to mutable object (EI_EXPOSE_REP2) * EI_EXPOSE_REP --> h3. EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP) > Solve SpotBug warning/errors > > > Key: FILEUPLOAD-327 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-327 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This Jira it's to solve the following error/warnings: > > * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) > * EI_EXPOSE_REP2 --> EI2: May expose internal representation by > incorporating reference to mutable object (EI_EXPOSE_REP2) > * EI_EXPOSE_REP --> EI: May expose internal representation by returning > reference to mutable object (EI_EXPOSE_REP) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-327) Solve SpotBug warning/errors
[ https://issues.apache.org/jira/browse/FILEUPLOAD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-327: - Description: This Jira it's to solve the following error/warnings: * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) * EI_EXPOSE_REP2 --> h3. EI2: May expose internal representation by incorporating reference to mutable object (EI_EXPOSE_REP2) * EI_EXPOSE_REP --> h3. EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP) was: Solve: * MS_PKGPROTECT * EI_EXPOSE_REP2 * EI_EXPOSE_REP > Solve SpotBug warning/errors > > > Key: FILEUPLOAD-327 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-327 > Project: Commons FileUpload > Issue Type: Bug >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This Jira it's to solve the following error/warnings: > > * MS_PKGPROTECT -->MS: Field should be package protected (MS_PKGPROTECT) > * EI_EXPOSE_REP2 --> > h3. EI2: May expose internal representation by incorporating reference to > mutable object (EI_EXPOSE_REP2) > * EI_EXPOSE_REP --> > h3. EI: May expose internal representation by returning reference to mutable > object (EI_EXPOSE_REP) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-327) Solve SpotBug warning/errors
Arturo Bernal created FILEUPLOAD-327: Summary: Solve SpotBug warning/errors Key: FILEUPLOAD-327 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-327 Project: Commons FileUpload Issue Type: Bug Reporter: Arturo Bernal Solve: * MS_PKGPROTECT * EI_EXPOSE_REP2 * EI_EXPOSE_REP -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-326) Simplify Assertion
Arturo Bernal created FILEUPLOAD-326: Summary: Simplify Assertion Key: FILEUPLOAD-326 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-326 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-325) Remove Unused Assignment
Arturo Bernal created FILEUPLOAD-325: Summary: Remove Unused Assignment Key: FILEUPLOAD-325 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-325 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal The assigned value is always overwritten by other assignments before the next read of the variable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved FILEUPLOAD-312. -- Resolution: Fixed Im Master > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-318) Use try with resource
[ https://issues.apache.org/jira/browse/FILEUPLOAD-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved FILEUPLOAD-318. -- Resolution: Fixed In Master > Use try with resource > -- > > Key: FILEUPLOAD-318 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-318 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Try to use Try with resource in order to avoid deprecated method > IOUtils.closeQuietly > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
[
https://issues.apache.org/jira/browse/FILEUPLOAD-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated FILEUPLOAD-324:
-
Description:
The idea its use java9 profile on JDK 9 and later
basicity adding
{code:java}
java9+
[9,) --> First change here
{code}
I am going to take advantage of the same tour to add profiles to support java
13 and 15
was:
The idea its use java9 profile on JDK 9 and later
basicity adding
{code:java}
[9,)
{code}
I am going to take advantage of the same tour to add profiles to support java
13 and 15
> Use java9 profile on JDK 9 and later
>
>
> Key: FILEUPLOAD-324
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
>
> The idea its use java9 profile on JDK 9 and later
> basicity adding
> {code:java}
> java9+
>
>[9,) --> First change here
>
> {code}
> I am going to take advantage of the same tour to add profiles to support java
> 13 and 15
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
[
https://issues.apache.org/jira/browse/FILEUPLOAD-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated FILEUPLOAD-324:
-
Description:
The idea its use java9 profile on JDK 9 and later
basicity adding
{code:java}
[9,)
{code}
I am going to take advantage of the same tour to add profiles to support java
13 and 15
> Use java9 profile on JDK 9 and later
>
>
> Key: FILEUPLOAD-324
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
>
> The idea its use java9 profile on JDK 9 and later
> basicity adding
> {code:java}
>
>
>[9,)
>
>
> {code}
> I am going to take advantage of the same tour to add profiles to support java
> 13 and 15
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
Arturo Bernal created FILEUPLOAD-324: Summary: Use java9 profile on JDK 9 and later Key: FILEUPLOAD-324 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324 Project: Commons FileUpload Issue Type: New Feature Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-287) Multipart/mixed parts not handled correctly
[
https://issues.apache.org/jira/browse/FILEUPLOAD-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337496#comment-17337496
]
Arturo Bernal commented on FILEUPLOAD-287:
--
HI [~joesephz]
Could you please provide a unit test where is reproduced in order to to
analyze it?
TY
> Multipart/mixed parts not handled correctly
> ---
>
> Key: FILEUPLOAD-287
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-287
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.3.3
>Reporter: Etienne Dethoor
>Priority: Critical
>
> If i submit a request with global header
> {{Content-Type="multipart/mixed;boundary="uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f";charset=UTF-8"}}
> data to a servlet with :
> {code:xml}
> --uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f
> Content-Type: text/plain
> Content-Transfer-Encoding: binary
> Content-ID: myFile
> My_Content_Here
> --uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f
> Content-Type: application/xml
> Content-Transfer-Encoding: binary
> Content-ID: myOtherFileHere
> M_Other_Content_Here
> {code}
> The differents parts are not recognized because of
> {{FileUploadBase.getFieldName()}} method who want a {{Content-Disposition}}
> header for each part of the request.
> The [rfc|https://tools.ietf.org/html/rfc7578#section-4.2] specified that this
> header is mandatory for the {{multipart/form-data}} content-type.
> For the {{multipart/mixed}}, if i well understand, the rfc doesn't say this
> header is mandatory for each parts of the request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal closed FILEUPLOAD-323.
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal resolved FILEUPLOAD-323.
--
Resolution: Fixed
In master
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated FILEUPLOAD-323:
-
Summary: Implement spotbugs (was: Use spotbugs as in commons-lang now)
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-323) Use spotbugs as in commons-lang now
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated FILEUPLOAD-323:
-
Description:
The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
This Jira it's for keep track and work in the implementations
Need to check:
{code:java}
[INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
[ERROR] High: Found reliance on default encoding in
org.apache.commons.fileupload2.MultipartStream.readHeaders():
java.io.ByteArrayOutputStream.toString()
[org.apache.commons.fileupload2.MultipartStream,
org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
[ERROR] Medium: org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX
should be package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
may expose internal representation by storing an externally mutable object into
ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser] At
ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found reliance on
default encoding in
org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
representation by returning DiskFileItem.cachedContent
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
java.io.File.delete() ignored in
org.apache.commons.fileupload2.disk.DiskFileItem.delete()
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
value of java.io.File.delete() ignored in
org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
doesn't override method in superclass because parameter type
jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter type
javax.servlet.http.HttpServletRequest
[org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
reliance on default encoding in
org.apache.commons.fileupload2.util.Streams.asString(InputStream):
java.io.ByteArrayOutputStream.toString()
[org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
DM_DEFAULT_ENCODING
{code}
was:
The idea it's use spotbugs in a intend of find or prevents bugs in Java code
Need to check:
{code:java}
[INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
[ERROR] High: Found reliance on default encoding in
org.apache.commons.fileupload2.MultipartStream.readHeaders():
java.io.ByteArrayOutputStream.toString()
[org.apache.commons.fileupload2.MultipartStream,
org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
[ERROR] Medium: org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX
should be package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
package protected [org.apache.commons.fileupload2.MultipartStre
[jira] [Updated] (FILEUPLOAD-323) Use spotbugs as in commons-lang now
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated FILEUPLOAD-323:
-
Description:
The idea it's use spotbugs in a intend of find or prevents bugs in Java code
Need to check:
{code:java}
[INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
[ERROR] High: Found reliance on default encoding in
org.apache.commons.fileupload2.MultipartStream.readHeaders():
java.io.ByteArrayOutputStream.toString()
[org.apache.commons.fileupload2.MultipartStream,
org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
[ERROR] Medium: org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX
should be package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
package protected [org.apache.commons.fileupload2.MultipartStream] At
MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
may expose internal representation by storing an externally mutable object into
ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser] At
ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found reliance on
default encoding in
org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
representation by returning DiskFileItem.cachedContent
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
java.io.File.delete() ignored in
org.apache.commons.fileupload2.disk.DiskFileItem.delete()
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
value of java.io.File.delete() ignored in
org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
[org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
doesn't override method in superclass because parameter type
jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter type
javax.servlet.http.HttpServletRequest
[org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
reliance on default encoding in
org.apache.commons.fileupload2.util.Streams.asString(InputStream):
java.io.ByteArrayOutputStream.toString()
[org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
DM_DEFAULT_ENCODING
{code}
was:The idea it's use spotbugs in a intend of find or prevents bugs in Java
code
> Use spotbugs as in commons-lang now
> ---
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
>
> The idea it's use spotbugs in a intend of find or prevents bugs in Java code
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[li
[jira] [Created] (FILEUPLOAD-323) Use spotbugs as in commons-lang now
Arturo Bernal created FILEUPLOAD-323: Summary: Use spotbugs as in commons-lang now Key: FILEUPLOAD-323 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323 Project: Commons FileUpload Issue Type: New Feature Reporter: Arturo Bernal The idea it's use spotbugs in a intend of find or prevents bugs in Java code -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (EXEC-119) Simplify assertion
Arturo Bernal created EXEC-119: -- Summary: Simplify assertion Key: EXEC-119 URL: https://issues.apache.org/jira/browse/EXEC-119 Project: Commons Exec Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (EXEC-118) Declaration Improvements
Arturo Bernal created EXEC-118: -- Summary: Declaration Improvements Key: EXEC-118 URL: https://issues.apache.org/jira/browse/EXEC-118 Project: Commons Exec Issue Type: Sub-task Reporter: Arturo Bernal * Add final * Remove Duplicate throws -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (EXEC-117) Control flow Improvements
Arturo Bernal created EXEC-117: -- Summary: Control flow Improvements Key: EXEC-117 URL: https://issues.apache.org/jira/browse/EXEC-117 Project: Commons Exec Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (EXEC-116) java8 improvements
Arturo Bernal created EXEC-116: -- Summary: java8 improvements Key: EXEC-116 URL: https://issues.apache.org/jira/browse/EXEC-116 Project: Commons Exec Issue Type: Sub-task Reporter: Arturo Bernal * Replace Anonymous type with lambda * Replace Lambda with method reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (EXEC-115) Minor improvements
[ https://issues.apache.org/jira/browse/EXEC-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated EXEC-115: --- Summary: Minor improvements (was: Minor improvements :) > Minor improvements > -- > > Key: EXEC-115 > URL: https://issues.apache.org/jira/browse/EXEC-115 > Project: Commons Exec > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
