[jira] [Issue Comment Edited] (CSV-71) Add convenience Methods to CSVLexer
[ https://issues.apache.org/jira/browse/CSV-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231415#comment-13231415 ] Benedikt Ritter edited comment on CSV-71 at 3/16/12 5:36 PM: - On my machine the performance tests takes around 5 secs. I get the following results: || ||min||max||avg|| | before | 5103 | 5260 | 5170 | | after | 5091 | 5238 | 5142 | At least on my machine there is no negative impact. I ran the test with VM param -server. I'm using {{Java version: 1.7.0_01, vendor: Oracle Corporation}} was (Author: britter): On the performance tests takes around 5 secs. I get the following results: || ||min||max||avg|| | before | 5103 | 5260 | 5170 | | after | 5091 | 5238 | 5142 | At least on my machine there is no negative impact. I ran the test with VM param -server. I'm using {{Java version: 1.7.0_01, vendor: Oracle Corporation}} Add convenience Methods to CSVLexer --- Key: CSV-71 URL: https://issues.apache.org/jira/browse/CSV-71 Project: Commons CSV Issue Type: Sub-task Components: Parser Affects Versions: 1.0 Reporter: Benedikt Ritter Fix For: 1.0 Attachments: CSV-71.patch Add {{isDelimiter(c)}} and {{isEncapsulator(c)}} to CSVLexer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SANDBOX-397) [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions
[ https://issues.apache.org/jira/browse/SANDBOX-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216947#comment-13216947 ] Benedikt Ritter edited comment on SANDBOX-397 at 2/26/12 9:59 PM: -- I've thought about the {{Properties}} class some more and I think, that it is the right thing to do. So I've created a patch for SANDBOX-399 that will fix the problems that {{Properties}} caused. I've done some more clean up and I was able to eliminate the dependency between {{DefaultBeanAccessor}} and {{PropertiesRegistry}}. {{PropertiesRegistry}} is on a lower abstraction level than {{DefautlBeanAccessor}} so I think that is a good thing :) If SANDBOX-399 is applied first, all test will pass when SANDBOX-397-SRPv2.txt is applied. Regards, Benedikt was (Author: britter): I've thought about the {{Properties}} class some more and I think, that it is the right thing to do. So I've created a patch for SANDBOX-399 that will fix the problems that {{Properties}} caused. I've done some more clean up and I was able to eliminate the dependency between {{DefaultBeanAccessor}} and {{PropertiesRegistry}}. {{PropertiesRegistry}} is on a lower abstraction level than {{DefautlBeanAccessor}} so I think that is a good thing :) If SANDBOX-399 is applied first, all test will pass when SANDBOX-398-SRPv2.txt is applied. Regards, Benedikt [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions Key: SANDBOX-397 URL: https://issues.apache.org/jira/browse/SANDBOX-397 Project: Commons Sandbox Issue Type: Task Components: BeanUtils2 Affects Versions: Nightly Builds Reporter: Benedikt Ritter Attachments: SANDBOX-397.txt, SANDBOX-397_SRP.txt, SANDBOX-397_SRPv2.txt At the moment, methods in {{DefaultBeanAccessor}} throw a {{NullPointerException}}, if no {{PropertyDescriptor}} for a given property name can be retrieved. As discussed on the ML (see http://markmail.org/thread/zlehclmybp5xgn5n) this behavior should be changed to throwing {{NoSuchMethodException}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SANDBOX-389) [BeanUtils2] Implement populate() on DefaultBeanAccessor
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205386#comment-13205386 ] Benedikt Ritter edited comment on SANDBOX-389 at 2/10/12 12:13 PM: --- I finally got the time to review and fix my patch. I re-implemented {{equals()}} on {{TestBean}} using commons lang 3. Commons lang 3.1 has been added as a dependency in test scope to pom.xml. Now everything should be fine with {{populate()}}. Regards, Benedikt was (Author: britter): I finally got the time to review and fix my patch. I re-implemented {{equals()}} on {{TestBean}} using commons lang 3. Commons lang 3.1 has been added as a dependency in test scope to pom.xml. Now everything should be fine with {{populate}()}. Regards, Benedikt [BeanUtils2] Implement populate() on DefaultBeanAccessor - Key: SANDBOX-389 URL: https://issues.apache.org/jira/browse/SANDBOX-389 Project: Commons Sandbox Issue Type: Improvement Components: BeanUtils2 Affects Versions: Nightly Builds Reporter: Benedikt Ritter Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SANDBOX-362) Create basic unit tests for all classes
[ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191495#comment-13191495 ] Benedikt Ritter edited comment on SANDBOX-362 at 1/23/12 9:43 PM: -- Based on a discussion we had on the mailing list about best practices for unit tests, I refactored ArgumentTest and added test methods for getParamaters(Argument?... args). Here is a summary of what I changed: * separated long methods into very small methods: each primitive type has it's own test methods * defined fields for every primitive type, to make sure that assertions do not accedential fail because wrong values get compared * created separate test methods instead of wrapping failure cases inside try/catch-blocks * Added tests methods that test against TestBean.class Please let me know, what you think about the changes! was (Author: britter): Based on a discussion we had on the mailing list about best practices for unit tests, I refactored ArgumentTest and added test methods for getParamaters(Argument?... args). Here is a summary of what I changed: * separated long methods into very small methods: each primitive type has it's own test methods * defined fields for every primitive type, to make sure that assertions do not accedential fail because wrong values get compared * Added tests methods that test against TestBean.class Please let me know, what you think about the changes! Create basic unit tests for all classes --- Key: SANDBOX-362 URL: https://issues.apache.org/jira/browse/SANDBOX-362 Project: Commons Sandbox Issue Type: Test Components: BeanUtils2 Affects Versions: Nightly Builds Reporter: Benedikt Ritter Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt Back up all existing implementations with unit tests: * Argument * Assertions * BeanUtils * DefaultBeanAccessor * DefaultClassAccessor * MethodRegistry * TypeUtils -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira