[jira] [Commented] (MATH-1502) KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug
[ https://issues.apache.org/jira/browse/MATH-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963487#comment-16963487 ] Ethan Mahintorabi commented on MATH-1502: - That makes sense. I'm not too familiar with the KolmogorovSmirnovTest; when I was upgrading math3 from 3.4.1 -> 3.6.1 one of our unit tests broke that asserted the value of the above function should be 0.6. If this is just a matter a semi-discontinuity that makes sense it just gave me a scare that value changed so sharply. So just to be clear this is not a bug. If so I'll update the unit tests when performing the next update > KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug > -- > > Key: MATH-1502 > URL: https://issues.apache.org/jira/browse/MATH-1502 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6.1 >Reporter: Ethan Mahintorabi >Priority: Critical > Attachments: exact_vs_approximate.png > > > I believe that I have found a bug in the calculation of the exactP value in > KolmogorovSmirnovTest.java in version 3.6.1. > > In version 3.4.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) > = 0.6 > > Where as > > In version 3.6.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) > = 0.09998 > > > The approximateP value has stayed the same at ~=0.72. This seems to > correspond with the change in methods of calculation in > e38bbb9f4191d0d21dea0ba31fdc131b97a5597b > > [https://github.com/apache/commons-math/commit/e38bbb9f4191d0d21dea0ba31fdc131b97a5597b#diff-34100572fcc8e6537bc7445a0e82b900] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1502) KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug
[ https://issues.apache.org/jira/browse/MATH-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Mahintorabi updated MATH-1502: Priority: Critical (was: Major) > KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug > -- > > Key: MATH-1502 > URL: https://issues.apache.org/jira/browse/MATH-1502 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6.1 >Reporter: Ethan Mahintorabi >Priority: Critical > > I believe that I have found a bug in the calculation of the exactP value in > KolmogorovSmirnovTest.java in version 3.6.1. > > In version 3.4.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) > = 0.6 > > Where as > > In version 3.6.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) > = 0.09998 > > > The approximateP value has stayed the same at ~=0.72. This seems to > correspond with the change in methods of calculation in > e38bbb9f4191d0d21dea0ba31fdc131b97a5597b > > [https://github.com/apache/commons-math/commit/e38bbb9f4191d0d21dea0ba31fdc131b97a5597b#diff-34100572fcc8e6537bc7445a0e82b900] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1502) KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug
Ethan Mahintorabi created MATH-1502: --- Summary: KolmogorovSmirnovTest#exactP value is incorrect in 3.6.1 potential bug Key: MATH-1502 URL: https://issues.apache.org/jira/browse/MATH-1502 Project: Commons Math Issue Type: Bug Affects Versions: 3.6.1 Reporter: Ethan Mahintorabi I believe that I have found a bug in the calculation of the exactP value in KolmogorovSmirnovTest.java in version 3.6.1. In version 3.4.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) = 0.6 Where as In version 3.6.1 KolmogorovSmirnovTest#exactP(0.5633587786259542, 3, 3, true) = 0.09998 The approximateP value has stayed the same at ~=0.72. This seems to correspond with the change in methods of calculation in e38bbb9f4191d0d21dea0ba31fdc131b97a5597b [https://github.com/apache/commons-math/commit/e38bbb9f4191d0d21dea0ba31fdc131b97a5597b#diff-34100572fcc8e6537bc7445a0e82b900] -- This message was sent by Atlassian Jira (v8.3.4#803005)
