[jira] [Commented] (SANDBOX-411) Implement a new version of ConcurrentGraph
[ https://issues.apache.org/jira/browse/SANDBOX-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224695#comment-13224695 ] Marco Speranza commented on SANDBOX-411: The implementation can use the Read/Write locks. A typical scenario could be the execution of different algorithms in a multi-threading environment. The main problem is ensure that the algorithm is executed into a critical-section in order to avoid a possible graph modification. > Implement a new version of ConcurrentGraph > -- > > Key: SANDBOX-411 > URL: https://issues.apache.org/jira/browse/SANDBOX-411 > Project: Commons Sandbox > Issue Type: Sub-task > Components: Graph >Reporter: Marco Speranza >Priority: Minor > > As widely discussed in ML it's convenient create a new package 'concurrent' > and create a parallel implementation on ConcurrentGraph. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-352) Provide Cheriyan-Mehlhorn/Gabow's strongly connected component algorithm implementation
[ https://issues.apache.org/jira/browse/SANDBOX-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224104#comment-13224104 ] Marco Speranza commented on SANDBOX-352: Hi Simo, yes you are right. the system.out it was a my fault. And I apologize I tought that a little refactoring could be included into the same issue. Next time I'll be more efficent ;) Of course I agree your improvemet! :) > Provide Cheriyan-Mehlhorn/Gabow's strongly connected component algorithm > implementation > --- > > Key: SANDBOX-352 > URL: https://issues.apache.org/jira/browse/SANDBOX-352 > Project: Commons Sandbox > Issue Type: Sub-task >Reporter: Simone Tripodi >Assignee: Marco Speranza > > The {{CheriyanMehlhornGabow}} class contains and empty > [Cheriyan-Mehlhorn/Gabow|http://en.wikipedia.org/wiki/Cheriyan%E2%80%93Mehlhorn/Gabow_algorithm]'s > algorithm implementation that has to be filled -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[ https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211374#comment-13211374 ] Marco Speranza commented on SANDBOX-394: Ok Simo, so also {{boolean containsEdge( Edge e )}} could be a shortcut of {{getVertices( e )}} as well. If you agreed I'll proceed in this way Ciao > Check arguments > --- > > Key: SANDBOX-394 > URL: https://issues.apache.org/jira/browse/SANDBOX-394 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph >Reporter: Marco Speranza >Priority: Minor > > Add the assertion for classes *SourceSelector and check if the Vertex is > contained in the input Graph before selecting the algorithm to apply -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[ https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211354#comment-13211354 ] Marco Speranza commented on SANDBOX-394: Hi Simo, I agree with you. I have a little question: To implement these checks, would be useful add a new method to Graph interface, like boolean containsVertex( Vertex v ) and boolean containsEdge( Edge e ). It would be also useful make a refactoring (for example for the class BaseMutableGraph) and use that method instead use getAdjacencyList().containsKey( v ) to check that argument. In this case it's possible to use the methods in the Graph also in every chained method for every entry point. WDYT? > Check arguments > --- > > Key: SANDBOX-394 > URL: https://issues.apache.org/jira/browse/SANDBOX-394 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph >Reporter: Marco Speranza >Priority: Minor > > Add the assertion for classes *SourceSelector and check if the Vertex is > contained in the input Graph before selecting the algorithm to apply -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-391) removeEdge method: missing implementation
[ https://issues.apache.org/jira/browse/SANDBOX-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209789#comment-13209789 ] Marco Speranza commented on SANDBOX-391: Fixed on [r1245198|http://svn.apache.org/viewvc?view=revision&revision=1245198]. > removeEdge method: missing implementation > - > > Key: SANDBOX-391 > URL: https://issues.apache.org/jira/browse/SANDBOX-391 > Project: Commons Sandbox > Issue Type: Bug > Components: Graph >Reporter: Marco Speranza >Assignee: Marco Speranza > > In the {{BaseMutableGraph}} class the implementation of removeEdge method is > missing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-350) Provide a Reverse-delete algorithm implementation
[ https://issues.apache.org/jira/browse/SANDBOX-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194010#comment-13194010 ] Marco Speranza commented on SANDBOX-350: Hi, I attached an Reverse-delete implemenetation and a test case suite. Moreover I modified the DefaultSpanningTreeAlgorithmSelector class and I put it into commons.graph.model package the implementation of WeightedEdgesComparator. I am available for clarifications.. ciao ciao Marco > Provide a Reverse-delete algorithm implementation > - > > Key: SANDBOX-350 > URL: https://issues.apache.org/jira/browse/SANDBOX-350 > Project: Commons Sandbox > Issue Type: Sub-task > Components: Graph >Reporter: Simone Tripodi > Attachments: SANDBOX-350_Reverse_Delete_algo.patch > > > [Reverse-delete|http://en.wikipedia.org/wiki/Reverse-Delete_algorithm] > algorithm implementation is completely missing in > {{org.apache.commons.graph.spanning}} package -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira