[GitHub] commons-lang issue #262: Findbugs in Travis CI
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/262 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21808707 nice refactorings :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 Concerning the coverage: I think it's because the coverage differs between java versions. The build used to determine coverage depends on the order in which the travis builds finish. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #231: Evaluate Architecure
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 Well we have to keep `getMethodsWithAnnotation(cls, annotationCls)` for compatibility reasons. In my opinion it is not problem if is equal to `getMethodsWithAnnotation(cls, annotationCls, false, false)`. It can be refactored to call `getMethodsWithAnnotation(cls, annotationCls, false, false)` and then it is just some sugar for the most? common use case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 You are right. The method signature I suggested omits the important super part. I agree it should be something like `getMethodsWithAnnotation(Class cls, annotationCls, boolean searchSupers, boolean ignoreAccess)`. (I'm not a fan of boolean parameters (especially multiple ones), so if somebody has an idea for a good method name, that is welcome.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #231: Evaluate Architecure
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 @sebbASF What do you think about the latest changes? Is this pull request ready for merging? Thanks, Pascal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 Thanks for the pull request! It is really unfortunate that the existing method `getMethodsWithAnnotation` is not called `getAccessibleMethodsWithAnnotation` : (, because then the new method could be called `getMethodsWithAnnotation`. I would not have been able to tell the difference between `getMethodsWithAnnotation` and `findMethodsWithAnnotation` without reading the javadoc. I believe we need a more intention revealing method name or maybe we should just add an overload of `getMethodsWithAnnotation` e.g. `getMethodsWithAnnotation(Class cls, annotationCls, boolean ignoreAccessiblitiy)`. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #260: Fixed javadoc of MutableBoolean setTrue / setFalse
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/260 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #253: Added a restart method for convenience
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/253 Hi @esend7881 thanks for the pull request. I'm not sure it is a good idea to add at method that is nearly identical to `StopWatch#createStarted`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #256: fix for LANG-1310
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/256 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/257 Required changes seem reasonable. I think we should give this a try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #256: fix for LANG-1310
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/256#discussion_r106023700
--- Diff:
src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java ---
@@ -357,16 +369,23 @@ public void testInvokeMethod() throws Exception {
assertEquals("foo(int)", MethodUtils.invokeMethod(testBean, "foo",
NumberUtils.BYTE_ONE));
assertEquals("foo(double)", MethodUtils.invokeMethod(testBean,
"foo",
-NumberUtils.LONG_ONE));
-assertEquals("foo(double)", MethodUtils.invokeMethod(testBean,
"foo",
NumberUtils.DOUBLE_ONE));
assertEquals("foo(String...)", MethodUtils.invokeMethod(testBean,
"foo",
"a", "b", "c"));
assertEquals("foo(String...)", MethodUtils.invokeMethod(testBean,
"foo",
"a", "b", "c"));
assertEquals("foo(int, String...)",
MethodUtils.invokeMethod(testBean, "foo",
5, "a", "b", "c"));
-
+assertEquals("foo(long...)", MethodUtils.invokeMethod(testBean,
"foo",
+1L, 2L));
+
+try {
+MethodUtils.invokeMethod(testBean, "foo",
+1, 2);
+fail("should throw NoSuchMethodException");
+} catch (final NoSuchMethodException e) {
--- End diff --
In general I agree, but commons lang has a lot similar tests, so it's
o.k/more consistent with existing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #256: fix for LANG-1310
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/256 @drajakumar It's really great to get a pull request for this. :+1: I took a look at this issue some time ago, but gave up trying to solve it. Sadly I'm too tired for a review at the moment. I will get back to you in a few days, if nobody has reviewed/merged the pull request already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #254: Add checkstyle to the CI
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/254 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #255: LANG-1316: Deprecate classes/methods moved t...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/255 LANG-1316: Deprecate classes/methods moved to commons-text * org.apache.commons.lang3.text.translate - every class * org.apache.commons.lang3.text - every class beside WordUtils * StringEscapeUtils - whole class * StringUtils: getLevenshteinDistance, getFuzzyDistance and getJaroWinklerSimilarity methods * ObjectUtils: identityToString(final StrBuilder builder, final Object object) method (StrBuilder was moved to commons-text) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang deprecated_classes_methods_move_to_commons_text Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/255.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #255 commit 3140567b22c6e86aa92bb72186abb6a1a0179bab Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2017-03-12T13:53:40Z LANG-1316: Deprecate classes/methods moved to commons-text * org.apache.commons.lang3.text.translate - every class * org.apache.commons.lang3.text - every class beside WordUtils * StringEscapeUtils - whole class * StringUtils: getLevenshteinDistance, getFuzzyDistance and getJaroWinklerSimilarity methods * ObjectUtils: identityToString(final StrBuilder builder, final Object object) method (StrBuilder was moved to commons-text) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #254: Add checkstyle to the CI
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/254 I think that is normal lately. Seems like a lot of apache projects enabled travis recently and now apaches travis-ci capacity can not handle the load. Sometimes it takes a day until the build runs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #252: [LANG-1314] Fix javadoc creation on with Java 8
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/252 @mureinik Sorry it wasn't my intention to steal the authorship of your commits with the javadoc fixes. :( I wasn't aware that a `git rebase` changes the author. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #252: [LANG-1314] Fix javadoc creation on with Java 8
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/252 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #249: Checkstyle for long literals
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/249 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #248: Longs
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/248 +1 to adding the check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #248: Longs
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/248 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #246: DateUtilsTest asserts
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/246 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #245: Use foreach
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/245 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #245: Use foreach
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/245 For time to time there are discussion concerning the use of the for-each loop on the mailing list. (e.g. http://markmail.org/thread/wmedbgqmewmpiptk#query:+page:1+mid:gbo5cpywwfxl5p4w+state:results) As far as I remember the consensus was to use it only for arrays, because there it does not have any negative impact on performance. When used with iterables it has some impact on performance (because it requires the creation of an iterator). Therefore some contributors were against using it with iterables in a low level library like commons-lang. Most of your changes concern arrays, so if you remove the iterable parts I think this is safe to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #244: LANG-1265: Build failures when building with...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/244 LANG-1265: Build failures when building with Java 9 EA Fix build on Java 9 Build 157 by adding a java-9 maven profile. This is activated by default on Java 9 and opens up java.base classes for reflection which makes all unit tests pass. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang fix_build_on_java_9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #244 commit e0b8d45ac7d7f2f15d670298fe5e1d4762efbce2 Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2017-02-24T17:51:03Z LANG-1265: Build failures when building with Java 9 EA Fix build on Java 9 Build 157 by adding a java-9 maven profile. This is activated by default on Java 9 and opens up java.base classes for reflection which makes all unit tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #243: Fix JsonToStringStyleTest.NestingPerson javadoc
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/243 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #241: Fix spacing between enum constants
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/241 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #242: Fix FastDateParser#getStrategy(char, int, Calendar)...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/242 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 As far as I can tell @C0rWin updated the pull request 9 days ago (after your conversation). By the way merging this only makes sense if commons lang actually uses JHM. Do you (or somebody else) plan to work on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 I guess this is ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #240: Remove redundant semicolons from enums
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102281919
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13,
A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29,
A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45,
A46, A47,
-A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61,
A62, A63;
+A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61,
A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
-A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
I guess there should, but let's keep this pull request focused one one
thing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #231: Evaluate Architecure
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 jira issue: https://issues.apache.org/jira/browse/LANG-1313 I plan to merge this tomorrow (if there are no objections). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #238: Validate's String.format without arguments
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/238 Yes, lets keep the pull requests as is is. Sorry if I caused the impression of being overtly critical of this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #238: Validate's String.format without arguments
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/238 Yes, currently the user has to escape single `%`s in the error message with `%%`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #239: LANG-1312: LocaleUtils#toLocale does not support la...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/239 @kinow: Thanks for the review. :-) I also did not know about UN M.49 till yesterday. I just stumbled over this while analyzing commons-lang test failures on java 9 for https://issues.apache.org/jira/browse/LANG-1265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #239: LANG-1312: LocaleUtils#toLocale does not sup...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/239 LANG-1312: LocaleUtils#toLocale does not support language followed by⦠⦠UN M.49 numeric-3 area code You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang lang_1312_area_code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #239 commit ce3e3e03e4d561dfae565186b431a879a9afa920 Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2017-02-19T19:39:05Z LANG-1312: LocaleUtils#toLocale does not support language followed by UN M.49 numeric-3 area code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #238: Validate's String.format without arguments
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/238 Thanks for the pull request (and you other pull requests). This pull request actually slightly changes the behavior of the methods. There is at least one use for `String.format` without parameters: inserting platform specific line separators with `%n`. As the javadoc does not say that `String.format` is used on the message and I believe is is unlikely that somebody want would want platform specific line separators here I think we can still merge the pull request. But maybe somebody else disagrees? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #235: Remove redundant casts
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/235 Thanks! ð I restored the casts in `ArrayUtils#testGetLength` before merging, because otherwise these tests make no sense. (The test probably make no sense anyway, as you can cast to `Date` and the tests still pass.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #231: Evaluate Architecure
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 I think this is a worthy addition. In my experience people often do not read documentation. Maybe we should use `IS_32_BIT_JVM` so there can be no confusion? Or is this is too paranoid? What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 @martin-tarjanyi Sorry for the delay. :( I finally send a mail to the mailing list: https://mail-archives.apache.org/mod_mbox/commons-dev/201702.mbox/%3C13256228-1650-e98e-fe93-22801e530c88%40gmx.net%3E --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #231: Evaluate Architecure
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 The discussion mentioned by @kinow is here: https://issues.apache.org/jira/browse/LANG-1145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #233: Fix a few broken @literal tags
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/233 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #232: Fix a number of Javadoc typos
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/232 Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #230: Copy-paste error in testIsAsciiPrintable_char
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/230 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #229: Update RELEASE-NOTES.txt - typo "vom"
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/229 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #226: [LANG-1308] Move CvsTranslators out of StringEscape...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/226 Thanks for the pull request. ð StringEscapeUtils has been moved to commons-text and the commons-lang version will soon be deprecated. It would be nice if you would create a pull request for https://github.com/apache/commons-text instead. Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 On further consideration, there are already methods with are "simply the inverse of another method": `isEmpty/isNotEmpty`, `isAnyEmpty/isNoneEmpty`, `containsAny/containsNone`. I will start a discussion on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #224: [LANG-1306] Add nullToEmpty method in StringUtils
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/224 There is also `StringUtils.defaultString(final String str)` which has exactly the same functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #224: [LANG-1306] Add nullToEmpty method in StringUtils
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/224 Thanks for the pull request! :) The same behavior can be achieved with `ObjectUtils.defaultIfNull(str, "")`, but of course this new method reads much better, so I'm in favor of merging. Best as on the commons developer list (https://commons.apache.org/proper/commons-lang/mail-lists.html) if there are any objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #222: LANG-1303 : Escape HTML characters once
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/222 Thanks Sampanna! It would be nice if you would close this pull request. (I can not do it easily as this is a read-only repository.) Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #222: LANG-1303 : Escape HTML characters once
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/222 Thanks for the pull request. ð StringEscapeUtils was ported to commons-text and will soon deprecated in commons-lang. It would be nice if you could open a pull request at https://github.com/apache/commons-text Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 If only one method is added it should be `isAll*` instead of `isAnyNot*`. Since the `isAnyNot*` are not released yet, they can be removed. I personally would have no problem with adding both types of methods. Making client code more readable is imho enough to justify the addition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 I have created an jira issue for this: https://issues.apache.org/jira/browse/LANG-1293 and also asked for opinions on the empty/null array question there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 >I vote strongly for is* method naming. That's the convention for Java methods of this type, even if it slightly upsets the English ear. Then let's keep is* names. >Other topic: what do you think of the handling of empty array or null as a single parameter? Is it right to return true in these cases? I'm not sure what the behavior should be in these cases. @dmjones500 / anybody else: any opinions on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #221: Add IsAllEmpty and isAllBlank methods
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/221 Thanks for the pull request. :) I guess we better class theses methods `areAllEmpty`/`areAllBlank`. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #220: Fix javadoc for isAnyNotEmpty
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/220 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #208: LANG-1066: Add shell/XSI escape/unescape sup...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #208: LANG-1066: Add shell/XSI escape/unescape support
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/208 As discussed on the mailing list string escaping will move to commons-text, so I'm closing this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #213: LANG-1288: Add a builder to StringEscapeUtil...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #213: LANG-1288: Add a builder to StringEscapeUtils
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/213 As discussed on the mailing list string escaping will move to commons-text, so I'm closing this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 No problem. :) When I started contributing to Open Source and using git and github I also had a lot of questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 It's the same for the other commit, see: https://github.com/apache/commons-lang/commits/master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 Yes, the changes have been merged: 51b2cab I think the commit is marked as unmerged, because I changed the commit message. But you are still listed as the author, so I guess everything is ok? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #218: Fix/different annotations test
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/218 Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 Great find! ð Thanks for the detailed explanation. :) As this change is unrelated to improving the test coverage of ArrayUtils, it would be nice if you could move it to a separate commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/217 Thanks for the pull request! ð >fix an issue with not getting Annotation in AnnotaionUtilsTest Not sure what you fixed there. What is the reason of this change? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #215: Separate test cases by a new line.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/215 Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #210: LANG-1067: Add a reflection-based variant of DiffBu...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/210 https://github.com/apache/commons-lang/commit/011775551ef75d75f81189eb4604fd0f2ed424ba --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #210: LANG-1067: Add a reflection-based variant of...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #213: LANG-1288: Add a builder to StringEscapeUtil...
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88803456
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super();
}
+/**
+ * Convenience wrapper for {@link java.lang.StringBuilder}
providing escape methods.
+ *
+ * Example:
+ *
+ * new Builder(ESCAPE_HTML4)
+ * .append("p>")
+ * .escape("This is paragraph 1 and special chars like get
escaped.")
+ * .append("/p>p>")
+ * .escape("This is paragraph 2 more...")
+ * .append("/p>")
+ * .toString()
+ *
+ *
+ * @since 3.6
+ */
+public static class Builder {
+
+private final StringBuilder sb;
--- End diff --
The problem with `Appendable` is that its `append` method can throw an
`IOException`. That would make the builder more cumbersome to use. Of course it
could just rethrow the `IOException` as a `RuntimeException`, but I do not know
if this is o.k. for commons-lang.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #208: LANG-1066: Add shell/XSI escape/unescape sup...
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88799517
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -413,6 +447,47 @@ public int translate(final CharSequence input, final
int index, final Writer out
}
}
+public static final CharSequenceTranslator UNESCAPE_XSI = new
BackslashUnescaper();
+
+/**
+ * Translator object for unescaping backslash escaped entries.
+ *
+ * @since 3.6
+ */
+static class BackslashUnescaper extends CharSequenceTranslator {
--- End diff --
No sure why the author of the patch choose this naming. I'm fine with
changing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #208: LANG-1066: Add shell/XSI escape/unescape sup...
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88799453
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -272,6 +272,40 @@ public int translate(final CharSequence input, final
int index, final Writer out
}
}
+/**
+ * Translator object for escaping Shell command language.
+ *
+ * @see http://pubs.opengroup.org/onlinepubs/7908799/xcu/chap2.html;>Shell
Command Language
+ */
+public static final CharSequenceTranslator ESCAPE_XSI =
+ new LookupTranslator(
+new String[][] {
+ {"|", "\\|"},
+ {"&", "\\&"},
+ {";", "\\;"},
+ {"<", "\\<"},
+ {">", "\\>"},
+ {"(", "\\("},
+ {")", "\\)"},
+ {"$", "\\$"},
+ {"`", "\\`"},
+ {"\\", ""},
+ {"\"", "\\\""},
+ {"'", "\\'"},
+ {" ", "\\ "},
+ {"\t", "\\\t"},
+ {"\r\n", ""},
+ {"\n", ""},
+ {"*", "\\*"},
+ {"?", "\\?"},
+ {"[", "\\["},
--- End diff --
according to http://pubs.opengroup.org/onlinepubs/7908799/xcu/chap2.html it
does not have to be escaped
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #213: LANG-1288: Add a builder to StringEscapeUtil...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/213 LANG-1288: Add a builder to StringEscapeUtils patch supplied by Mark (for LANG-1066) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang add_EscapedStringBuilder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 7a11c5fc982acc2223ae23a1934b19b6dd05b711 Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-11-18T17:36:58Z LANG-1288: Add a builder to StringEscapeUtils patch supplied by Mark (for LANG-1066) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #211: Fixed possible infinite loop in random of RandomStr...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/211 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #212: [LANG-1285] Replicate the fix for LANG-1186
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/212 Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #211: Fixed possible infinite loop in random of RandomStr...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/211 related issue: https://issues.apache.org/jira/browse/LANG-806 I guess this pull request fixes the most important part of the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #211: Fixed possible infinite loop in random of RandomStr...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/211 Thanks for the pull request. :) Please do not mix formatting/white-space changes with functional changes in commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #207: LANG-1274: StrSubstitutor should state its t...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/207 LANG-1274: StrSubstitutor should state its thread safety Add paragraph to class javadoc stating that StrSubstitutor is not thread safe. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang StrSubstitutor_thread_safety_documenation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #207 commit 9fee75f1f39e48e714c85ea28b1d372afee5605b Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-11-04T17:32:39Z LANG-1274: StrSubstitutor should state its thread safety Add paragraph to class javadoc stating that StrSubstitutor is not thread safe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #199: LANG-1258: Add ArrayUtils#toStringArray(Object[]) m...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/199 I have updated the pull request with @Xaerxess changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #203: Memomizer
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/203 Memomizer You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang memomizer Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #203 commit 13d06561eec33f096818a5c204aeaa59a1d0c7a2 Author: jamessawle <jamessa...@hotmail.com> Date: 2015-05-04T21:23:49Z LANG-740 - Implementation of a Memomizer commit f9b98b6955d570b7c8bda815d11d491ca1a0ffe0 Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-10-28T19:55:22Z LANG-740: Implementation of a Memomizer changes suggested in https://github.com/apache/commons-lang/pull/80: - tabs to spaces - use @Override - remove unused variables - other minimal clean-ups --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/e4c72a5522aabfa6a660088aa9262d849756e464#commitcomment-19532086 In src/changes/changes.xml: In src/changes/changes.xml on line 48: pretty optimistic ;) :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/202 I haven't locked at this in-depth yet, but seems like a useful enhancement. I would remove the support for including transient fields, because that seems like a bad practice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #202: LANG-1034: Recursive and reflective EqualsBu...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/202 LANG-1034: Recursive and reflective EqualsBuilder patch by yathos UG You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang recursiveAndReflectiveEqualsBuilder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #202 commit b6eee76036d4e44f89f029aa3d45b6842598e69b Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-10-23T17:56:28Z LANG-1034: Recursive and reflective EqualsBuilder patch by yathos UG --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #201: LANG-1143: StringUtils should use toXxxxCase...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/201 LANG-1143: StringUtils should use toXxxxCase(int) rather than toXxxxC⦠â¦ase(char) based on patch by Sebb You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang LANG-1143 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #201 commit fc0f62597b8f0284413ea35c1d958e30fe20392f Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-10-23T17:07:04Z LANG-1143: StringUtils should use toXxxxCase(int) rather than toXxxxCase(char) based on patch by Sebb --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #200: LANG-1276
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/200 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 @Derek-Ashmore Just today I learned that the resetting of the original accessibility of the method I asked you to add is not necessary, because `Method#setAccessible` only modifies the behavior of the `AccessibleObject` not of the actual method. See http://stackoverflow.com/questions/10638826/java-reflection-impact-of-setaccessibletrue and http://www.artima.com/weblogs/viewpost.jsp?thread=164042 for details. Sorry that I caused you extra work. :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #199: LANG-1258: Add ArrayUtils#toStringArray(Obje...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/199 LANG-1258: Add ArrayUtils#toStringArray(Object[]) method patch supplied by IG You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang ArrayUtils#toStringArray Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit bfc8805ac898cb4d7a8ca45ab1d5106bc2b63342 Author: mildis <igard...@yahoo.fr> Date: 2016-08-16T16:00:00Z LANG-1258: Add ArrayUtils#toStringArray(Object[]) method patch supplied by IG --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #198: LANG-1269: Wrong name or result of StringUti...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/198 LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance deprecat StringUtils#getJaroWinklerDistance and add StringUtils#getJaroWinklerSimilarity instead You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang jarowinklerdistance_name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #198 commit d2e6338a8ec46ebc80156ef9dcdd83dfe63ee8b5 Author: pascalschumacher <pascalschumac...@gmx.net> Date: 2016-10-22T09:55:32Z LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance deprecat StringUtils#getJaroWinklerDistance and add StringUtils#getJaroWinklerSimilarity instead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #189: new impl of LevenshteinDistance
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/189 @yufcuy: Thanks for the pull request. :+1: @kinow: Thanks for the review. I have added the link and replaced tabs with spaces after merging. Feel free to change/improve anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #195: LANG-1160 StringUtils.abbreviate() to support 'cust...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/195 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #193: Add isAnyNotEmpty() and isAnyNotBlank() to StringUt...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/193 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/194 Thanks for the pull request. The method body can be shortened to `StringUtils.isBlank(cs) || StringUtils.equalsIgnoreCase(cs, "null")`. The method would be very confusing, as the String `"null"` is not all bank. I'm sorry, but I'm -1 to adding this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #189: new impl of LevenshteinDistance
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/189 @kinow I think this has to stay in lang. At least until lang 4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #39: LANG-1065 Added new 'merge' method to DateUtils and ...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/39 Closed because of unresolved merge conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #193: Add isAnyNotEmpty() and isAnyNotBlank() to StringUt...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/193 I agree with both of you. An empty array does not contain any non-empty/non-blank `CharSequence`s, so `isAnyNotEmpty`/`isAnyNotBlank` should return `false` for an empty array. An empty array does not contain any empty/blank `CharSequence`s, so `isAnyEmpty`/`isAnyBlank` should return `false` for an empty array. I created two jira issues: one for the addition: https://issues.apache.org/jira/browse/LANG-1270 and one the purposed change: https://issues.apache.org/jira/browse/LANG-1271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/e6ad17215d27b66b7fe43931247fc3470d8dee18#commitcomment-19077493 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #184: Correct replacing 160 in normalizeSpace
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/184 the non-breaking space replacement was added with https://issues.apache.org/jira/browse/LANG-910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
