[jira] [Updated] (IO-319) FileUtils.sizeOfDirectory follows symbolic links.
[
https://issues.apache.org/jira/browse/IO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated IO-319:
Attachment: commons-io-319.patch
Thanks for the review and pointer Gary! I've updated the patch for windows. I'm
afraid I do not have a Windows machine to test this on. Could you please?
> FileUtils.sizeOfDirectory follows symbolic links.
> -
>
> Key: IO-319
> URL: https://issues.apache.org/jira/browse/IO-319
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.1
>Reporter: Ravi Prakash
>Priority: Critical
> Attachments: commons-io-319.patch, commons-io-319.patch
>
>
> First of all Thanks tons Apache Commons folks for all the amazing work! :) My
> first JIRA. Yayyy. I contributed B-)
> A symbolic link may create a cycle and so sizeOfDirectory crashes with an
> IllegalArgumentException. e.g.
> {noformat}
> $ tree test
> test
> ├── file
> └── ravi
> ├── cycle -> ../../test
> └── file
> {noformat}
> causes FileUtils.sizeOfDirectory to crash like so
> {noformat}
> java TestJAVA
> Exception in thread "main" java.lang.IllegalArgumentException:
> /test/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle
> does not exist
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2053)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> {noformat}
> We faced the same issue in Hadoop :(. Checkout
> https://issues.apache.org/jira/browse/HADOOP-6963 for our solution
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IO-319) FileUtils.sizeOfDirectory follows symbolic links.
[
https://issues.apache.org/jira/browse/IO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated IO-319:
Attachment: commons-io-319.patch
Hi Gary,
Could you please review this patch? I wasn't able to find a way to create
symlinks under Windows (FAT doesn't seem to support it) so the test code only
checks under non-windows systems.
> FileUtils.sizeOfDirectory follows symbolic links.
> -
>
> Key: IO-319
> URL: https://issues.apache.org/jira/browse/IO-319
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.1
>Reporter: Ravi Prakash
>Priority: Critical
> Attachments: commons-io-319.patch
>
>
> First of all Thanks tons Apache Commons folks for all the amazing work! :) My
> first JIRA. Yayyy. I contributed B-)
> A symbolic link may create a cycle and so sizeOfDirectory crashes with an
> IllegalArgumentException. e.g.
> {noformat}
> $ tree test
> test
> ├── file
> └── ravi
> ├── cycle -> ../../test
> └── file
> {noformat}
> causes FileUtils.sizeOfDirectory to crash like so
> {noformat}
> java TestJAVA
> Exception in thread "main" java.lang.IllegalArgumentException:
> /test/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle/ravi/cycle
> does not exist
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2053)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2057)
> at
> org.apache.commons.io.FileUtils.sizeOfDirectory(FileUtils.java:2089)
> {noformat}
> We faced the same issue in Hadoop :(. Checkout
> https://issues.apache.org/jira/browse/HADOOP-6963 for our solution
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
