[jira] [Comment Edited] (LOGGING-136) API Enhancements: 'String.format(String, Object...)' Functionality & Delegate Convenience Methods
[
https://issues.apache.org/jira/browse/LOGGING-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380699#comment-15380699
]
Remko Popma edited comment on LOGGING-136 at 7/16/16 11:44 AM:
---
+1 to deprecate commons-logging and recommend users to move to the Log4j 2 API.
was (Author: rem...@yahoo.com):
+1 to deprecate commons-logging and recommend users to upgrade to the Log4j 2
API.
> API Enhancements: 'String.format(String, Object...)' Functionality & Delegate
> Convenience Methods
> -
>
> Key: LOGGING-136
> URL: https://issues.apache.org/jira/browse/LOGGING-136
> Project: Commons Logging
> Issue Type: Improvement
>Affects Versions: 1.1.1
> Environment: N/A
>Reporter: Daniel Siviter
> Labels: api, api-addition
> Fix For: 2.0
>
> Attachments: commons-logging-1.1.1-src.rar,
> commons-logging-1.1.1.jar, site.rar
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Improvements to the API to allow convenience methods for performing
> {{String.format(String, Object...)}} and allow access to the internal logging
> delegate.
> Firstly, to add the {{String#format(String, Object...)}} functionality modify
> the methods (note: only {{#trace(...)}} shown):
> {{void trace(Object message, Object... args);}}
> {{void trace(Object message, Throwable t, Object... args);}}
> This would allow compatiblity with previous versions of the API (although I
> believe they would still require a re-compile) and help tidy up code.
> Secondly, to obtain access to the internal instance of a logger the addition
> of a {{#getDeletegate()}} method.
> I can supply the code if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LOGGING-136) API Enhancements: 'String.format(String, Object...)' Functionality & Delegate Convenience Methods
[
https://issues.apache.org/jira/browse/LOGGING-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380699#comment-15380699
]
Remko Popma commented on LOGGING-136:
-
+1 to deprecate commons-logging and recommend users to upgrade to the Log4j 2
API.
> API Enhancements: 'String.format(String, Object...)' Functionality & Delegate
> Convenience Methods
> -
>
> Key: LOGGING-136
> URL: https://issues.apache.org/jira/browse/LOGGING-136
> Project: Commons Logging
> Issue Type: Improvement
>Affects Versions: 1.1.1
> Environment: N/A
>Reporter: Daniel Siviter
> Labels: api, api-addition
> Fix For: 2.0
>
> Attachments: commons-logging-1.1.1-src.rar,
> commons-logging-1.1.1.jar, site.rar
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Improvements to the API to allow convenience methods for performing
> {{String.format(String, Object...)}} and allow access to the internal logging
> delegate.
> Firstly, to add the {{String#format(String, Object...)}} functionality modify
> the methods (note: only {{#trace(...)}} shown):
> {{void trace(Object message, Object... args);}}
> {{void trace(Object message, Throwable t, Object... args);}}
> This would allow compatiblity with previous versions of the API (although I
> believe they would still require a re-compile) and help tidy up code.
> Secondly, to obtain access to the internal instance of a logger the addition
> of a {{#getDeletegate()}} method.
> I can supply the code if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (VFS-296) [FTP] Socket timeout setting doesn't work if connect hangs
[ https://issues.apache.org/jira/browse/VFS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614110#comment-14614110 ] Remko Popma commented on VFS-296: - About a week ago we started to use the timeout methods available in 2.0 (data timeout and so timeout). Since then we have not seen out app hanging (fingers crossed). If it happens again we will try to get a jstack dump before restarting, good tip, thanks! [FTP] Socket timeout setting doesn't work if connect hangs -- Key: VFS-296 URL: https://issues.apache.org/jira/browse/VFS-296 Project: Commons VFS Issue Type: Bug Affects Versions: Nightly Builds Reporter: Andreas Persson Fix For: 2.1 Attachments: sotimeout.patch, sotimeout_v2.patch The fix from VFS-216 doesn't help if the ftp server doesn't reply with any messages at all (could happen if it's behind a badly configured firewall for example). What happens is that the client.connect() called from FtpClientFactory hangs, and this line is before timeout parameter is set. I suggest the change in the attached patch. The scenario can be tested with netcat -l instead of a real ftp server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-296) [FTP] Socket timeout setting doesn't work if connect hangs
[ https://issues.apache.org/jira/browse/VFS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609478#comment-14609478 ] Remko Popma commented on VFS-296: - We will try to use jstack if the problem occurs again. Is there a snapshot or beta build somewhere that includes this fix? [FTP] Socket timeout setting doesn't work if connect hangs -- Key: VFS-296 URL: https://issues.apache.org/jira/browse/VFS-296 Project: Commons VFS Issue Type: Bug Affects Versions: Nightly Builds Reporter: Andreas Persson Fix For: 2.1 Attachments: sotimeout.patch, sotimeout_v2.patch The fix from VFS-216 doesn't help if the ftp server doesn't reply with any messages at all (could happen if it's behind a badly configured firewall for example). What happens is that the client.connect() called from FtpClientFactory hangs, and this line is before timeout parameter is set. I suggest the change in the attached patch. The scenario can be tested with netcat -l instead of a real ftp server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-296) [FTP] Socket timeout setting doesn't work if connect hangs
[ https://issues.apache.org/jira/browse/VFS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608489#comment-14608489 ] Remko Popma commented on VFS-296: - At my company we are using version 2.0 and have recently experienced our app hanging while trying to send files over FTP. This has happened 4 times in the previous 9 business days. We are not sure what (if anything) has changed. At the moment we are manually recovering any time this happens. We would love to upgrade to a version that includes this fix but 2.1 is not out yet. Is there a plan to release 2.1 in the near future? [FTP] Socket timeout setting doesn't work if connect hangs -- Key: VFS-296 URL: https://issues.apache.org/jira/browse/VFS-296 Project: Commons VFS Issue Type: Bug Affects Versions: Nightly Builds Reporter: Andreas Persson Fix For: 2.1 Attachments: sotimeout.patch, sotimeout_v2.patch The fix from VFS-216 doesn't help if the ftp server doesn't reply with any messages at all (could happen if it's behind a badly configured firewall for example). What happens is that the client.connect() called from FtpClientFactory hangs, and this line is before timeout parameter is set. I suggest the change in the attached patch. The scenario can be tested with netcat -l instead of a real ftp server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
