[jira] [Created] (EMAIL-120) attach(DataSource xx) doesn't close inputstream

[mike bell (JIRA)]

mike bell created EMAIL-120:
---

 Summary: attach(DataSource xx) doesn't close inputstream
 Key: EMAIL-120
 URL: https://issues.apache.org/jira/browse/EMAIL-120
 Project: Commons Email
  Issue Type: Bug
Affects Versions: 1.2
 Environment: Windows 7, 64 bit
Reporter: mike bell


Basically I have code like shown below.

message.attach(reports[1].getDatasource(),

"Report" + new 
SimpleDateFormat("mmdd").format(new java.util.Date()) + "." + 
selectedAttachment,
selectedAttachment.toUpperCase() + " version of 
report");

Where the DataSource in question is a simple JAF FileDataSource.

What I found [when I found files were not being cleaned up by my cleaner)

1. I can delete the backing file before calling this method
2. I cannot delete the backing file after calling this method.
3. Workaround uses the URL version of attachment.

DataSource ds=reports[1].getDatasource();
FileDataSource fds=(FileDataSource) ds;
URL url=fds.getFile().toURI().toURL();

/**
 * MJB: We don't use the DataSource directly (as we 
should) because of a bug in Commons Email
 * where it usually doesn't close the inputstream
 */
message.attach(url,"Report" + new 
SimpleDateFormat("mmdd").format(new java.util.Date()) + "." + 
selectedAttachment,
selectedAttachment.toUpperCase() + " 
version of report");

4. I therefore assume the inputstream has been opened and never closed.
5. Same test after calling send() provides same results


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (IO-171) IO assumes there are only two OSes: Windows and Unix

[mike bell (JIRA)]

[ 
https://issues.apache.org/jira/browse/IO-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606169#action_12606169
 ] 

mike bell commented on IO-171:
--

Just to make things more exciting netware uses both / and \ and is case 
insensitive :)

format: server/volume:path\path
But admittedly, as long as one is local to the server, one usually only uses 
backslash. 
volume:path\path

> IO assumes there are only two OSes: Windows and Unix
> 
>
> Key: IO-171
> URL: https://issues.apache.org/jira/browse/IO-171
> Project: Commons IO
>  Issue Type: Bug
>Reporter: Sebb
>Priority: Minor
>
> Just noticed that IO assumes systems are either:
> Windows-like:
> * File.separatorChar = \
> * Case-insensitive matching
> or
> Unix-like:
> * File.separatorChar = /
> * Case-sensitive matching
> It may well be true that there are only two different file sepator 
> characters, but it is not true that all non-Windows systems use 
> case-sensitive matching.
> For example, OpenVMS uses a file separator char of /, but originally only 
> supported case-insensitive file names (always shown as uppercase).
> Current versions of OpenVMS support both upper and lower-case; the default is 
> to use case-insenstive matching (and upper case names).
> Perhaps the IOCase.SYSTEM constant needs to have an "Unknown" or "Variable" 
> setting for this; it would then be an error to use IOCase.SYSTEM to determine 
> the case sensitivity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.