[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #99: Minor Changes

[GitBox]

garydgregory commented on code in PR #99:
URL: https://github.com/apache/commons-bcel/pull/99#discussion_r985087679


##
src/main/java/org/apache/bcel/generic/Instruction.java:
##
@@ -465,8 +465,7 @@ public static Instruction readInstruction( final 
ByteSequence bytes ) throws IOE
 
 }
 
-if (wide
-&& !(obj instanceof LocalVariableInstruction || obj instanceof 
IINC || obj instanceof RET)) {
+if (wide && !(obj instanceof LocalVariableInstruction || obj 
instanceof RET)) {

Review Comment:
   I see, `IINC` extends `LocalVariableInstruction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #99: Minor Changes:

[GitBox]

garydgregory commented on code in PR #99:
URL: https://github.com/apache/commons-bcel/pull/99#discussion_r810508673


##
src/main/java/org/apache/bcel/generic/Instruction.java:
##
@@ -465,8 +465,7 @@ public static Instruction readInstruction( final 
ByteSequence bytes ) throws IOE
 
 }
 
-if (wide
-&& !(obj instanceof LocalVariableInstruction || obj instanceof 
IINC || obj instanceof RET)) {
+if (wide && !(obj instanceof LocalVariableInstruction || obj 
instanceof RET)) {

Review Comment:
   Hi @arturobernalg 
   TY for your PR.
   Why is this one logic changes an improvement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org