[GitHub] [commons-bcel] garydgregory commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
garydgregory commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114286993 Hi @timboudreau I appologize for not being clearer in my comment https://github.com/apache/commons-bcel/pull/125#issuecomment-1113740147 There is now a fix and a test in git master. If you think the change and/or the test in git master is incomplete, then feel free to update this PR or create a new one, whatever is simpler for you. I did not include a typecast because it was not required for this use case and none of the other cases in the switch of the affected method use a cast. Note that the test in git master include real module-info class files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
garydgregory commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1113740147 Hi @timboudreau Thank you for this PR but it does not compile, see the GitHub build failures. In the future, you should build with Java 8 to make sure code is compatible. See git master for a fix and better tests. Close this PR or rebase to provide more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
garydgregory commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112033456 Hello @timboudreau , Thank you for the PR. Is the instance of test really needed? It would be best to have test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
