[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114302035 The module info file in the test I provided _is_ a real module info file - just base-64 encoded. But whatever. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114260729 I see a change that blindly casts to ConstantUtf8 has been made in the trunk, now creating a conflict with this PR. I have no idea if the blind cast is safe (it does not look like it), but regardless you may want to pick up the unit test from this PR so there is a way to detect regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114259680 Updated the PR branch to no longer call `StringBuilder.isEmpty()` in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112866491 Updated this PR with a test which fails if you comment out the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112686082 I don't think I understand the question. Are you asking me to write a test and add it to the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
