[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-494003582 @garydgregory - No need to apologize. This is why we review, right? Updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-493983030 @garydgregory Sorry about that. Missed a step in my rebase. Should be all set now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-493973348 @garydgregory - Rebased and pushed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-489318791 @aherbert - That may be a valid concern, but that code existed before this change and, therefore, I feel it should not be changed under CODEC-134. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-489203255 @garydgregory - I completely agree with you. I'll rework that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
