[GitHub] [commons-collections] aherbert commented on issue #138: Update the package-info.java

2020-03-17 Thread GitBox 
aherbert commented on issue #138: Update the package-info.java
URL: 
https://github.com/apache/commons-collections/pull/138#issuecomment-599922032
 
 
   Thanks. I have fixed the check for the number of bits in master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-collections] aherbert commented on issue #138: Update the package-info.java

2020-03-16 Thread GitBox 
aherbert commented on issue #138: Update the package-info.java
URL: 
https://github.com/apache/commons-collections/pull/138#issuecomment-599641398
 
 
   I believe the recent changes in master make this PR obsolete. Please check 
the current master and close or rebase the PR with new modifications.
   Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-collections] aherbert commented on issue #138: Update the package-info.java

2020-03-12 Thread GitBox 
aherbert commented on issue #138: Update the package-info.java
URL: 
https://github.com/apache/commons-collections/pull/138#issuecomment-598202950
 
 
   Hi @dota17 ,
   
   It seems that you are working on fixing more than just the package info. I 
have another PR to push through some fixes for the Bloom filter code. Part of 
this is a big update to Shape as the documentation was limited and as you have 
noticed in parts incorrect. 
   
   I have added commit to PR #140 that should cover updating the package info, 
the BloomFilterIndexer and the Shape class. Have a look and see if you can see 
issues. I was waiting for @Claudenw to have a look before merging. It should 
address all your fixes.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services