aherbert commented on PR #335:
URL:
https://github.com/apache/commons-collections/pull/335#issuecomment-1296319411
Hi @Claudenw, consolidating all the behaviour flags is a good idea. It will
avoid future tests failing to set them correctly. I'll wait until you have done
that for a review.
Note: I have reservations about the HasherCollection and the requirement for
an `absoluteUniqueIndices` method. In summary:
1. I think it should be resolved after this PR
2. Since the HasherCollection violates the IndexProducer contract by
outputting more than k indices, we may need to revise the contract and javadoc
as being able to output up to a multiple of k indices for a Shape. This would
be helped by a size-type method in the IndexProducer interface to state what
count of k will be output.
3. The method `absoluteUniqueIndices` may be better served by a HasherSet,
or some other naming variant, that ensures all indices output by the
IndexProducer are unique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
