[GitHub] [commons-collections] garydgregory commented on a change in pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
garydgregory commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r527354164
##
File path: src/main/java/org/apache/commons/collections4/IteratorUtils.java
##
@@ -123,7 +123,7 @@
private static final String DEFAULT_TOSTRING_DELIMITER = ", ";
/**
- * IteratorUtils is not normally instantiated.
+ * {@code IteratorUtils} should not normally be instantiated.
Review comment:
Hi @arturobernalg
If you want to change the all the comments, I do not think we need to
duplicate the class names in each comment, I would simply say:
```
/**
* Don't allow instances.
*/
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on a change in pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
garydgregory commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r526820021
##
File path: src/main/java/org/apache/commons/collections4/IterableUtils.java
##
@@ -50,6 +50,11 @@
*/
public class IterableUtils {
+/**
+ * {@code IterableUtils} should not normally be instantiated.
+ */
+private IterableUtils() {}
+
Review comment:
There is nothing planned for 5.0 AFAIK, 4.5 would be next. Creating a
5.0 branch now would be premature IMO and I personally would not want to spend
the time maintaining it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
