[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.
garydgregory commented on pull request #159: URL: https://github.com/apache/commons-collections/pull/159#issuecomment-1060050601 I think JUnit 5 work might be done in master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.
garydgregory commented on pull request #159: URL: https://github.com/apache/commons-collections/pull/159#issuecomment-1059196500 I just merged a series of JUnit 5 PRs; if this PR still contains changes not covered in git master, please rebase, if not, please close it. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.
garydgregory commented on pull request #159: URL: https://github.com/apache/commons-collections/pull/159#issuecomment-632113164 > > @dota17 The title says "WIP". Are you still working on it? > > Yes, I am. > If anyone has time to review, it would be really nice. ;-) > > Thanks Hi @dota17 This PR currently touches **124** files, which is a lot to review. Personally, for me to review this, I'd want to know the PR is as best as you can make it, because, as you can imagine, I really do not want to do it twice! ;-) So either it's WIP or it is as good as it is going to get from your POV at least. Please let us know... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
