[GitHub] [commons-compress] bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow
bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow URL: https://github.com/apache/commons-compress/pull/91#issuecomment-576659899 many thanks @jobar I've merged this, it will be incorparated in 1.20. I've made a few small changes and listed you as contributor in our changelog. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-compress] bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow
bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow URL: https://github.com/apache/commons-compress/pull/91#issuecomment-576586840 Thank you, I'll need to double check on the license myself. :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-compress] bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow
bodewig commented on issue #91: Make bz2 decompressor robust to selector overflow URL: https://github.com/apache/commons-compress/pull/91#issuecomment-576541516 Many thanks @jobar The test fails on my Linux box and seems to fail on Travis as well, Could this be a line-separator OS-difference issue on the XML file? If so, it might be better to pick a different testcase - if possible - anyway as [it's licesne(https://dumps.wikimedia.org/legal.html) may force us to jump through a few extra hoops, see https://apache.org/legal/resolved.html#cc-sa One more thing, to me it looks as if the `currentWorkingBlock` variable you introduced was never read and can safely be removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
