[GitHub] [commons-compress] garydgregory commented on pull request #345: COMPRESS-613: Support for extra time data in Zip archives
garydgregory commented on PR #345: URL: https://github.com/apache/commons-compress/pull/345#issuecomment-1368444645 @andrebrait Thank you for your updates, merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] garydgregory commented on pull request #345: COMPRESS-613: Support for extra time data in Zip archives
garydgregory commented on PR #345: URL: https://github.com/apache/commons-compress/pull/345#issuecomment-1367962516 > > The "fix" for COMPRESS-583 was to document that the behaviour changed when setting the entry from a file. For me this would be ok but at the same time reproduciblity is no concern for my use cases. But maybe someone else has a different opinion. > > Creating the entry from a file is still very convenient. I guess we could come up with a different constructor for when that's desired without setting any of the optional attributes (i.e. the original behavior). I think we can work on build reproducibility issues in subsequent PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
