[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8

2023-06-06 Thread via GitHub


sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1578364570

   Unfortunately, when using fork=true, some informational messages are not 
shown, see:
   https://issues.apache.org/jira/browse/MCOMPILER-537


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8

2023-06-06 Thread via GitHub


sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1578190656

   See https://issues.apache.org/jira/browse/MCOMPILER-491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8

2023-06-05 Thread via GitHub


sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1576896714

   I can confirm that changing the encoding causes the compile to report an 
ERROR, but the build succeeds:
   
   $ mvn clean compile -Dcommons.encoding=UTF8
   ...
   [INFO] Compiling 399 source files with javac [debug release 8] to 
target/classes
   [ERROR] 
/commons/compress/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java:[300,32]
 unmappable character (0xF6) for encoding UTF-8
   ...
   [INFO] BUILD SUCCESS
   
   I've tried experimenting with -Dmaven.compiler.failOnWarning=true (and 
failOnError), but Maven does not fail the build.
   
   However, adding  -Dcommons.compiler.fork=true does cause the build to fail.
   Possible bug in Maven?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org