[GitHub] [commons-compress] tcurdt commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives
tcurdt commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives URL: https://github.com/apache/commons-compress/pull/87#issuecomment-562540937 I didn't do a thorough code review but from the diffs it looks OKish. Still not sure about some of the new classes. Either way - thanks for all the work! It would probably be good to check this out and look at the final code as this is a big change. I am wondering if our test cases are enough of a safety net. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-compress] tcurdt commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives
tcurdt commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives URL: https://github.com/apache/commons-compress/pull/87#issuecomment-559077121 While I appreciate being careful, I am not a fan of duplicating functionality and interfaces like that. So I am in favor of just one class. Maybe it means that testing needs to improved to be sure all is kept working. Since @bodewig has the best overview over the project these days I think it would be good to get input from him first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
