[GitHub] [commons-compress] theobisproject commented on pull request #344: Replace JUnit 3 with JUnit 5
theobisproject commented on PR #344: URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365946949 I have removed the visibility change of the classes and methods from the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] theobisproject commented on pull request #344: Replace JUnit 3 with JUnit 5
theobisproject commented on PR #344: URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365283815 I have replaced all the try-catch-assert patterns in the tests I migrated. Also more tests do now use the parameterized tests for execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] theobisproject commented on pull request #344: Replace JUnit 3 with JUnit 5
theobisproject commented on PR #344: URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365219087 @garydgregory I will go through the classes and do some more migrations. Is there anything else you would like to have changed (like using try-with-resources, ...)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
