[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] Migrate to Junit 5

2020-12-27 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-751490927


   Done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] Migrate to Junit 5

2020-12-24 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-751190861


   HI @garydgregory 
   I think they should be fixed.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] Migrate to Junit 5

2020-12-24 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-750802626


   HI @garydgregory 
   
   Any progress here?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] Migrate to Junit 5

2020-12-21 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-749002653


   HI @garydgregory 
   
   I've made all changes
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] - Migrate to Junit 5

2020-12-12 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-743858956


   @garydgregory 
   That's true.  I was just saying that those message are unnecessary IMO.  But 
I get your point, and you're right. The propose of the PR it's migrate to Junit 
5, not improve the  test or the message. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] arturobernalg commented on pull request #114: [CRYPTO-151] - Migrate to Junit 5

2020-12-12 Thread GitBox 


arturobernalg commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-743749201


   Hi @garydgregory 
   As you can imaginate I don't think validating the exception message helps 
functional testing. But any case i made the revert and adapt to JUnit 5.
   I've check of all the new change



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org