[GitHub] [commons-csv] DamjanJovanovic commented on a diff in pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

[GitBox]

DamjanJovanovic commented on code in PR #295:
URL: https://github.com/apache/commons-csv/pull/295#discussion_r1082679746


##
src/main/java/org/apache/commons/csv/CSVFormat.java:
##
@@ -846,6 +881,8 @@ public CSVFormat getFormat() {
 public static final CSVFormat EXCEL = DEFAULT.builder()

Review Comment:
   Maybe, but all spreadsheets are "lenient".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-csv] DamjanJovanovic commented on a diff in pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

[GitBox]

DamjanJovanovic commented on code in PR #295:
URL: https://github.com/apache/commons-csv/pull/295#discussion_r1062000582


##
src/main/java/org/apache/commons/csv/CSVFormat.java:
##
@@ -288,6 +294,18 @@ public Builder setAllowDuplicateHeaderNames(final boolean 
allowDuplicateHeaderNa
 return this;
 }
 
+/**
+ * Sets whether the last field on the last line, if quoted, can have 
no closing quote when the file ends, {@code true} if this is ok,
+ * {@code false} if {@link IOException} should be thrown.
+ *
+ * @param allowEOFWithoutClosingQuote whether to allow the last field 
on the last line to have a missing closing quote when the file ends,
+ *{@code true} if so, or {@code 
false} to cause an {@link IOException} to be thrown.
+ */

Review Comment:
   Done, used 1.10.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org