[GitHub] [commons-csv] garydgregory commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats

2022-09-26 Thread GitBox


garydgregory commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1258615088

   Hello @angusdev 
   
   Thank you for updating your PR.
   
   (1) I think you need to test for tab characters (ASCII 9) in values.
   
   (2) In the PG docs I read
   ```
   QUOTE
   Specifies the quoting character to be used when a data value is quoted. The 
default is double-quote. This must be a single one-byte character. This option 
is allowed only when using CSV format.
   
   ESCAPE
   Specifies the character that should appear before a data character that 
matches the QUOTE value. The default is the same as the QUOTE value (so that 
the quoting character is doubled if it appears in the data). This must be a 
single one-byte character. This option is allowed only when using CSV format.
   ```
   Please help me understand why the git master code does not match this 
definition.
   TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-csv] garydgregory commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats

2022-09-25 Thread GitBox


garydgregory commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257300816

   Hi @angusdev 
   Thank you for the PR.
   Does the version of PostgreSQL matter? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org