[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1336519441 > > > @arturobernalg > > > Do you even run local builds before pushing out a PR? > > > Some of these tests will obviously fail, for example, see Exec65Test where the OS checks were not updated for JUnit 5 and cause the tests to fail. > > > > > > @garydgregory Honestly don't fallow you. AFAIU the test is in Junit5. > > No error in my local > > [WARNING] 24 warnings [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:43 min [INFO] Finished at: 2022-12-04T21:07:17+01:00 [INFO] > > Self explanatory @arturobernalg : > > ``` > Error: Errors: > Error:Exec65Test.testExec65WithSleepUsingShellScript:76 Execute The test 'testExec65WithSleepUsingShellScript()' is not possible for OS : Linux (Exit value: 0) > [INFO] > Error: Tests run: 104, Failures: 0, Errors: 1, Skipped: 9 > ``` I guest that is why there is a comment in the java docs ```This test currently only works for Mac OS X``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1336506234 > @arturobernalg > Do you even run local builds before pushing out a PR? > Some of these tests will obviously fail, for example, see Exec65Test where the OS checks were not updated for JUnit 5 and cause the tests to fail. @garydgregory Honestly don't fallow you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1331293219 > @arturobernalg > Hi, > This component is now on Java 8. Hey @garydgregory I think its already done. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5
arturobernalg commented on pull request #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-746971803 Hi @garydgregory you're right, I didn't realize that it actually requires version 1.7. How can i start the process to migrate the libs to java 1.8? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
