[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912493463 The change here is for 2.x, which will be released some time in the future. Isn't it time to upgrade to a newer version of Java ? People could use 1.x for JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-902510502 > I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. https://issues.apache.org/jira/browse/FILEUPLOAD-341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901915469 Wicket does not use reflection, so no need to `open` (at least for Wicket). @GedMarc Please check this PR. ``` // use JDK 9+ mvn package cd target unzip commons-fileupload2-2.0-SNAPSHOT.jar javap META-INF/versions/9/module-info.class ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901898390 > You should pre-build your module file and include it moditect, but definitely do not auto generate from it @GedMarc You mean we should not include the `impl` package (added by the auto-generation) ? I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901894181 Actually, I could disable the moditect plugin by default. This way everyone could build with JDK 1.8. But the release manager will have to enable it. I see there is a `release` profile in the parent pom already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901891128 About CI: I could preserve the JDK 8 in GHA and TravisCi and run just `mvn test` when JDK==1.8. Is this OK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901890506 > Besides, please add yourself to the contributors list In the pom.xml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
