[GitHub] [commons-geometry] darkma773r commented on pull request #194: GEOMETRY-142: PointMap and PointSet
darkma773r commented on pull request #194: URL: https://github.com/apache/commons-geometry/pull/194#issuecomment-1068662469 Addressed comments and made changes based on recommendations on the dev mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r commented on pull request #194: GEOMETRY-142: PointMap and PointSet
darkma773r commented on pull request #194: URL: https://github.com/apache/commons-geometry/pull/194#issuecomment-1066117860 Thanks for the review, @kinow! Your feedback is invaluable. I'll make the changes you suggested as soon as I get some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r commented on pull request #194: GEOMETRY-142: PointMap and PointSet
darkma773r commented on pull request #194: URL: https://github.com/apache/commons-geometry/pull/194#issuecomment-1065886906 Thanks for the review, @kinow! That sounds like a good plan. One of the trickiest parts of the work here was getting all of the map views implemented (i.e. keySet, entrySet, values, and their associated iterators). Having another set of eyes on that would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
