[GitHub] [commons-graph] arturobernalg commented on pull request #5: [SANDBOX-511] Minor Improvement commons-graph
arturobernalg commented on pull request #5: URL: https://github.com/apache/commons-graph/pull/5#issuecomment-751333742 HI @kinow Check this --> https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-graph] arturobernalg commented on pull request #5: [SANDBOX-511] Minor Improvement commons-graph
arturobernalg commented on pull request #5: URL: https://github.com/apache/commons-graph/pull/5#issuecomment-748602278 Hi I just think it can be good practice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-graph] arturobernalg commented on pull request #5: [SANDBOX-511] Minor Improvement commons-graph
arturobernalg commented on pull request #5: URL: https://github.com/apache/commons-graph/pull/5#issuecomment-748588724 IMO on type ensure that the reference will never change. For the values types it will ensure that the value cannot change. If you check some of the other apache commons modules you can see that they follow the same approach. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org