[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1742114264 I probably just named them arbitrarily, so feel free to rename them if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1737971692 I've rebased and resolved conflicts. I noticed that the project had changed a lot in my time away, so I simply updated this PR so that it would compile and pass tests. If there is anything else to update, it will take me some time to get back to this work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1383319953 I updated this PR, added the `@since` tag and more detailed javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1381023692 @kinow I went back to this work and completed the missing documents. Can you take a look at my question here at https://github.com/apache/commons-imaging/pull/254/files/08d6a0dff607eefa633c89d231a01623e3ad90c6#r1049312581? I feel that the usage of `ImageReadException` and `IOException` is often confused, so I don't know which one to choose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
