[GitHub] [commons-imaging] gwlucastrig commented on pull request #318: [IMAGING-316] Add support for BigTIFF format
gwlucastrig commented on PR #318: URL: https://github.com/apache/commons-imaging/pull/318#issuecomment-1738274426 Added Javadoc and corrected formatting. In order to support an additional JUnit test, I needed to add a new toBytes() method for longs. This method wasn't required for reading BigTIFFs, but it was necessary to implement the JUnit test. It will be useful in the future for any implementation that writes BigTIFFs (the current implementation only reads them). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #318: Imaging-316: Add support for BigTIFF format
gwlucastrig commented on PR #318: URL: https://github.com/apache/commons-imaging/pull/318#issuecomment-1734616510 I hope I did this right. Please let me know if it didn't work. I am not adept at Git and was unable to find a clear set of instructions for submitting changes in response to a PR review. I'm sure they're out there, but I didn't find them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #318: Imaging-316: Add support for BigTIFF format
gwlucastrig commented on PR #318: URL: https://github.com/apache/commons-imaging/pull/318#issuecomment-1725688908 Will address these comments and update code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #318: Imaging-316: Add support for BigTIFF format
gwlucastrig commented on PR #318: URL: https://github.com/apache/commons-imaging/pull/318#issuecomment-1725312015 Do you have a feel for when this PR might get merged or, failing that, rejected? I've got some other stuff I'm working on and am trying to plan for the next few weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
