[GitHub] [commons-io] DaGeRe commented on pull request #343: IO-764 Fix big string writing by writing with ByteBuffer instead calling getBytes directly

2022-04-05 Thread GitBox 


DaGeRe commented on PR #343:
URL: https://github.com/apache/commons-io/pull/343#issuecomment-1088718744

   Thanks for the hints. I've removed my test, added the comments, removed 
closing of the channel and fixed the checkstyle problems, and I rebased to 
latest master state.
   
   Getting the behaviour by mocking is not possible from my point of view, 
because the problem happens when `getBytes` produces an array that is too big 
for handling - returning this array from a mocked `getBytes` would result in 
the same ressource usage as having it inside a String.
   
   Is this ok from your point of view?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] DaGeRe commented on pull request #343: IO-764 Fix big string writing by writing with ByteBuffer instead calling getBytes directly

2022-04-04 Thread GitBox 


DaGeRe commented on PR #343:
URL: https://github.com/apache/commons-io/pull/343#issuecomment-1087378794

   Unfortunately, this does not work on GH Actions since the RAM is too small. 
Should I increase the RAM for the test or disable the test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org