[GitHub] [commons-io] garydgregory commented on pull request #450: IO-790 symbolic link file filter test incomplete, needs to handle windows issues

[via GitHub]

garydgregory commented on PR #450:
URL: https://github.com/apache/commons-io/pull/450#issuecomment-1514579989

   @SwingGuy1024 
   Thank you for your PR. Noet my comments for future reference. I'll merge and 
adjust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #450: IO-790 symbolic link file filter test incomplete, needs to handle windows issues

[via GitHub]

garydgregory commented on PR #450:
URL: https://github.com/apache/commons-io/pull/450#issuecomment-1514557695

   You really should not have your address and phone number in emails IMO.
   
   Gary
   
   
   On Wed, Apr 19, 2023, 06:47 Miguel Muñoz ***@***.***> wrote:
   
   > Gary,
   > The PR for IO-790 has changes from both PRs, so that's what you should
   > review. Sorry about that. I shouldn't have created two separate JIRA issues
   > for this.
   > — Miguel Muñoz
   > ———
   > 4210 Via Arbolada #226Los Angeles, CA 90042
   > 323-225-7285
   > –
   >
   > The Sun, with all those planets going around it and dependent on it, can
   > still ripen a vine of grapes like it has nothing else to do in the world.
   >   — Galileo
   >
   > On Wednesday, April 19, 2023 at 03:07:29 AM PDT, Gary Gregory ***@***.***>
   > wrote:
   >
   >
   >
   >
   > @SwingGuy1024
   > You have 2 similar PRs for this class and this one fails. Which PR do you
   > want us to review? A PR for a fix should contain changes to main and test,
   > where a test fails if the changes to main are not applied.
   >
   > —
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > You are receiving this because you were mentioned.Message ID: ***@***.***>
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you commented.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #450: IO-790 symbolic link file filter test incomplete, needs to handle windows issues

[via GitHub]

garydgregory commented on PR #450:
URL: https://github.com/apache/commons-io/pull/450#issuecomment-1514471487

   @SwingGuy1024 
   You have 2 similar PRs for this class and this one fails. Which PR do you 
want us to review? A PR for a fix should contain changes to main and test, 
where a test fails if the changes to main are not applied. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org