[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
liran2000 commented on pull request #245: URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843 > > @XenoAmess @garydgregory thank you, can you then please review and merge this PR ? > > I should be able to look at this later today, AFK ATM. @garydgregory thanks, will wait for your review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
liran2000 commented on pull request #245: URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843 > > @XenoAmess @garydgregory thank you, can you then please review and merge this PR ? > > I should be able to look at this later today, AFK ATM. @garydgregory thanks, will wait for your review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
liran2000 commented on pull request #245: URL: https://github.com/apache/commons-io/pull/245#issuecomment-861453090 @XenoAmess @garydgregory thank you, can you then please review and merge this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860778084
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to
suggest Nullable or NotNull.
>
The most important here is to remove the "IllegalArgumentException" if
directory does not exist or from the javadoc, which does not match the
implementation condition: if (!directory.exists()) { return;}
Regarding Nullable/NotNull, got it, removed this addition for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
