[GitHub] [commons-lang] HubertWo commented on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-936515051 > > @XenoAmess Could you please be more descriptive? The only `String.valueOf` I have added are in high level methods, main logic does not. Actually I removed `String.valueOf` from loops. Sorry for answering in comment, but there's no way to add reply to your comment. > > @HubertWo > > Hi. > > I find some time today for this question (finally). > > `The only `String.valueOf` I have added are in high level methods, main logic does not` > > This statement be correct, but also be where I worried about performance. > > Please look at the sources in JDK, where `java.lang.AbstractStringBuilder#append(boolean b)` > > In short, for basic types, should not convert them to String, but use StringBuilder directly, will bring far better performance. > > BUT I just foundout that you did not bring this issue, this issue is already in commons-lang before your pr. > > So I will not stop you from merging this in, but still I will find time to refactor the whole `join` serial functions later. I was not aware of that. I will be happy to introduce changes (with JMH tests) related to your suggestions in separate PR. I've crated new JIRA for it: https://issues.apache.org/jira/browse/LANG-1675 Thank you for your time @XenoAmess . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-922648660 @garydgregory BUMP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-912228158 @garydgregory looks like I've addressed all the questions. Could you please review again? Hope this will be LGTM this time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-912227388 @XenoAmess Could you please be more descriptive? The only ```String.valueOf``` I have added are in high level methods, main logic does not. Actually I removed ```String.valueOf``` from loops. Sorry for answering in comment, but there's no way to add reply to your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
