[GitHub] [commons-lang] aherbert commented on pull request #953: Handle error messages with special characters.

[GitBox]

aherbert commented on PR #953:
URL: https://github.com/apache/commons-lang/pull/953#issuecomment-1255165118

   @stawirej I am not sure of the release schedule. There are a lot of fixes in 
lang 3.13-SNAPSHOT so a release may be done within a few months.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] aherbert commented on pull request #953: Handle error messages with special characters.

[GitBox]

aherbert commented on PR #953:
URL: https://github.com/apache/commons-lang/pull/953#issuecomment-1254216490

   @stawirej Thanks for the contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] aherbert commented on pull request #953: Handle error messages with special characters.

[GitBox]

aherbert commented on PR #953:
URL: https://github.com/apache/commons-lang/pull/953#issuecomment-1253767801

   IIUC the fix should remove the new public method and then add a private 
function:
   ```Java
   private static String getMessage(final String message, final Object... 
values) {
   return values.length == 0 ? message : String.format(message, values);
   }
   ```
   for use as:
   ```Java
   public static void isTrue(final boolean expression, final String message, 
final Object... values) {
   if (!expression) {
   throw new IllegalArgumentException(getMessage(message, values));
   }
   }
   ```
   This can be used in all call sites that have a varargs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org