[GitHub] [commons-lang] arturobernalg commented on a change in pull request #757: Use own validator ClassUtils.getName to get String input

[GitBox]

arturobernalg commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820495326



##
File path: src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
##
@@ -940,7 +941,7 @@ public void testParameterizeWithOwner() throws Exception {
 
 @Test
 public void testToLongString() {
-assertEquals(getClass().getName() + ":B", 
TypeUtils.toLongString(getClass().getTypeParameters()[0]));
+assertEquals(ClassUtils.getName(this) + ":B", 
TypeUtils.toLongString(getClass().getTypeParameters()[0]));

Review comment:
   changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #757: Use own validator ClassUtils.getName to get String input

[GitBox]

arturobernalg commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820494900



##
File path: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
##
@@ -378,7 +378,7 @@ public void test_getEnumMap_keyFunction() {
 
 @Test
 public void test_getEnumSystemProperty() {
-final String key = getClass().getName();
+final String key = ClassUtils.getName(this);

Review comment:
   changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #757: Use own validator ClassUtils.getName to get String input

[GitBox]

arturobernalg commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820271209



##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -3566,7 +3566,7 @@ public static boolean isSameType(final Object array1, 
final Object array2) {
 if (array1 == null || array2 == null) {
 throw new IllegalArgumentException("The Array must not be null");
 }
-return array1.getClass().getName().equals(array2.getClass().getName());
+return ClassUtils.getName(array1).equals(ClassUtils.getName(array2));

Review comment:
   Yep, my bad. changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org