[GitHub] [commons-lang] chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants

2019-04-05 Thread GitBox
chtompki commented on a change in pull request #415: LANG-1443: Add more 
SystemUtils.IS_JAVA_XX variants
URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761
 
 

 ##
 File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java
 ##
 @@ -20,23 +20,10 @@
 
 import org.junit.jupiter.api.Test;
 
-import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT;
+import static org.apache.commons.lang3.JavaVersion.*;
 
 Review comment:
   IntelliJ does that by default at greater than 5 import statements. It 
rewrites them with the *
   
   It drives me crazy


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [commons-lang] chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants

2019-04-05 Thread GitBox
chtompki commented on a change in pull request #415: LANG-1443: Add more 
SystemUtils.IS_JAVA_XX variants
URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761
 
 

 ##
 File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java
 ##
 @@ -20,23 +20,10 @@
 
 import org.junit.jupiter.api.Test;
 
-import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT;
+import static org.apache.commons.lang3.JavaVersion.*;
 
 Review comment:
   IntelliJ does that by default at greater than 5 import statements. It 
rewrites them with the *


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services