[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1527014772 @kinow and @garydgregory Can you guys have another look at this PR, all remarks have been processed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1320414172 @garydgregory did you have the time too look into this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1249516337 @garydgregory friendly reminder on this PR , are requested changes are tackled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1032768837 Hi @garydgregory I think all remarks have been resolved. Can you have another look at it and if not let me know. Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-999338912 > See my previous comment. Hi @garydgregory , extra testcases have been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-990193778 > Hi @debae Thank you for your patience. The code coverage for this new feature is not good enough IMO. Run `mvn clean site`, then browse the site in `target\site\index.html`, navigate to the JaCoCo report and you will see how your tests should be improved. For _new_ code, I'd like to get 100% code coverage which should be reasonable in this case. TY! No problem at all, some extra tests have been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
