[GitHub] [commons-lang] garydgregory commented on a change in pull request #797: Avoid multiple equivalent occurrences of the same expression.

2021-08-31 Thread GitBox 


garydgregory commented on a change in pull request #797:
URL: https://github.com/apache/commons-lang/pull/797#discussion_r698539764



##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@ -1365,12 +1365,10 @@ public static boolean isAssignable(Class cls, final 
Class toClass, final b
 if (Float.TYPE.equals(cls)) {
 return Double.TYPE.equals(toClass);
 }
-if (Character.TYPE.equals(cls)) {
-return Integer.TYPE.equals(toClass) || 
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) || 
Double.TYPE.equals(toClass);
-}
-if (Short.TYPE.equals(cls)) {
+if (Character.TYPE.equals(cls)  || Short.TYPE.equals(cls)) {
 return Integer.TYPE.equals(toClass) || 
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) || 
Double.TYPE.equals(toClass);
 }
+
 if (Byte.TYPE.equals(cls)) {

Review comment:
   Extra spacing not needed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a change in pull request #797: Avoid multiple equivalent occurrences of the same expression.

2021-08-30 Thread GitBox 


garydgregory commented on a change in pull request #797:
URL: https://github.com/apache/commons-lang/pull/797#discussion_r698539764



##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@ -1365,12 +1365,10 @@ public static boolean isAssignable(Class cls, final 
Class toClass, final b
 if (Float.TYPE.equals(cls)) {
 return Double.TYPE.equals(toClass);
 }
-if (Character.TYPE.equals(cls)) {
-return Integer.TYPE.equals(toClass) || 
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) || 
Double.TYPE.equals(toClass);
-}
-if (Short.TYPE.equals(cls)) {
+if (Character.TYPE.equals(cls)  || Short.TYPE.equals(cls)) {
 return Integer.TYPE.equals(toClass) || 
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) || 
Double.TYPE.equals(toClass);
 }
+
 if (Byte.TYPE.equals(cls)) {

Review comment:
   Extra spacing not needed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org