[GitHub] [commons-lang] garydgregory commented on a diff in pull request #654: [LANG-1533] - RandomStringUtils.random() should not include \u0000 or control characters

[GitBox]

garydgregory commented on code in PR #654:
URL: https://github.com/apache/commons-lang/pull/654#discussion_r914127759


##########
src/main/java/org/apache/commons/lang3/RandomStringUtils.java:
##########
@@ -404,6 +404,7 @@ public static String random(int count, int start, int end, 
final boolean letters
                 case Character.UNASSIGNED:
                 case Character.PRIVATE_USE:
                 case Character.SURROGATE:
+                case Character.CONTROL:

Review Comment:
   That does not look right IMO because it excludes the TAB character.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org