[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-541353891 @verhas In git master; please verify and close. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535749533 > > > Please merge it instead of nitpicking. > > > That's not the best attitude IMO. > > I said please. Btw: I opened a ticket https://issues.apache.org/jira/browse/LANG-1491 to fix this issue. It's rather simple IMO: this patch should be consistent with the current code base as it is now. IOW, tests are `public`. If someone wants to do the busy work of changing all of Commons Lang, more power to them, then the community can decide what to do, but this PR is not the place to do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535747664 > Please merge it instead of nitpicking. That's not the best attitude IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …
garydgregory commented on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535668589 Because all other tests are public. IOW, consistency. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
