[GitHub] [commons-lang] garydgregory commented on pull request #766: LANG-1172: Support dash as a delimiter in locales

2022-03-05 Thread GitBox


garydgregory commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1059896889


   You should build git master locally to make sure you can use the jar in your 
app.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-lang] garydgregory commented on pull request #766: LANG-1172: Support dash as a delimiter in locales

2021-11-08 Thread GitBox


garydgregory commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-963413151


   > @garydgregory Do you have feedback on this pull request? Anything holding 
this back from getting merged?
   
   I need to take the time to review, hopefully sometime this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-lang] garydgregory commented on pull request #766: LANG-1172: Support dash as a delimiter in locales

2021-10-16 Thread GitBox


garydgregory commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-944411168


   I will look this weekend. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-lang] garydgregory commented on pull request #766: LANG-1172: Support dash as a delimiter in locales

2021-10-08 Thread GitBox


garydgregory commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-939072265


   @c-w 
   May you please rebase on master?
   TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org