[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic

2021-10-17 Thread GitBox 


garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-945125094


   Hi @singhbaljit 
   Thank you for the PR but it breaks the build. Please run `mvn` from the 
command line -- this runs the default Maven goal -- before submitting a PR to 
discover any such issues.
   
   I brought in the `Range` generic changes, fixed the build issue, along with 
adding an expanded unit test based on your PR to cover all the factory methods. 
   
   May you please see git master and verify your use case?
   
   TY!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic

2021-10-13 Thread GitBox 


garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831


   I'll review sometime this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic

2021-10-12 Thread GitBox 


garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831


   I'll review sometime this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic

2021-10-08 Thread GitBox 


garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-939064699


   @singhbaljit ping.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic

2021-10-05 Thread GitBox 


garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-934628195


   You'll want to update the Javadoc and add a test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org