[GitHub] [commons-lang] garydgregory commented on pull request #838: [LANG-1677] Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1575668547 https://issues.apache.org/jira/browse/LANG-1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1320420683 I will be busy this weekend with Commons BCEL and Commons Net, so probably after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1249681336 I'll look over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1059765423 I'll take a look over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-989210626 Hi @debae Thank you for your patience. The code coverage for this new feature is not good enough IMO. Run `mvn clean site`, then browse the site in `target\site\index.html`, navigate to the JaCoCo report and you will see how your tests should be improved. For _new_ code, I'd like to get 100% code coverage which should be reasonable in this case. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
